Re: [Xen-devel] [PATCH lp-metadata 2/3] livepatch: Handle arbitrary size names with the list operation

From: Lars Kurth <lars.kurth.xen@gmail.com>
To: "Wieczorkiewicz, Pawel" <wipawel@amazon.de>
Cc: "Tim \(Xen.org\)" <tim@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	George Dunlap <George.Dunlap@eu.citrix.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Ian Jackson <ian.jackson@eu.citrix.com>,
	xen-devel <xen-devel@lists.xen.org>,
	"Pohlack, Martin" <mpohlack@amazon.de>,
	Ross Lagerwall <ross.lagerwall@citrix.com>,
	Julien Grall <julien.grall@arm.com>,
	'Jan Beulich' <jbeulich@suse.com>,
	xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [Xen-devel] [PATCH lp-metadata 2/3] livepatch: Handle arbitrary size names with the list operation
Date: Thu, 15 Aug 2019 16:46:33 +0100	[thread overview]
Message-ID: <C3D44CDE-E1C3-404D-852E-FDA691F09B82@gmail.com> (raw)
In-Reply-To: <18CBBC37-9027-41B7-8375-44FE3E56F79F@gmail.com>

[-- Attachment #1.1: Type: text/plain, Size: 2154 bytes --]

> On 15 Aug 2019, at 16:33, Lars Kurth <lars.kurth.xen@gmail.com> wrote:
> 
> 
> 
>> On 15 Aug 2019, at 16:19, Wieczorkiewicz, Pawel <wipawel@amazon.de <mailto:wipawel@amazon.de>> wrote:
>> 
>> Hi Lars, Julien,
>> 
>> Thanks for the pointers, I will read them up and follow the recommendations with my future contributions.
>> Sorry for the mess…
> 
> It's not really a mess: it must have been quite a pain to put the mails together manually
> And it would become more painful for a second revision
> I have been through this myself
> 
>> But, let me ask first before reading the wikis, how do you prefer submitting series that contain patches belonging to 2 distinct repos (e.g. xen and livepatch-build-tools)?
> 
> That's a good question and a very rare use-case. We split them, as all the tools such as git format-patch only work on one repo
> Applying patches also only works on a per repo basis
> 
> So, I would send two series. But mention the relationship in the cover letter (and/or patch if it is a single one)
> 
> The tools in the docs currently may not work on livepatch-build-tools.git
> * First: there is no MAINTAINERS file in livepatch-build-tools.git, which really should be added
> * Second: using xen.git:/scripts/add_maintainers.pl may not work when called from within livepatch-build-tools.git
> 
> I am going to play with this and update the docs and if needed the tools accordingly
> You may have to improvise in the meantime:
> * Step 1 & 3 will work: Step 2, option 1 will probably not (which means until I have done this, you may have to follow option 2 and make sure that the right people are CC'ed)

I can confirm that Step 2 does not work without some tools changes to scripts/add_maintainers.pl when called from within a non-xen.git repo

And 

git send-email --to xen-devel@lists.xenproject.org --cc-cmd="../xen.git/scripts/get_maintainer.pl" --dry-run -1

errors with 

../xen.git/scripts/get_maintainer.pl: The current directory does not appear to be a Xen source tree.

I need to fix this. Hopefully get_maintainer.pl isn't too dependant on the actual Xen tree

Lars

[-- Attachment #1.2: Type: text/html, Size: 5132 bytes --]

[-- Attachment #2: Type: text/plain, Size: 157 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel