Re: [Xen-devel] [PATCH lp-metadata 2/3] livepatch: Handle arbitrary size names with the list operation

[Lars Kurth <lars.kurth.xen@gmail.com>]

[-- Attachment #1.1: Type: text/plain, Size: 2821 bytes --]



> On 15 Aug 2019, at 17:29, Andrew Cooper <andrew.cooper3@citrix.com> wrote:
> 
> On 15/08/2019 16:42, Wieczorkiewicz, Pawel wrote:
>> Thanks Julien. I will do that next time (unless you guys want me to
>> re-send all this ;-)).
>> 
>> BTW, I also pushed my changes onto the xenbits server:
>> http://xenbits.xenproject.org/gitweb/?p=people/wipawel/livepatch-build-tools;a=summary
>> http://xenbits.xenproject.org/gitweb/?p=people/wipawel/xen;a=summary
>> 
>> I hope that makes navigation and dealing with the swarm of patches a
>> bit easier.
> 
> Please (re)send two patch series, one for Xen and one for build tools. 
> Even for he subset you posted before, I can't figure out whether they're
> ok to push straight away, or need more review.  This will be far easier
> to do in one single go (per repo).
> 
> My workflow for series is something like this:
> 
> First, confirm your git settings (details as appropriate)
> 
> $ git config -l | grep sendemail
> sendemail.smtpserver= $SERVER
> sendemail.chainreplyto=false
> sendemail.to=Xen-devel <xen-devel@lists.xenproject.org>
> sendemail.from= $ME <$ME@example.com>
> 
> Second, render the patch series:
> 
> $ mkdir foo-v1
> $ cd foo-v1
> $ git format-patch master --cover-letter
> 0000-cover-letter.patch
> 0001- ....
> ....
> 
> $ $EDITOR 0000-cover-letter.patch
> 
> Fill in as appropriate.  Provide a brief overview, note the subject of
> companion series, etc.  I also include the union of all CC'd people in
> each patch just below the Subject: header which avoids having to
> manually specify them later.  Be aware that it is strict about RFCs, so
> has to be Cc: and not CC:
> 
> Third, double check everything:
> 
> $ git send-email --dry-run *.patch
> 
> Fourth, spam the list by dropping the --dry-run.
> 
> Fifth, sit back and watch the reviews come in[1].
> 
> ~Andrew

@Andrew: You just outlined what's in the wiki and what the add_maintainers tool does.

We should chat about the Cc: vs CC: 
* I may need to fix the tool as it uses CC: when used with some options

@Pawel: I submitted 
https://lists.xenproject.org/archives/html/xen-devel/2019-08/msg01575.html <https://lists.xenproject.org/archives/html/xen-devel/2019-08/msg01575.html>
https://lists.xenproject.org/archives/html/xen-devel/2019-08/msg01581.html <https://lists.xenproject.org/archives/html/xen-devel/2019-08/msg01581.html>
which once applied ensures that the tools can be used on the live patch build tools

I also added https://wiki.xenproject.org/wiki/Submitting_Xen_Project_Patches#Using_add_maintainers.pl_.28or_get_maintainer.pl.29_from_outside_of_xen.git <https://wiki.xenproject.org/wiki/Submitting_Xen_Project_Patches#Using_add_maintainers.pl_.28or_get_maintainer.pl.29_from_outside_of_xen.git>

Lars


[-- Attachment #1.2: Type: text/html, Size: 4422 bytes --]

[-- Attachment #2: Type: text/plain, Size: 157 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel