From: "Tian, Kevin" <kevin.tian@intel.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>,
Xen-devel <xen-devel@lists.xenproject.org>
Cc: "Wei Liu" <wei.liu2@citrix.com>,
"Nakajima, Jun" <jun.nakajima@intel.com>,
"Jan Beulich" <JBeulich@suse.com>,
"Suravee Suthikulpanit" <suravee.suthikulpanit@amd.com>,
"Boris Ostrovsky" <boris.ostrovsky@oracle.com>,
"Brian Woods" <brian.woods@amd.com>,
"Roger Pau Monné" <roger.pau@citrix.com>
Subject: Re: [Xen-devel] [PATCH 1/2] x86: init_hypercall_page() cleanup
Date: Tue, 28 May 2019 05:31:04 +0000 [thread overview]
Message-ID: <AADFC41AFE54684AB9EE6CBC0274A5D19CA4E6B9@SHSMSX104.ccr.corp.intel.com> (raw)
Message-ID: <20190528053104.9sTwdSZxrF_j0v9vhHcOashPyFbUYSayHKo47yn20-E@z> (raw)
In-Reply-To: <1558606816-17842-2-git-send-email-andrew.cooper3@citrix.com>
> From: Andrew Cooper [mailto:andrew.cooper3@citrix.com]
> Sent: Thursday, May 23, 2019 6:20 PM
>
> The various pieces of the hypercall page infrastructure have grown
> organically over time and ended up in a bit of a mess.
>
> * Rename all functions to be of the form *_init_hypercall_page(). This
> makes them somewhat shorter, and means they can actually be grepped
> for in one go.
> * Move init_hypercall_page() to domain.c. The 64-bit traps.c isn't a
> terribly appropriate place for it to live.
> * Drop an obsolete comment from hvm_init_hypercall_page() and drop the
> domain parameter from hvm_funcs.init_hypercall_page() as it isn't
> necessary.
> * Rearrange the logic in the each function to avoid needing extra local
> variables, and to write the page in one single pass.
>
> No functional change.
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Reviewed-by: Kevin Tian <kevin.tian@intel.com>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-05-28 5:31 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-23 10:20 [PATCH 0/2] Hypercall page docs and code cleanup Andrew Cooper
2019-05-23 10:20 ` [Xen-devel] " Andrew Cooper
2019-05-23 10:20 ` [PATCH 1/2] x86: init_hypercall_page() cleanup Andrew Cooper
2019-05-23 10:20 ` [Xen-devel] " Andrew Cooper
2019-05-23 10:23 ` Wei Liu
2019-05-23 10:23 ` [Xen-devel] " Wei Liu
2019-05-23 10:49 ` Jan Beulich
2019-05-23 10:49 ` [Xen-devel] " Jan Beulich
2019-05-28 5:31 ` Tian, Kevin [this message]
2019-05-28 5:31 ` Tian, Kevin
2019-06-19 16:17 ` Woods, Brian
2019-05-23 10:20 ` [PATCH 2/2] docs: Introduce some hypercall page documentation Andrew Cooper
2019-05-23 10:20 ` [Xen-devel] " Andrew Cooper
2019-05-23 10:23 ` Wei Liu
2019-05-23 10:23 ` [Xen-devel] " Wei Liu
2019-05-23 10:56 ` Jan Beulich
2019-05-23 10:56 ` [Xen-devel] " Jan Beulich
2019-05-23 11:01 ` Andrew Cooper
2019-05-23 11:01 ` [Xen-devel] " Andrew Cooper
2019-05-23 11:41 ` Jan Beulich
2019-05-23 11:41 ` [Xen-devel] " Jan Beulich
2019-05-23 12:02 ` Andrew Cooper
2019-05-23 12:02 ` [Xen-devel] " Andrew Cooper
2019-05-23 12:14 ` Jan Beulich
2019-05-23 12:14 ` [Xen-devel] " Jan Beulich
2019-05-29 4:10 ` [PATCH v2 " Andrew Cooper
2019-05-29 4:10 ` [Xen-devel] " Andrew Cooper
[not found] ` <EF573A6C020000F58E2C01CD@prv1-mh.provo.novell.com>
2019-05-29 8:45 ` Jan Beulich
2019-05-29 8:45 ` [Xen-devel] " Jan Beulich
2019-05-29 11:50 ` Andrew Cooper
2019-05-29 11:50 ` [Xen-devel] " Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AADFC41AFE54684AB9EE6CBC0274A5D19CA4E6B9@SHSMSX104.ccr.corp.intel.com \
--to=kevin.tian@intel.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=boris.ostrovsky@oracle.com \
--cc=brian.woods@amd.com \
--cc=jun.nakajima@intel.com \
--cc=roger.pau@citrix.com \
--cc=suravee.suthikulpanit@amd.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).