RE: [PATCH 7/8] hw/i386/xen/xen-hvm: Use the IEC binary prefix definitions

From: Paul Durrant <xadimgnik@gmail.com>
To: "'Philippe Mathieu-Daudé'" <f4bug@amsat.org>, qemu-devel@nongnu.org
Cc: "'Peter Maydell'" <peter.maydell@linaro.org>,
	"'Stefano Stabellini'" <sstabellini@kernel.org>,
	"'Eduardo Habkost'" <ehabkost@redhat.com>,
	"'Michael S. Tsirkin'" <mst@redhat.com>,
	"'Andrew Jeffery'" <andrew@aj.id.au>,
	"'Helge Deller'" <deller@gmx.de>,
	"'Joel Stanley'" <joel@jms.id.au>,
	qemu-trivial@nongnu.org, qemu-arm@nongnu.org,
	"'Hervé Poussineau'" <hpoussin@reactos.org>,
	"'Cédric Le Goater'" <clg@kaod.org>,
	"'Paolo Bonzini'" <pbonzini@redhat.com>,
	"'Anthony Perard'" <anthony.perard@citrix.com>,
	xen-devel@lists.xenproject.org, qemu-ppc@nongnu.org,
	"'Richard Henderson'" <rth@twiddle.net>
Subject: RE: [PATCH 7/8] hw/i386/xen/xen-hvm: Use the IEC binary prefix definitions
Date: Mon, 1 Jun 2020 08:26:16 +0100	[thread overview]
Message-ID: <000001d637e5$f0c4b4f0$d24e1ed0$@xen.org> (raw)
In-Reply-To: <20200531173814.8734-8-f4bug@amsat.org>

> -----Original Message-----
> From: Philippe Mathieu-Daudé <philippe.mathieu.daude@gmail.com> On Behalf Of Philippe Mathieu-Daudé
> Sent: 31 May 2020 18:38
> To: qemu-devel@nongnu.org
> Cc: Andrew Jeffery <andrew@aj.id.au>; Helge Deller <deller@gmx.de>; Peter Maydell
> <peter.maydell@linaro.org>; Richard Henderson <rth@twiddle.net>; Eduardo Habkost
> <ehabkost@redhat.com>; Paul Durrant <paul@xen.org>; Hervé Poussineau <hpoussin@reactos.org>; Marcel
> Apfelbaum <marcel.apfelbaum@gmail.com>; xen-devel@lists.xenproject.org; Paolo Bonzini
> <pbonzini@redhat.com>; Stefano Stabellini <sstabellini@kernel.org>; Cédric Le Goater <clg@kaod.org>;
> qemu-trivial@nongnu.org; Joel Stanley <joel@jms.id.au>; qemu-arm@nongnu.org; Michael S. Tsirkin
> <mst@redhat.com>; Anthony Perard <anthony.perard@citrix.com>; qemu-ppc@nongnu.org; Philippe Mathieu-
> Daudé <f4bug@amsat.org>
> Subject: [PATCH 7/8] hw/i386/xen/xen-hvm: Use the IEC binary prefix definitions
> 
> IEC binary prefixes ease code review: the unit is explicit.
> 
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>  hw/i386/xen/xen-hvm.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/hw/i386/xen/xen-hvm.c b/hw/i386/xen/xen-hvm.c
> index 82ece6b9e7..679d74e6a3 100644
> --- a/hw/i386/xen/xen-hvm.c
> +++ b/hw/i386/xen/xen-hvm.c
> @@ -9,6 +9,7 @@
>   */
> 
>  #include "qemu/osdep.h"
> +#include "qemu/units.h"
> 
>  #include "cpu.h"
>  #include "hw/pci/pci.h"
> @@ -230,7 +231,7 @@ static void xen_ram_init(PCMachineState *pcms,
>           * Xen does not allocate the memory continuously, it keeps a
>           * hole of the size computed above or passed in.
>           */
> -        block_len = (1ULL << 32) + x86ms->above_4g_mem_size;
> +        block_len = 4 * GiB + x86ms->above_4g_mem_size;

Not strictly necessary but could we retain the brackets please?

  Paul

>      }
>      memory_region_init_ram(&ram_memory, NULL, "xen.ram", block_len,
>                             &error_fatal);
> --
> 2.21.3