RE: [PATCH v2 14/16] arm64: dts: fsd: Add initial device tree support

From: "Alim Akhtar" <alim.akhtar@samsung.com>
To: "'Krzysztof Kozlowski'" <krzysztof.kozlowski@canonical.com>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>
Cc: <soc@kernel.org>, <linux-clk@vger.kernel.org>,
	<devicetree@vger.kernel.org>, <olof@lixom.net>, <arnd@arndb.de>,
	<linus.walleij@linaro.org>, <catalin.marinas@arm.com>,
	<robh+dt@kernel.org>, <s.nawrocki@samsung.com>,
	<linux-samsung-soc@vger.kernel.org>, <pankaj.dubey@samsung.com>,
	<linux-fsd@tesla.com>, "'Arjun K V'" <arjun.kv@samsung.com>,
	"'Aswani Reddy'" <aswani.reddy@samsung.com>,
	"'Ajay Kumar'" <ajaykumar.rs@samsung.com>,
	"'Sriranjani P'" <sriranjani.p@samsung.com>,
	"'Chandrasekar R'" <rcsekar@samsung.com>,
	"'Shashank Prashar'" <s.prashar@samsung.com>
Subject: RE: [PATCH v2 14/16] arm64: dts: fsd: Add initial device tree support
Date: Wed, 19 Jan 2022 20:37:40 +0530	[thread overview]
Message-ID: <000301d80d46$502ae590$f080b0b0$@samsung.com> (raw)
In-Reply-To: <43e72d34-0e11-9ff6-6924-0cab62b51891@canonical.com>


>-----Original Message-----
>From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@canonical.com]
>Sent: Wednesday, January 19, 2022 12:15 AM
>To: Alim Akhtar <alim.akhtar@samsung.com>; linux-arm-
>kernel@lists.infradead.org; linux-kernel@vger.kernel.org
>Cc: soc@kernel.org; linux-clk@vger.kernel.org; devicetree@vger.kernel.org;
>olof@lixom.net; arnd@arndb.de; linus.walleij@linaro.org;
>catalin.marinas@arm.com; robh+dt@kernel.org; s.nawrocki@samsung.com;
>linux-samsung-soc@vger.kernel.org; pankaj.dubey@samsung.com; linux-
>fsd@tesla.com; Arjun K V <arjun.kv@samsung.com>; Aswani Reddy
><aswani.reddy@samsung.com>; Ajay Kumar <ajaykumar.rs@samsung.com>;
>Sriranjani P <sriranjani.p@samsung.com>; Chandrasekar R
><rcsekar@samsung.com>; Shashank Prashar <s.prashar@samsung.com>
>Subject: Re: [PATCH v2 14/16] arm64: dts: fsd: Add initial device tree support
>
>On 18/01/2022 15:48, Alim Akhtar wrote:
>> Add initial device tree support for "Full Self-Driving" (FSD) SoC This
>> SoC contain three clusters of four cortex-a72 CPUs and various
>> peripheral IPs.
>>
>> Cc: linux-fsd@tesla.com
>> Signed-off-by: Arjun K V <arjun.kv@samsung.com>
>> Signed-off-by: Aswani Reddy <aswani.reddy@samsung.com>
>> Signed-off-by: Ajay Kumar <ajaykumar.rs@samsung.com>
>> Signed-off-by: Sriranjani P <sriranjani.p@samsung.com>
>> Signed-off-by: Chandrasekar R <rcsekar@samsung.com>
>> Signed-off-by: Shashank Prashar <s.prashar@samsung.com>
>> Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com>
>> ---
>>  MAINTAINERS                           |   8 +
>>  arch/arm64/Kconfig.platforms          |   7 +
>>  arch/arm64/boot/dts/Makefile          |   1 +
>>  arch/arm64/boot/dts/tesla/Makefile    |   3 +
>>  arch/arm64/boot/dts/tesla/fsd-evb.dts |  39 ++
>>  arch/arm64/boot/dts/tesla/fsd.dtsi    | 651
>++++++++++++++++++++++++++
>>  6 files changed, 709 insertions(+)
>>  create mode 100644 arch/arm64/boot/dts/tesla/Makefile
>>  create mode 100644 arch/arm64/boot/dts/tesla/fsd-evb.dts
>>  create mode 100644 arch/arm64/boot/dts/tesla/fsd.dtsi
>>
>
>I saw you dropped the MCT timer from DTSI. I wonder why?
>
I dropped it intentionally, as you had a comment on MCT driver changes, so will send later along with MCT driver fix.

>Not very happy with FSD naming (as discussed before), but board compatible
>looks reasonable. Code looks good to me:
>Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
>
Thanks Krzysztof for all the reviews.

>Similarly to previous vendor-prefix patch, please let me know if it's expected
>me to take it. I assume no. :)
>
I am expecting this will go via your tree, but I am ok either ways. May be you and arm-soc maintainers (Arnd/Olof) can take the call here.

>Best regards,
>Krzysztof