RE: [PATCH v9 4/11] xfsprogs: xfs_io: add finsert command for insert range

From: Namjae Jeon <namjae.jeon@samsung.com>
To: "'Dave Chinner'" <david@fromorbit.com>
Cc: tytso@mit.edu, bfoster@redhat.com, linux-kernel@vger.kernel.org,
	xfs@oss.sgi.com, a.sangwan@samsung.com,
	linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org,
	"'Namjae Jeon'" <linkinjeon@gmail.com>
Subject: RE: [PATCH v9 4/11] xfsprogs: xfs_io: add finsert command for insert range
Date: Fri, 06 Feb 2015 13:27:53 +0900	[thread overview]
Message-ID: <001e01d041c5$466b6330$d3422990$@samsung.com> (raw)
In-Reply-To: <20150206031129.GL12722@dastard>

> Hi Namjae,
Hi Dave,
> 
> On Fri, Feb 06, 2015 at 10:40:33AM +1100, Dave Chinner wrote:
> > On Thu, Jan 22, 2015 at 12:11:59AM +0900, Namjae Jeon wrote:
> > > From: Namjae Jeon <namjae.jeon@samsung.com>
> > >
> > > Add finsert command for fallocate FALLOC_FL_INSERT_RANGE flag.
> > >
> > > Signed-off-by: Namjae Jeon <namjae.jeon@samsung.com>
> > > Signed-off-by: Ashish Sangwan <a.sangwan@samsung.com>
> > > Reviewed-by: Brian Foster <bfoster@redhat.com>
> >
> > I've just pulled this patch into xfsprogs in preparation for getting
> > this functionality fully reviewed and merged in the 3.21 kernel
> > cycle.
> 
> xfs/293 3s ... - output mismatch (see /home/dave/src/xfstests-dev/results//xfs/293.out.bad)
>     --- tests/xfs/293.out       2014-01-20 16:57:34.000000000 +1100
>     +++ /home/dave/src/xfstests-dev/results//xfs/293.out.bad    2015-02-06 12:21:47.000000000 +1100
>     @@ -1,2 +1,3 @@
>      QA output created by 293
>      Silence is golden
>     +finsert not documented in the xfs_io manpage
>     .....
> 
> Can you send a patch that updates the xfs_io man page, please?
Okay, I will send it soon.
Thanks a lot!
> 
> Cheers,
> 
> Dave.
> --
> Dave Chinner
> david@fromorbit.com