From: Pu Wen <puwen@hygon.cn>
To: Borislav Petkov <bp@alien8.de>
Cc: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com,
x86@kernel.org, thomas.lendacky@amd.com, pbonzini@redhat.com,
tony.luck@intel.com, linux-kernel@vger.kernel.org,
linux-arch@vger.kernel.org, linux-edac@vger.kernel.org
Subject: Re: [PATCH v5 10/16] x86/mce: enable Hygon support to MCE infrastructure
Date: Wed, 5 Sep 2018 20:59:24 +0800 [thread overview]
Message-ID: <01604799-b993-e530-817c-ad097d343fc4@hygon.cn> (raw)
In-Reply-To: <20180905092234.GC2237@zn.tnic>
On 2018/9/5 17:22, Borislav Petkov wrote:
>> @@ -214,6 +214,11 @@ static inline void mce_amd_feature_init(struct cpuinfo_x86 *c) { }
>> #endif
>>
>> +static inline void mce_hygon_feature_init(struct cpuinfo_x86 *c)
>> +{
>> + return mce_amd_feature_init(c);
>> +}
>> +
>
> What happens if CONFIG_X86_MCE_AMD=n ?
If CONFIG_X86_MCE_AMD=n, mce_hygon_feature_init will call the other
one mce_amd_feature_init which is a null function and located in the
else branch of "#ifdef CONFIG_X86_MCE_AMD". The compilation is OK and
the kernel will run without MCE support.
> In general, since you're using AMD code, you need to make CPU_SUP_HYGON
> depend on a bunch of AMD config items like CONFIG_X86_MCE_AMD,
> CONFIG_CPU_SUP_AMD, CONFIG_AMD_NB,... Audit your code and see what other
> config items need to be selected.
All right, will check all the config items which are necessary for
CONFIG_CPU_SUP_HYGON.
--
Regards,
Pu Wen
WARNING: multiple messages have this Message-ID (diff)
From: Pu Wen <puwen@hygon.cn>
To: Borislav Petkov <bp@alien8.de>
Cc: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com,
x86@kernel.org, thomas.lendacky@amd.com, pbonzini@redhat.com,
tony.luck@intel.com, linux-kernel@vger.kernel.org,
linux-arch@vger.kernel.org, linux-edac@vger.kernel.org
Subject: [v5,10/16] x86/mce: enable Hygon support to MCE infrastructure
Date: Wed, 5 Sep 2018 20:59:24 +0800 [thread overview]
Message-ID: <01604799-b993-e530-817c-ad097d343fc4@hygon.cn> (raw)
On 2018/9/5 17:22, Borislav Petkov wrote:
>> @@ -214,6 +214,11 @@ static inline void mce_amd_feature_init(struct cpuinfo_x86 *c) { }
>> #endif
>>
>> +static inline void mce_hygon_feature_init(struct cpuinfo_x86 *c)
>> +{
>> + return mce_amd_feature_init(c);
>> +}
>> +
>
> What happens if CONFIG_X86_MCE_AMD=n ?
If CONFIG_X86_MCE_AMD=n, mce_hygon_feature_init will call the other
one mce_amd_feature_init which is a null function and located in the
else branch of "#ifdef CONFIG_X86_MCE_AMD". The compilation is OK and
the kernel will run without MCE support.
> In general, since you're using AMD code, you need to make CPU_SUP_HYGON
> depend on a bunch of AMD config items like CONFIG_X86_MCE_AMD,
> CONFIG_CPU_SUP_AMD, CONFIG_AMD_NB,... Audit your code and see what other
> config items need to be selected.
All right, will check all the config items which are necessary for
CONFIG_CPU_SUP_HYGON.
next prev parent reply other threads:[~2018-09-05 12:59 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-29 12:42 [PATCH v5 00/16] Add support for Hygon Dhyana Family 18h processor Pu Wen
2018-08-29 12:42 ` [PATCH v5 01/16] x86/cpu: create Dhyana init file and register new cpu_dev to system Pu Wen
2018-08-29 19:35 ` Andi Kleen
2018-08-30 17:40 ` Pu Wen
2018-08-30 12:35 ` Borislav Petkov
2018-08-30 18:02 ` Pu Wen
2018-08-29 12:43 ` [PATCH v5 02/16] x86/cache: get cache size/leaves and setup cache cpumap for Dhyana Pu Wen
2018-09-03 9:57 ` Borislav Petkov
2018-09-03 12:59 ` Pu Wen
2018-08-29 12:43 ` [PATCH v5 03/16] x86/mtrr: get MTRR number and support TOP_MEM2 Pu Wen
2018-09-03 19:04 ` Borislav Petkov
2018-09-04 3:02 ` Pu Wen
2018-09-04 8:02 ` Borislav Petkov
2018-09-04 12:43 ` Pu Wen
2018-08-29 12:43 ` [PATCH v5 04/16] x86/smpboot: smp init nodelay and no flush caches before sleep Pu Wen
2018-09-04 9:15 ` Borislav Petkov
2018-08-29 12:43 ` [PATCH v5 05/16] x86/pmu: enable Hygon support to PMU infrastructure Pu Wen
2018-09-04 10:48 ` Borislav Petkov
2018-09-04 13:32 ` Pu Wen
2018-08-29 12:44 ` [PATCH v5 06/16] x86/nops: init ideal_nops for Hygon Pu Wen
2018-09-04 14:01 ` Borislav Petkov
2018-08-29 12:44 ` [PATCH v5 07/16] x86/pci: add Hygon PCI vendor and northbridge support Pu Wen
2018-09-04 14:52 ` Borislav Petkov
2018-09-04 15:45 ` Pu Wen
2018-09-04 16:03 ` Borislav Petkov
2018-08-29 12:44 ` [PATCH v5 08/16] x86/apic: add modern APIC support for Hygon Pu Wen
2018-09-04 18:33 ` Borislav Petkov
2018-09-05 8:08 ` Pu Wen
2018-08-29 12:44 ` [PATCH v5 09/16] x86/bugs: add lfence mitigation to spectre v2 and no meltdown " Pu Wen
2018-09-05 9:13 ` Borislav Petkov
2018-09-05 10:40 ` Pu Wen
2018-08-29 12:44 ` [PATCH v5 10/16] x86/mce: enable Hygon support to MCE infrastructure Pu Wen
2018-08-29 12:44 ` [v5,10/16] " Pu Wen
2018-09-05 9:22 ` [PATCH v5 10/16] " Borislav Petkov
2018-09-05 9:22 ` [v5,10/16] " Borislav Petkov
2018-09-05 12:59 ` Pu Wen [this message]
2018-09-05 12:59 ` Pu Wen
2018-09-05 13:15 ` [PATCH v5 10/16] " Borislav Petkov
2018-09-05 13:15 ` [v5,10/16] " Borislav Petkov
2018-09-06 3:52 ` [PATCH v5 10/16] " Pu Wen
2018-09-06 3:52 ` [v5,10/16] " Pu Wen
2018-09-06 8:39 ` [PATCH v5 10/16] " Borislav Petkov
2018-09-06 8:39 ` [v5,10/16] " Borislav Petkov
2018-09-06 11:40 ` [PATCH v5 10/16] " Pu Wen
2018-09-06 11:40 ` [v5,10/16] " Pu Wen
2018-09-06 12:29 ` [PATCH v5 10/16] " Borislav Petkov
2018-09-06 12:29 ` [v5,10/16] " Borislav Petkov
2018-09-06 15:47 ` [PATCH v5 10/16] " Pu Wen
2018-09-06 15:47 ` [v5,10/16] " Pu Wen
2018-08-29 12:45 ` [PATCH v5 11/16] x86/kvm: enable Hygon support to KVM infrastructure Pu Wen
2018-09-05 10:30 ` Borislav Petkov
2018-08-29 12:45 ` [PATCH v5 12/16] x86/xen: enable Hygon support to Xen Pu Wen
2018-08-29 12:45 ` Pu Wen
2018-08-29 12:45 ` [PATCH v5 13/16] driver/acpi: enable Hygon support to ACPI driver Pu Wen
2018-08-29 12:45 ` [PATCH v5 14/16] driver/cpufreq: enable Hygon support to cpufreq driver Pu Wen
2018-08-29 12:45 ` [PATCH v5 15/16] driver/edac: enable Hygon support to AMD64 EDAC driver Pu Wen
2018-08-29 12:45 ` [v5,15/16] " Pu Wen
2018-09-05 10:44 ` [PATCH v5 15/16] " Borislav Petkov
2018-09-05 10:44 ` [v5,15/16] " Borislav Petkov
2018-09-05 13:03 ` [PATCH v5 15/16] " Pu Wen
2018-09-05 13:03 ` [v5,15/16] " Pu Wen
2018-08-29 12:45 ` [PATCH v5 16/16] tools/cpupower: enable Hygon support to cpupower tool Pu Wen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=01604799-b993-e530-817c-ad097d343fc4@hygon.cn \
--to=puwen@hygon.cn \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.