From: Shyam Sundar S K <Shyam-sundar.S-k@amd.com> To: Mario Limonciello <mario.limonciello@amd.com>, hdegoede@redhat.com, markgross@kernel.org, basavaraj.natikar@amd.com, jikos@kernel.org, benjamin.tissoires@redhat.com, alexander.deucher@amd.com, christian.koenig@amd.com, Xinhui.Pan@amd.com, airlied@gmail.com, daniel@ffwll.ch Cc: Patil.Reddy@amd.com, platform-driver-x86@vger.kernel.org, linux-input@vger.kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH 11/15] platform/x86/amd/pmf: dump policy binary data Date: Sat, 30 Sep 2023 10:11:11 +0530 [thread overview] Message-ID: <02b2307f-003e-4496-93ab-53674dd7c49e@amd.com> (raw) In-Reply-To: <fa4f1a5b-5ea1-4884-aafe-36696b491654@amd.com> On 9/23/2023 12:31 AM, Mario Limonciello wrote: > On 9/22/2023 12:50, Shyam Sundar S K wrote: >> Sometimes policy binary retrieved from the BIOS maybe incorrect that >> can >> end up in failing to enable the Smart PC solution feature. >> >> Use print_hex_dump_debug() to dump the policy binary in hex, so that we >> debug the issues related to the binary even before sending that to TA. >> >> Signed-off-by: Shyam Sundar S K <Shyam-sundar.S-k@amd.com> >> --- >> drivers/platform/x86/amd/pmf/tee-if.c | 7 +++++++ >> 1 file changed, 7 insertions(+) >> >> diff --git a/drivers/platform/x86/amd/pmf/tee-if.c >> b/drivers/platform/x86/amd/pmf/tee-if.c >> index fa37cfab2dc7..3daa122f35d5 100644 >> --- a/drivers/platform/x86/amd/pmf/tee-if.c >> +++ b/drivers/platform/x86/amd/pmf/tee-if.c >> @@ -290,6 +290,9 @@ static ssize_t amd_pmf_get_pb_data(struct file >> *filp, const char __user *buf, >> if (copy_from_user(dev->policy_buf, buf, dev->policy_sz)) >> return -EFAULT; >> + print_hex_dump_debug("(pb): ", DUMP_PREFIX_OFFSET, 16, 1, >> dev->policy_buf, >> + dev->policy_sz, false); >> + > > Should this one also be guarded by CONFIG_AMD_PMF_DEBUG or no? No, as this dump is called from amd_pmf_get_pb_data() which is already under CONFIG_AMD_PMF_DEBUG. > >> ret = amd_pmf_start_policy_engine(dev); >> if (ret) >> return -EINVAL; >> @@ -329,6 +332,10 @@ static int amd_pmf_get_bios_buffer(struct >> amd_pmf_dev *dev) >> return -ENOMEM; >> memcpy(dev->policy_buf, dev->policy_base, dev->policy_sz); >> +#ifdef CONFIG_AMD_PMF_DEBUG >> + print_hex_dump_debug("(pb): ", DUMP_PREFIX_OFFSET, 16, 1, >> dev->policy_buf, >> + dev->policy_sz, false); >> +#endif >> #ifdef CONFIG_AMD_PMF_DEBUG >> if (pb_side_load) > > It looks like you can combine the two #ifdef from the previous patches. Thank you, I have addressed this in v2. Thanks, Shyam
WARNING: multiple messages have this Message-ID (diff)
From: Shyam Sundar S K <Shyam-sundar.S-k@amd.com> To: Mario Limonciello <mario.limonciello@amd.com>, hdegoede@redhat.com, markgross@kernel.org, basavaraj.natikar@amd.com, jikos@kernel.org, benjamin.tissoires@redhat.com, alexander.deucher@amd.com, christian.koenig@amd.com, Xinhui.Pan@amd.com, airlied@gmail.com, daniel@ffwll.ch Cc: dri-devel@lists.freedesktop.org, linux-input@vger.kernel.org, amd-gfx@lists.freedesktop.org, Patil.Reddy@amd.com, platform-driver-x86@vger.kernel.org Subject: Re: [PATCH 11/15] platform/x86/amd/pmf: dump policy binary data Date: Sat, 30 Sep 2023 10:11:11 +0530 [thread overview] Message-ID: <02b2307f-003e-4496-93ab-53674dd7c49e@amd.com> (raw) In-Reply-To: <fa4f1a5b-5ea1-4884-aafe-36696b491654@amd.com> On 9/23/2023 12:31 AM, Mario Limonciello wrote: > On 9/22/2023 12:50, Shyam Sundar S K wrote: >> Sometimes policy binary retrieved from the BIOS maybe incorrect that >> can >> end up in failing to enable the Smart PC solution feature. >> >> Use print_hex_dump_debug() to dump the policy binary in hex, so that we >> debug the issues related to the binary even before sending that to TA. >> >> Signed-off-by: Shyam Sundar S K <Shyam-sundar.S-k@amd.com> >> --- >> drivers/platform/x86/amd/pmf/tee-if.c | 7 +++++++ >> 1 file changed, 7 insertions(+) >> >> diff --git a/drivers/platform/x86/amd/pmf/tee-if.c >> b/drivers/platform/x86/amd/pmf/tee-if.c >> index fa37cfab2dc7..3daa122f35d5 100644 >> --- a/drivers/platform/x86/amd/pmf/tee-if.c >> +++ b/drivers/platform/x86/amd/pmf/tee-if.c >> @@ -290,6 +290,9 @@ static ssize_t amd_pmf_get_pb_data(struct file >> *filp, const char __user *buf, >> if (copy_from_user(dev->policy_buf, buf, dev->policy_sz)) >> return -EFAULT; >> + print_hex_dump_debug("(pb): ", DUMP_PREFIX_OFFSET, 16, 1, >> dev->policy_buf, >> + dev->policy_sz, false); >> + > > Should this one also be guarded by CONFIG_AMD_PMF_DEBUG or no? No, as this dump is called from amd_pmf_get_pb_data() which is already under CONFIG_AMD_PMF_DEBUG. > >> ret = amd_pmf_start_policy_engine(dev); >> if (ret) >> return -EINVAL; >> @@ -329,6 +332,10 @@ static int amd_pmf_get_bios_buffer(struct >> amd_pmf_dev *dev) >> return -ENOMEM; >> memcpy(dev->policy_buf, dev->policy_base, dev->policy_sz); >> +#ifdef CONFIG_AMD_PMF_DEBUG >> + print_hex_dump_debug("(pb): ", DUMP_PREFIX_OFFSET, 16, 1, >> dev->policy_buf, >> + dev->policy_sz, false); >> +#endif >> #ifdef CONFIG_AMD_PMF_DEBUG >> if (pb_side_load) > > It looks like you can combine the two #ifdef from the previous patches. Thank you, I have addressed this in v2. Thanks, Shyam
next prev parent reply other threads:[~2023-09-30 4:41 UTC|newest] Thread overview: 127+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-09-22 17:50 [PATCH 00/15] Introduce PMF Smart PC Solution Builder Feature Shyam Sundar S K 2023-09-22 17:50 ` Shyam Sundar S K 2023-09-22 17:50 ` [PATCH 01/15] platform/x86/amd/pmf: Add PMF TEE interface Shyam Sundar S K 2023-09-22 17:50 ` Shyam Sundar S K 2023-09-26 16:42 ` Ilpo Järvinen 2023-09-26 16:42 ` Ilpo Järvinen 2023-09-26 16:42 ` Ilpo Järvinen 2023-09-22 17:50 ` [PATCH 02/15] platform/x86/amd/pmf: Add support PMF-TA interaction Shyam Sundar S K 2023-09-22 17:50 ` Shyam Sundar S K 2023-09-26 16:48 ` Ilpo Järvinen 2023-09-26 16:48 ` Ilpo Järvinen 2023-09-26 16:48 ` Ilpo Järvinen 2023-09-22 17:50 ` [PATCH 03/15] platform/x86/amd/pmf: Change signature of amd_pmf_set_dram_addr Shyam Sundar S K 2023-09-22 17:50 ` Shyam Sundar S K 2023-09-26 16:52 ` Ilpo Järvinen 2023-09-26 16:52 ` Ilpo Järvinen 2023-09-26 16:52 ` Ilpo Järvinen 2023-09-22 17:50 ` [PATCH 04/15] platform/x86/amd/pmf: Add support for PMF Policy Binary Shyam Sundar S K 2023-09-22 17:50 ` Shyam Sundar S K 2023-09-22 18:51 ` Mario Limonciello 2023-09-22 18:51 ` Mario Limonciello 2023-09-30 3:55 ` Shyam Sundar S K 2023-09-30 3:55 ` Shyam Sundar S K 2023-09-26 17:05 ` Ilpo Järvinen 2023-09-26 17:05 ` Ilpo Järvinen 2023-09-26 17:05 ` Ilpo Järvinen 2023-09-27 12:19 ` Ilpo Järvinen 2023-09-27 12:19 ` Ilpo Järvinen 2023-09-27 12:19 ` Ilpo Järvinen 2023-09-22 17:50 ` [PATCH 05/15] platform/x86/amd/pmf: change debugfs init sequence Shyam Sundar S K 2023-09-22 17:50 ` Shyam Sundar S K 2023-09-26 16:53 ` Ilpo Järvinen 2023-09-26 16:53 ` Ilpo Järvinen 2023-09-26 16:53 ` Ilpo Järvinen 2023-09-22 17:50 ` [PATCH 06/15] platform/x86/amd/pmf: Add support to get inputs from other subsystems Shyam Sundar S K 2023-09-22 17:50 ` Shyam Sundar S K 2023-09-26 17:08 ` Ilpo Järvinen 2023-09-26 17:08 ` Ilpo Järvinen 2023-09-26 17:08 ` Ilpo Järvinen 2023-09-30 8:40 ` Shyam Sundar S K 2023-09-30 8:40 ` Shyam Sundar S K 2023-09-30 8:40 ` Shyam Sundar S K 2023-10-02 9:10 ` Ilpo Järvinen 2023-10-02 9:10 ` Ilpo Järvinen 2023-10-02 9:10 ` Ilpo Järvinen 2023-09-22 17:50 ` [PATCH 07/15] platform/x86/amd/pmf: Add support update p3t limit Shyam Sundar S K 2023-09-22 17:50 ` Shyam Sundar S K 2023-09-27 12:19 ` Ilpo Järvinen 2023-09-27 12:19 ` Ilpo Järvinen 2023-09-27 12:19 ` Ilpo Järvinen 2023-09-22 17:50 ` [PATCH 08/15] platform/x86/amd/pmf: Add support to update system state Shyam Sundar S K 2023-09-22 17:50 ` Shyam Sundar S K 2023-09-25 21:42 ` kernel test robot 2023-09-25 21:42 ` kernel test robot 2023-09-27 12:22 ` Ilpo Järvinen 2023-09-27 12:22 ` Ilpo Järvinen 2023-09-27 12:22 ` Ilpo Järvinen 2023-09-22 17:50 ` [PATCH 09/15] platform/x86/amd/pmf: Add facility to dump TA inputs Shyam Sundar S K 2023-09-22 17:50 ` Shyam Sundar S K 2023-09-27 12:25 ` Ilpo Järvinen 2023-09-27 12:25 ` Ilpo Järvinen 2023-09-27 12:25 ` Ilpo Järvinen 2023-09-22 17:50 ` [PATCH 10/15] platform/x86/amd/pmf: Add capability to sideload of policy binary Shyam Sundar S K 2023-09-22 17:50 ` Shyam Sundar S K 2023-09-25 2:14 ` kernel test robot 2023-09-25 2:14 ` kernel test robot 2023-09-27 12:33 ` Ilpo Järvinen 2023-09-27 12:33 ` Ilpo Järvinen 2023-09-27 12:33 ` Ilpo Järvinen 2023-09-22 17:50 ` [PATCH 11/15] platform/x86/amd/pmf: dump policy binary data Shyam Sundar S K 2023-09-22 17:50 ` Shyam Sundar S K 2023-09-22 19:01 ` Mario Limonciello 2023-09-22 19:01 ` Mario Limonciello 2023-09-30 4:41 ` Shyam Sundar S K [this message] 2023-09-30 4:41 ` Shyam Sundar S K 2023-09-22 17:50 ` [PATCH 12/15] platform/x86/amd/pmf: Add PMF-AMDGPU get interface Shyam Sundar S K 2023-09-22 17:50 ` Shyam Sundar S K 2023-09-27 12:54 ` Ilpo Järvinen 2023-09-27 12:54 ` Ilpo Järvinen 2023-09-27 12:54 ` Ilpo Järvinen 2023-09-22 17:50 ` [PATCH 13/15] platform/x86/amd/pmf: Add PMF-AMDGPU set interface Shyam Sundar S K 2023-09-22 17:50 ` Shyam Sundar S K 2023-09-25 16:27 ` Deucher, Alexander 2023-09-25 16:27 ` Deucher, Alexander 2023-09-25 16:27 ` Deucher, Alexander 2023-09-25 16:30 ` Mario Limonciello 2023-09-25 16:30 ` Mario Limonciello 2023-09-26 11:17 ` Shyam Sundar S K 2023-09-26 11:17 ` Shyam Sundar S K 2023-09-26 11:15 ` Shyam Sundar S K 2023-09-26 11:15 ` Shyam Sundar S K 2023-09-26 10:35 ` Hans de Goede 2023-09-26 10:35 ` Hans de Goede 2023-09-26 11:24 ` Shyam Sundar S K 2023-09-26 11:24 ` Shyam Sundar S K 2023-09-26 12:56 ` Hans de Goede 2023-09-26 12:56 ` Hans de Goede 2023-09-26 13:17 ` Christian König 2023-09-26 13:17 ` Christian König 2023-09-26 13:48 ` Shyam Sundar S K 2023-09-26 13:48 ` Shyam Sundar S K 2023-09-27 13:04 ` Hans de Goede 2023-09-27 13:04 ` Hans de Goede 2023-09-27 13:47 ` Shyam Sundar S K 2023-09-27 13:47 ` Shyam Sundar S K 2023-09-27 13:36 ` Ilpo Järvinen 2023-09-27 13:36 ` Ilpo Järvinen 2023-09-27 13:36 ` Ilpo Järvinen 2023-09-22 17:50 ` [PATCH 14/15] platform/x86/amd/pmf: Add PMF-AMDSFH interface for HPD Shyam Sundar S K 2023-09-22 17:50 ` Shyam Sundar S K 2023-09-22 19:04 ` Mario Limonciello 2023-09-22 19:04 ` Mario Limonciello 2023-09-22 21:04 ` Mario Limonciello 2023-09-22 21:04 ` Mario Limonciello 2023-09-27 13:32 ` Ilpo Järvinen 2023-09-27 13:32 ` Ilpo Järvinen 2023-09-27 13:32 ` Ilpo Järvinen 2023-09-22 17:50 ` [PATCH 15/15] platform/x86/amd/pmf: Add PMF-AMDSFH interface for ALS Shyam Sundar S K 2023-09-22 17:50 ` Shyam Sundar S K 2023-09-22 19:06 ` Mario Limonciello 2023-09-22 19:06 ` Mario Limonciello 2023-09-27 13:33 ` Ilpo Järvinen 2023-09-27 13:33 ` Ilpo Järvinen 2023-09-27 13:33 ` Ilpo Järvinen 2023-09-27 13:48 ` Shyam Sundar S K 2023-09-27 13:48 ` Shyam Sundar S K 2023-09-27 13:48 ` Shyam Sundar S K
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=02b2307f-003e-4496-93ab-53674dd7c49e@amd.com \ --to=shyam-sundar.s-k@amd.com \ --cc=Patil.Reddy@amd.com \ --cc=Xinhui.Pan@amd.com \ --cc=airlied@gmail.com \ --cc=alexander.deucher@amd.com \ --cc=amd-gfx@lists.freedesktop.org \ --cc=basavaraj.natikar@amd.com \ --cc=benjamin.tissoires@redhat.com \ --cc=christian.koenig@amd.com \ --cc=daniel@ffwll.ch \ --cc=dri-devel@lists.freedesktop.org \ --cc=hdegoede@redhat.com \ --cc=jikos@kernel.org \ --cc=linux-input@vger.kernel.org \ --cc=mario.limonciello@amd.com \ --cc=markgross@kernel.org \ --cc=platform-driver-x86@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.