From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
Cc: hdegoede@redhat.com, markgross@kernel.org,
basavaraj.natikar@amd.com, jikos@kernel.org,
benjamin.tissoires@redhat.com, alexander.deucher@amd.com,
christian.koenig@amd.com, Xinhui.Pan@amd.com, airlied@gmail.com,
daniel@ffwll.ch, Patil.Reddy@amd.com, mario.limonciello@amd.com,
platform-driver-x86@vger.kernel.org, linux-input@vger.kernel.org,
amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 03/15] platform/x86/amd/pmf: Change signature of amd_pmf_set_dram_addr
Date: Tue, 26 Sep 2023 19:52:18 +0300 (EEST) [thread overview]
Message-ID: <3b914165-ea96-b180-3fca-86b196e3638@linux.intel.com> (raw)
In-Reply-To: <20230922175056.244940-4-Shyam-sundar.S-k@amd.com>
On Fri, 22 Sep 2023, Shyam Sundar S K wrote:
Add () to the function name in the shortlog. "Change signature" is quite
vague, perhaps you could come up something more descriptive.
> Make amd_pmf_set_dram_addr() as non-static so that same function
> can be used across files.
This says nothing about the move of allocation.
> Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>
> Signed-off-by: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
> ---
> drivers/platform/x86/amd/pmf/core.c | 14 ++++++++------
> drivers/platform/x86/amd/pmf/pmf.h | 1 +
> 2 files changed, 9 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/platform/x86/amd/pmf/core.c b/drivers/platform/x86/amd/pmf/core.c
> index 68f1389dda3e..5fb03ed614ff 100644
> --- a/drivers/platform/x86/amd/pmf/core.c
> +++ b/drivers/platform/x86/amd/pmf/core.c
> @@ -251,26 +251,28 @@ static const struct pci_device_id pmf_pci_ids[] = {
> { }
> };
>
> -static void amd_pmf_set_dram_addr(struct amd_pmf_dev *dev)
> +int amd_pmf_set_dram_addr(struct amd_pmf_dev *dev)
> {
> u64 phys_addr;
> u32 hi, low;
>
> + /* Get Metrics Table Address */
> + dev->buf = kzalloc(sizeof(dev->m_table), GFP_KERNEL);
> + if (!dev->buf)
> + return -ENOMEM;
> +
> phys_addr = virt_to_phys(dev->buf);
> hi = phys_addr >> 32;
> low = phys_addr & GENMASK(31, 0);
>
> amd_pmf_send_cmd(dev, SET_DRAM_ADDR_HIGH, 0, hi, NULL);
> amd_pmf_send_cmd(dev, SET_DRAM_ADDR_LOW, 0, low, NULL);
> +
> + return 0;
> }
>
> int amd_pmf_init_metrics_table(struct amd_pmf_dev *dev)
> {
> - /* Get Metrics Table Address */
> - dev->buf = kzalloc(sizeof(dev->m_table), GFP_KERNEL);
> - if (!dev->buf)
> - return -ENOMEM;
> -
> INIT_DELAYED_WORK(&dev->work_buffer, amd_pmf_get_metrics);
>
> amd_pmf_set_dram_addr(dev);
> diff --git a/drivers/platform/x86/amd/pmf/pmf.h b/drivers/platform/x86/amd/pmf/pmf.h
> index a9333ff6c0a7..ea15ce547d24 100644
> --- a/drivers/platform/x86/amd/pmf/pmf.h
> +++ b/drivers/platform/x86/amd/pmf/pmf.h
> @@ -421,6 +421,7 @@ int amd_pmf_init_metrics_table(struct amd_pmf_dev *dev);
> int amd_pmf_get_power_source(void);
> int apmf_install_handler(struct amd_pmf_dev *pmf_dev);
> int apmf_os_power_slider_update(struct amd_pmf_dev *dev, u8 flag);
> +int amd_pmf_set_dram_addr(struct amd_pmf_dev *dev);
>
> /* SPS Layer */
> int amd_pmf_get_pprof_modes(struct amd_pmf_dev *pmf);
>
Why are not amd_pmf_set_dram_addr() callers made to handle/pass on
errors???
--
i.
WARNING: multiple messages have this Message-ID (diff)
From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
Cc: Xinhui.Pan@amd.com, Patil.Reddy@amd.com,
basavaraj.natikar@amd.com, dri-devel@lists.freedesktop.org,
jikos@kernel.org, amd-gfx@lists.freedesktop.org,
platform-driver-x86@vger.kernel.org, markgross@kernel.org,
hdegoede@redhat.com, benjamin.tissoires@redhat.com,
mario.limonciello@amd.com, linux-input@vger.kernel.org,
alexander.deucher@amd.com, christian.koenig@amd.com
Subject: Re: [PATCH 03/15] platform/x86/amd/pmf: Change signature of amd_pmf_set_dram_addr
Date: Tue, 26 Sep 2023 19:52:18 +0300 (EEST) [thread overview]
Message-ID: <3b914165-ea96-b180-3fca-86b196e3638@linux.intel.com> (raw)
In-Reply-To: <20230922175056.244940-4-Shyam-sundar.S-k@amd.com>
On Fri, 22 Sep 2023, Shyam Sundar S K wrote:
Add () to the function name in the shortlog. "Change signature" is quite
vague, perhaps you could come up something more descriptive.
> Make amd_pmf_set_dram_addr() as non-static so that same function
> can be used across files.
This says nothing about the move of allocation.
> Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>
> Signed-off-by: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
> ---
> drivers/platform/x86/amd/pmf/core.c | 14 ++++++++------
> drivers/platform/x86/amd/pmf/pmf.h | 1 +
> 2 files changed, 9 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/platform/x86/amd/pmf/core.c b/drivers/platform/x86/amd/pmf/core.c
> index 68f1389dda3e..5fb03ed614ff 100644
> --- a/drivers/platform/x86/amd/pmf/core.c
> +++ b/drivers/platform/x86/amd/pmf/core.c
> @@ -251,26 +251,28 @@ static const struct pci_device_id pmf_pci_ids[] = {
> { }
> };
>
> -static void amd_pmf_set_dram_addr(struct amd_pmf_dev *dev)
> +int amd_pmf_set_dram_addr(struct amd_pmf_dev *dev)
> {
> u64 phys_addr;
> u32 hi, low;
>
> + /* Get Metrics Table Address */
> + dev->buf = kzalloc(sizeof(dev->m_table), GFP_KERNEL);
> + if (!dev->buf)
> + return -ENOMEM;
> +
> phys_addr = virt_to_phys(dev->buf);
> hi = phys_addr >> 32;
> low = phys_addr & GENMASK(31, 0);
>
> amd_pmf_send_cmd(dev, SET_DRAM_ADDR_HIGH, 0, hi, NULL);
> amd_pmf_send_cmd(dev, SET_DRAM_ADDR_LOW, 0, low, NULL);
> +
> + return 0;
> }
>
> int amd_pmf_init_metrics_table(struct amd_pmf_dev *dev)
> {
> - /* Get Metrics Table Address */
> - dev->buf = kzalloc(sizeof(dev->m_table), GFP_KERNEL);
> - if (!dev->buf)
> - return -ENOMEM;
> -
> INIT_DELAYED_WORK(&dev->work_buffer, amd_pmf_get_metrics);
>
> amd_pmf_set_dram_addr(dev);
> diff --git a/drivers/platform/x86/amd/pmf/pmf.h b/drivers/platform/x86/amd/pmf/pmf.h
> index a9333ff6c0a7..ea15ce547d24 100644
> --- a/drivers/platform/x86/amd/pmf/pmf.h
> +++ b/drivers/platform/x86/amd/pmf/pmf.h
> @@ -421,6 +421,7 @@ int amd_pmf_init_metrics_table(struct amd_pmf_dev *dev);
> int amd_pmf_get_power_source(void);
> int apmf_install_handler(struct amd_pmf_dev *pmf_dev);
> int apmf_os_power_slider_update(struct amd_pmf_dev *dev, u8 flag);
> +int amd_pmf_set_dram_addr(struct amd_pmf_dev *dev);
>
> /* SPS Layer */
> int amd_pmf_get_pprof_modes(struct amd_pmf_dev *pmf);
>
Why are not amd_pmf_set_dram_addr() callers made to handle/pass on
errors???
--
i.
WARNING: multiple messages have this Message-ID (diff)
From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
Cc: Xinhui.Pan@amd.com, Patil.Reddy@amd.com,
basavaraj.natikar@amd.com, dri-devel@lists.freedesktop.org,
jikos@kernel.org, amd-gfx@lists.freedesktop.org,
platform-driver-x86@vger.kernel.org, markgross@kernel.org,
hdegoede@redhat.com, benjamin.tissoires@redhat.com,
mario.limonciello@amd.com, daniel@ffwll.ch,
linux-input@vger.kernel.org, alexander.deucher@amd.com,
airlied@gmail.com, christian.koenig@amd.com
Subject: Re: [PATCH 03/15] platform/x86/amd/pmf: Change signature of amd_pmf_set_dram_addr
Date: Tue, 26 Sep 2023 19:52:18 +0300 (EEST) [thread overview]
Message-ID: <3b914165-ea96-b180-3fca-86b196e3638@linux.intel.com> (raw)
In-Reply-To: <20230922175056.244940-4-Shyam-sundar.S-k@amd.com>
On Fri, 22 Sep 2023, Shyam Sundar S K wrote:
Add () to the function name in the shortlog. "Change signature" is quite
vague, perhaps you could come up something more descriptive.
> Make amd_pmf_set_dram_addr() as non-static so that same function
> can be used across files.
This says nothing about the move of allocation.
> Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>
> Signed-off-by: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
> ---
> drivers/platform/x86/amd/pmf/core.c | 14 ++++++++------
> drivers/platform/x86/amd/pmf/pmf.h | 1 +
> 2 files changed, 9 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/platform/x86/amd/pmf/core.c b/drivers/platform/x86/amd/pmf/core.c
> index 68f1389dda3e..5fb03ed614ff 100644
> --- a/drivers/platform/x86/amd/pmf/core.c
> +++ b/drivers/platform/x86/amd/pmf/core.c
> @@ -251,26 +251,28 @@ static const struct pci_device_id pmf_pci_ids[] = {
> { }
> };
>
> -static void amd_pmf_set_dram_addr(struct amd_pmf_dev *dev)
> +int amd_pmf_set_dram_addr(struct amd_pmf_dev *dev)
> {
> u64 phys_addr;
> u32 hi, low;
>
> + /* Get Metrics Table Address */
> + dev->buf = kzalloc(sizeof(dev->m_table), GFP_KERNEL);
> + if (!dev->buf)
> + return -ENOMEM;
> +
> phys_addr = virt_to_phys(dev->buf);
> hi = phys_addr >> 32;
> low = phys_addr & GENMASK(31, 0);
>
> amd_pmf_send_cmd(dev, SET_DRAM_ADDR_HIGH, 0, hi, NULL);
> amd_pmf_send_cmd(dev, SET_DRAM_ADDR_LOW, 0, low, NULL);
> +
> + return 0;
> }
>
> int amd_pmf_init_metrics_table(struct amd_pmf_dev *dev)
> {
> - /* Get Metrics Table Address */
> - dev->buf = kzalloc(sizeof(dev->m_table), GFP_KERNEL);
> - if (!dev->buf)
> - return -ENOMEM;
> -
> INIT_DELAYED_WORK(&dev->work_buffer, amd_pmf_get_metrics);
>
> amd_pmf_set_dram_addr(dev);
> diff --git a/drivers/platform/x86/amd/pmf/pmf.h b/drivers/platform/x86/amd/pmf/pmf.h
> index a9333ff6c0a7..ea15ce547d24 100644
> --- a/drivers/platform/x86/amd/pmf/pmf.h
> +++ b/drivers/platform/x86/amd/pmf/pmf.h
> @@ -421,6 +421,7 @@ int amd_pmf_init_metrics_table(struct amd_pmf_dev *dev);
> int amd_pmf_get_power_source(void);
> int apmf_install_handler(struct amd_pmf_dev *pmf_dev);
> int apmf_os_power_slider_update(struct amd_pmf_dev *dev, u8 flag);
> +int amd_pmf_set_dram_addr(struct amd_pmf_dev *dev);
>
> /* SPS Layer */
> int amd_pmf_get_pprof_modes(struct amd_pmf_dev *pmf);
>
Why are not amd_pmf_set_dram_addr() callers made to handle/pass on
errors???
--
i.
next prev parent reply other threads:[~2023-09-26 16:52 UTC|newest]
Thread overview: 127+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-22 17:50 [PATCH 00/15] Introduce PMF Smart PC Solution Builder Feature Shyam Sundar S K
2023-09-22 17:50 ` Shyam Sundar S K
2023-09-22 17:50 ` [PATCH 01/15] platform/x86/amd/pmf: Add PMF TEE interface Shyam Sundar S K
2023-09-22 17:50 ` Shyam Sundar S K
2023-09-26 16:42 ` Ilpo Järvinen
2023-09-26 16:42 ` Ilpo Järvinen
2023-09-26 16:42 ` Ilpo Järvinen
2023-09-22 17:50 ` [PATCH 02/15] platform/x86/amd/pmf: Add support PMF-TA interaction Shyam Sundar S K
2023-09-22 17:50 ` Shyam Sundar S K
2023-09-26 16:48 ` Ilpo Järvinen
2023-09-26 16:48 ` Ilpo Järvinen
2023-09-26 16:48 ` Ilpo Järvinen
2023-09-22 17:50 ` [PATCH 03/15] platform/x86/amd/pmf: Change signature of amd_pmf_set_dram_addr Shyam Sundar S K
2023-09-22 17:50 ` Shyam Sundar S K
2023-09-26 16:52 ` Ilpo Järvinen [this message]
2023-09-26 16:52 ` Ilpo Järvinen
2023-09-26 16:52 ` Ilpo Järvinen
2023-09-22 17:50 ` [PATCH 04/15] platform/x86/amd/pmf: Add support for PMF Policy Binary Shyam Sundar S K
2023-09-22 17:50 ` Shyam Sundar S K
2023-09-22 18:51 ` Mario Limonciello
2023-09-22 18:51 ` Mario Limonciello
2023-09-30 3:55 ` Shyam Sundar S K
2023-09-30 3:55 ` Shyam Sundar S K
2023-09-26 17:05 ` Ilpo Järvinen
2023-09-26 17:05 ` Ilpo Järvinen
2023-09-26 17:05 ` Ilpo Järvinen
2023-09-27 12:19 ` Ilpo Järvinen
2023-09-27 12:19 ` Ilpo Järvinen
2023-09-27 12:19 ` Ilpo Järvinen
2023-09-22 17:50 ` [PATCH 05/15] platform/x86/amd/pmf: change debugfs init sequence Shyam Sundar S K
2023-09-22 17:50 ` Shyam Sundar S K
2023-09-26 16:53 ` Ilpo Järvinen
2023-09-26 16:53 ` Ilpo Järvinen
2023-09-26 16:53 ` Ilpo Järvinen
2023-09-22 17:50 ` [PATCH 06/15] platform/x86/amd/pmf: Add support to get inputs from other subsystems Shyam Sundar S K
2023-09-22 17:50 ` Shyam Sundar S K
2023-09-26 17:08 ` Ilpo Järvinen
2023-09-26 17:08 ` Ilpo Järvinen
2023-09-26 17:08 ` Ilpo Järvinen
2023-09-30 8:40 ` Shyam Sundar S K
2023-09-30 8:40 ` Shyam Sundar S K
2023-09-30 8:40 ` Shyam Sundar S K
2023-10-02 9:10 ` Ilpo Järvinen
2023-10-02 9:10 ` Ilpo Järvinen
2023-10-02 9:10 ` Ilpo Järvinen
2023-09-22 17:50 ` [PATCH 07/15] platform/x86/amd/pmf: Add support update p3t limit Shyam Sundar S K
2023-09-22 17:50 ` Shyam Sundar S K
2023-09-27 12:19 ` Ilpo Järvinen
2023-09-27 12:19 ` Ilpo Järvinen
2023-09-27 12:19 ` Ilpo Järvinen
2023-09-22 17:50 ` [PATCH 08/15] platform/x86/amd/pmf: Add support to update system state Shyam Sundar S K
2023-09-22 17:50 ` Shyam Sundar S K
2023-09-25 21:42 ` kernel test robot
2023-09-25 21:42 ` kernel test robot
2023-09-27 12:22 ` Ilpo Järvinen
2023-09-27 12:22 ` Ilpo Järvinen
2023-09-27 12:22 ` Ilpo Järvinen
2023-09-22 17:50 ` [PATCH 09/15] platform/x86/amd/pmf: Add facility to dump TA inputs Shyam Sundar S K
2023-09-22 17:50 ` Shyam Sundar S K
2023-09-27 12:25 ` Ilpo Järvinen
2023-09-27 12:25 ` Ilpo Järvinen
2023-09-27 12:25 ` Ilpo Järvinen
2023-09-22 17:50 ` [PATCH 10/15] platform/x86/amd/pmf: Add capability to sideload of policy binary Shyam Sundar S K
2023-09-22 17:50 ` Shyam Sundar S K
2023-09-25 2:14 ` kernel test robot
2023-09-25 2:14 ` kernel test robot
2023-09-27 12:33 ` Ilpo Järvinen
2023-09-27 12:33 ` Ilpo Järvinen
2023-09-27 12:33 ` Ilpo Järvinen
2023-09-22 17:50 ` [PATCH 11/15] platform/x86/amd/pmf: dump policy binary data Shyam Sundar S K
2023-09-22 17:50 ` Shyam Sundar S K
2023-09-22 19:01 ` Mario Limonciello
2023-09-22 19:01 ` Mario Limonciello
2023-09-30 4:41 ` Shyam Sundar S K
2023-09-30 4:41 ` Shyam Sundar S K
2023-09-22 17:50 ` [PATCH 12/15] platform/x86/amd/pmf: Add PMF-AMDGPU get interface Shyam Sundar S K
2023-09-22 17:50 ` Shyam Sundar S K
2023-09-27 12:54 ` Ilpo Järvinen
2023-09-27 12:54 ` Ilpo Järvinen
2023-09-27 12:54 ` Ilpo Järvinen
2023-09-22 17:50 ` [PATCH 13/15] platform/x86/amd/pmf: Add PMF-AMDGPU set interface Shyam Sundar S K
2023-09-22 17:50 ` Shyam Sundar S K
2023-09-25 16:27 ` Deucher, Alexander
2023-09-25 16:27 ` Deucher, Alexander
2023-09-25 16:27 ` Deucher, Alexander
2023-09-25 16:30 ` Mario Limonciello
2023-09-25 16:30 ` Mario Limonciello
2023-09-26 11:17 ` Shyam Sundar S K
2023-09-26 11:17 ` Shyam Sundar S K
2023-09-26 11:15 ` Shyam Sundar S K
2023-09-26 11:15 ` Shyam Sundar S K
2023-09-26 10:35 ` Hans de Goede
2023-09-26 10:35 ` Hans de Goede
2023-09-26 11:24 ` Shyam Sundar S K
2023-09-26 11:24 ` Shyam Sundar S K
2023-09-26 12:56 ` Hans de Goede
2023-09-26 12:56 ` Hans de Goede
2023-09-26 13:17 ` Christian König
2023-09-26 13:17 ` Christian König
2023-09-26 13:48 ` Shyam Sundar S K
2023-09-26 13:48 ` Shyam Sundar S K
2023-09-27 13:04 ` Hans de Goede
2023-09-27 13:04 ` Hans de Goede
2023-09-27 13:47 ` Shyam Sundar S K
2023-09-27 13:47 ` Shyam Sundar S K
2023-09-27 13:36 ` Ilpo Järvinen
2023-09-27 13:36 ` Ilpo Järvinen
2023-09-27 13:36 ` Ilpo Järvinen
2023-09-22 17:50 ` [PATCH 14/15] platform/x86/amd/pmf: Add PMF-AMDSFH interface for HPD Shyam Sundar S K
2023-09-22 17:50 ` Shyam Sundar S K
2023-09-22 19:04 ` Mario Limonciello
2023-09-22 19:04 ` Mario Limonciello
2023-09-22 21:04 ` Mario Limonciello
2023-09-22 21:04 ` Mario Limonciello
2023-09-27 13:32 ` Ilpo Järvinen
2023-09-27 13:32 ` Ilpo Järvinen
2023-09-27 13:32 ` Ilpo Järvinen
2023-09-22 17:50 ` [PATCH 15/15] platform/x86/amd/pmf: Add PMF-AMDSFH interface for ALS Shyam Sundar S K
2023-09-22 17:50 ` Shyam Sundar S K
2023-09-22 19:06 ` Mario Limonciello
2023-09-22 19:06 ` Mario Limonciello
2023-09-27 13:33 ` Ilpo Järvinen
2023-09-27 13:33 ` Ilpo Järvinen
2023-09-27 13:33 ` Ilpo Järvinen
2023-09-27 13:48 ` Shyam Sundar S K
2023-09-27 13:48 ` Shyam Sundar S K
2023-09-27 13:48 ` Shyam Sundar S K
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3b914165-ea96-b180-3fca-86b196e3638@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=Patil.Reddy@amd.com \
--cc=Shyam-sundar.S-k@amd.com \
--cc=Xinhui.Pan@amd.com \
--cc=airlied@gmail.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=basavaraj.natikar@amd.com \
--cc=benjamin.tissoires@redhat.com \
--cc=christian.koenig@amd.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=hdegoede@redhat.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=markgross@kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.