All of lore.kernel.org
 help / color / mirror / Atom feed
From: zhuyinbo <zhuyinbo@loongson.cn>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	Mark Brown <broonie@kernel.org>, Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	linux-spi@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Cc: Jianmin Lv <lvjianmin@loongson.cn>,
	wanghongliang@loongson.cn, Liu Peibao <liupeibao@loongson.cn>,
	loongson-kernel@lists.loongnix.cn, zhuyinbo@loongson.cn
Subject: Re: [PATCH v2 1/2] dt-bindings: spi: add loongson spi
Date: Sat, 18 Mar 2023 09:18:41 +0800	[thread overview]
Message-ID: <03b1b669-efc6-7e26-8828-bf51ddc9b966@loongson.cn> (raw)
In-Reply-To: <7469290a-0671-7d2f-b0ce-cdde2a9e66cc@linaro.org>


在 2023/3/17 下午11:51, Krzysztof Kozlowski 写道:
> On 17/03/2023 11:00, zhuyinbo wrote:
>>>> +properties:
>>>> +  compatible:
>>>> +    enum:
>>>> +      - loongson,ls2k-spi
>>>> +      - loongson,ls7a-spi
>>>> +
>>>> +  reg:
>>>> +    maxItems: 1
>>>> +
>>>> +  clocks:
>>>> +    minItems: 1
>>> I don't understand why did you change it. I did not ask for it.
>>>
>>> Best regards,
>>> Krzysztof
>> Add clocks "minItems: 1" description is for fix yaml file compile issue.
> minItems: 1 is not correct, so you cannot use incorrect code to suppress
> some warning. This should be list the clocks or use maxItems: 1, if you
> have only one clock.

okay, I got it.

thanks.

>
> Best regards,
> Krzysztof


  parent reply	other threads:[~2023-03-18  1:18 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-17  8:29 [PATCH v2 0/2] spi: loongson: add bus driver for the loongson spi Yinbo Zhu
2023-03-17  8:29 ` [PATCH v2 1/2] dt-bindings: spi: add " Yinbo Zhu
2023-03-17  9:15   ` Krzysztof Kozlowski
2023-03-17 10:00     ` zhuyinbo
2023-03-17 15:51       ` Krzysztof Kozlowski
2023-03-17 15:51         ` Krzysztof Kozlowski
2023-03-17 16:14           ` Mark Brown
2023-03-18  1:38             ` zhuyinbo
2023-03-18  1:18         ` zhuyinbo [this message]
2023-03-17 14:55   ` Rob Herring
2023-03-18  1:16     ` zhuyinbo
2023-03-17  8:29 ` [PATCH v2 2/2] spi: loongson: add bus driver for the loongson spi controller Yinbo Zhu
2023-03-17 16:26   ` Mark Brown
2023-03-18  6:07     ` zhuyinbo
2023-03-20 12:52       ` Mark Brown
2023-03-21  2:54         ` zhuyinbo
2023-03-21 12:08           ` Mark Brown
2023-03-23 12:46             ` zhuyinbo
2023-03-23 13:59               ` Mark Brown
2023-03-24  3:32                 ` zhuyinbo
2023-03-17 18:07   ` kernel test robot
2023-03-18  2:51     ` zhuyinbo
2023-03-18  3:21   ` kernel test robot
2023-03-18  7:10     ` zhuyinbo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=03b1b669-efc6-7e26-8828-bf51ddc9b966@loongson.cn \
    --to=zhuyinbo@loongson.cn \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=liupeibao@loongson.cn \
    --cc=loongson-kernel@lists.loongnix.cn \
    --cc=lvjianmin@loongson.cn \
    --cc=robh+dt@kernel.org \
    --cc=wanghongliang@loongson.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.