From: Mark Brown <broonie@kernel.org>
To: zhuyinbo <zhuyinbo@loongson.cn>
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-spi@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, Jianmin Lv <lvjianmin@loongson.cn>,
wanghongliang@loongson.cn, Liu Peibao <liupeibao@loongson.cn>,
loongson-kernel@lists.loongnix.cn
Subject: Re: [PATCH v2 2/2] spi: loongson: add bus driver for the loongson spi controller
Date: Mon, 20 Mar 2023 12:52:00 +0000 [thread overview]
Message-ID: <9917d619-1104-4040-bb6f-c564fcf72806@sirena.org.uk> (raw)
In-Reply-To: <9b7aff76-eff4-3b82-d7af-a723fbf21a32@loongson.cn>
[-- Attachment #1: Type: text/plain, Size: 646 bytes --]
On Sat, Mar 18, 2023 at 02:07:16PM +0800, zhuyinbo wrote:
> 在 2023/3/18 上午12:26, Mark Brown 写道:
> > On Fri, Mar 17, 2023 at 04:29:50PM +0800, Yinbo Zhu wrote:
> > As IIRC I mentioned last time setup() might be called while other
> > transfers are happening and therefore shouldn't affect parallel
> > operations on other devices.
> I think add spin_lock in transfer_one interface that should be to fix this
> issue, Do you think so?
No, that doesn't help if setup() reconfigures the controller while it's
doing a transfer. The issue is that the controller might be put into
the wrong mode or run at the wrong speed.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2023-03-20 12:54 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-17 8:29 [PATCH v2 0/2] spi: loongson: add bus driver for the loongson spi Yinbo Zhu
2023-03-17 8:29 ` [PATCH v2 1/2] dt-bindings: spi: add " Yinbo Zhu
2023-03-17 9:15 ` Krzysztof Kozlowski
2023-03-17 10:00 ` zhuyinbo
2023-03-17 15:51 ` Krzysztof Kozlowski
2023-03-17 15:51 ` Krzysztof Kozlowski
2023-03-17 16:14 ` Mark Brown
2023-03-18 1:38 ` zhuyinbo
2023-03-18 1:18 ` zhuyinbo
2023-03-17 14:55 ` Rob Herring
2023-03-18 1:16 ` zhuyinbo
2023-03-17 8:29 ` [PATCH v2 2/2] spi: loongson: add bus driver for the loongson spi controller Yinbo Zhu
2023-03-17 16:26 ` Mark Brown
2023-03-18 6:07 ` zhuyinbo
2023-03-20 12:52 ` Mark Brown [this message]
2023-03-21 2:54 ` zhuyinbo
2023-03-21 12:08 ` Mark Brown
2023-03-23 12:46 ` zhuyinbo
2023-03-23 13:59 ` Mark Brown
2023-03-24 3:32 ` zhuyinbo
2023-03-17 18:07 ` kernel test robot
2023-03-18 2:51 ` zhuyinbo
2023-03-18 3:21 ` kernel test robot
2023-03-18 7:10 ` zhuyinbo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9917d619-1104-4040-bb6f-c564fcf72806@sirena.org.uk \
--to=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=liupeibao@loongson.cn \
--cc=loongson-kernel@lists.loongnix.cn \
--cc=lvjianmin@loongson.cn \
--cc=robh+dt@kernel.org \
--cc=wanghongliang@loongson.cn \
--cc=zhuyinbo@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.