From: Mark Brown <broonie@kernel.org>
To: zhuyinbo <zhuyinbo@loongson.cn>
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-spi@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, Jianmin Lv <lvjianmin@loongson.cn>,
wanghongliang@loongson.cn, Liu Peibao <liupeibao@loongson.cn>,
loongson-kernel@lists.loongnix.cn
Subject: Re: [PATCH v2 2/2] spi: loongson: add bus driver for the loongson spi controller
Date: Thu, 23 Mar 2023 13:59:21 +0000 [thread overview]
Message-ID: <75a40be0-8eaa-4c9b-87dc-382c2a2af439@sirena.org.uk> (raw)
In-Reply-To: <2337f45f-c513-1b10-ccfc-766363c5fd02@loongson.cn>
[-- Attachment #1: Type: text/plain, Size: 657 bytes --]
On Thu, Mar 23, 2023 at 08:46:19PM +0800, zhuyinbo wrote:
> I think add following change and that issue what you said will can be
> fixed, in addition, the spin_lock
> was also not needed. Do you think so?
> @@ -101,8 +101,10 @@ static int loongson_spi_setup(struct spi_device *spi)
> if (spi->chip_select >= spi->master->num_chipselect)
> return -EINVAL;
>
> + loongson_spi->hz = 0;
> + loongson_spi->mode &= SPI_NO_CS;
> +
> spin_lock(&loongson_spi->lock);
> - loongson_spi_update_state(loongson_spi, spi, NULL);
Looks plausible, yes - I'd need to see the full thing to verify.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2023-03-23 14:00 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-17 8:29 [PATCH v2 0/2] spi: loongson: add bus driver for the loongson spi Yinbo Zhu
2023-03-17 8:29 ` [PATCH v2 1/2] dt-bindings: spi: add " Yinbo Zhu
2023-03-17 9:15 ` Krzysztof Kozlowski
2023-03-17 10:00 ` zhuyinbo
2023-03-17 15:51 ` Krzysztof Kozlowski
2023-03-17 15:51 ` Krzysztof Kozlowski
2023-03-17 16:14 ` Mark Brown
2023-03-18 1:38 ` zhuyinbo
2023-03-18 1:18 ` zhuyinbo
2023-03-17 14:55 ` Rob Herring
2023-03-18 1:16 ` zhuyinbo
2023-03-17 8:29 ` [PATCH v2 2/2] spi: loongson: add bus driver for the loongson spi controller Yinbo Zhu
2023-03-17 16:26 ` Mark Brown
2023-03-18 6:07 ` zhuyinbo
2023-03-20 12:52 ` Mark Brown
2023-03-21 2:54 ` zhuyinbo
2023-03-21 12:08 ` Mark Brown
2023-03-23 12:46 ` zhuyinbo
2023-03-23 13:59 ` Mark Brown [this message]
2023-03-24 3:32 ` zhuyinbo
2023-03-17 18:07 ` kernel test robot
2023-03-18 2:51 ` zhuyinbo
2023-03-18 3:21 ` kernel test robot
2023-03-18 7:10 ` zhuyinbo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=75a40be0-8eaa-4c9b-87dc-382c2a2af439@sirena.org.uk \
--to=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=liupeibao@loongson.cn \
--cc=loongson-kernel@lists.loongnix.cn \
--cc=lvjianmin@loongson.cn \
--cc=robh+dt@kernel.org \
--cc=wanghongliang@loongson.cn \
--cc=zhuyinbo@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.