From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "Sahin, Okan" <Okan.Sahin@analog.com>
Cc: Lee Jones <lee@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Caleb Connolly <caleb.connolly@linaro.org>,
Marcus Folkesson <marcus.folkesson@gmail.com>,
"Bolboaca, Ramona" <Ramona.Bolboaca@analog.com>,
William Breathitt Gray <william.gray@linaro.org>,
ChiYuan Huang <cy_huang@richtek.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>
Subject: Re: [PATCH v3 2/5] dt-bindings: mfd: Add ADI MAX77541/MAX77540
Date: Tue, 31 Jan 2023 17:44:18 +0100 [thread overview]
Message-ID: <04ac07ef-ee4b-abb8-9fb2-114e3a646a2f@linaro.org> (raw)
In-Reply-To: <MN2PR03MB51685B56D49CBB590BBE6B7EE7D09@MN2PR03MB5168.namprd03.prod.outlook.com>
On 31/01/2023 13:02, Sahin, Okan wrote:
>>> + regulators:
>>> + $ref: /schemas/regulator/adi,max77541-regulator.yaml#
>>
>> No improvements regarding bisectability - this patch fails. If you tested this patch,
>> you would see it.
>>
>> Instead of ignoring comments, either implement them or ask for clarification.
>>
>>
> Sorry for misunderstanding, I checked patchset as a whole not one by one this is why I did not get failure after "make dt_binding_check " . Right now, I understand why you are saying this patch fails, but what is your suggestion? what is the correct order for this patchset? I sent adi,max77541-regulator.yaml in path 4/5. In the light of discussion, should I remove all the parts related to regulator in patch 2/5, then add adi,max77541-regulator.yaml and update adi,max77541.yaml in patch 4/5? or should I add new patch to update adi,max77541.yaml?
Regulator binding patch should be first in the series (bindings are
before usage), then the MFD binding should come. Your cover letter
should clearly at the top mention the dependency. You can also mention
dependency in MFD patch after ---, because many of us do not really read
cover letters...
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-01-31 16:44 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-18 6:38 [PATCH v3 0/5] Add MAX77541/MAX77540 PMIC Support Okan Sahin
2023-01-18 6:38 ` [PATCH v3 1/5] drivers: mfd: Add ADI " Okan Sahin
2023-01-18 8:16 ` Andy Shevchenko
2023-01-19 14:27 ` Lee Jones
2023-01-19 15:06 ` Andy Shevchenko
2023-01-19 15:06 ` William Breathitt Gray
2023-01-18 6:38 ` [PATCH v3 2/5] dt-bindings: mfd: Add ADI MAX77541/MAX77540 Okan Sahin
2023-01-18 8:22 ` Krzysztof Kozlowski
2023-01-31 12:02 ` Sahin, Okan
2023-01-31 16:44 ` Krzysztof Kozlowski [this message]
2023-01-31 21:28 ` Sahin, Okan
2023-02-01 7:25 ` Krzysztof Kozlowski
2023-02-01 7:46 ` Sahin, Okan
2023-02-01 8:08 ` Krzysztof Kozlowski
2023-01-18 13:10 ` Rob Herring
2023-01-18 6:38 ` [PATCH v3 3/5] drivers: regulator: Add ADI MAX77541/MAX77540 Regulator Support Okan Sahin
2023-01-18 8:19 ` Andy Shevchenko
2023-01-31 7:20 ` Sahin, Okan
2023-01-31 9:27 ` Sahin, Okan
2023-01-31 12:26 ` Andy Shevchenko
2023-01-31 13:23 ` Sahin, Okan
2023-01-31 13:29 ` Andy Shevchenko
2023-01-31 13:59 ` Sahin, Okan
2023-01-31 14:13 ` Andy Shevchenko
2023-01-31 14:38 ` Sahin, Okan
2023-01-31 13:32 ` Mark Brown
2023-01-31 12:24 ` Andy Shevchenko
2023-01-31 13:12 ` Sahin, Okan
2023-01-31 13:26 ` Andy Shevchenko
2023-01-18 6:38 ` [PATCH v3 4/5] dt-bindings: regulator: Add ADI MAX77541/MAX77540 Regulator Okan Sahin
2023-01-18 8:33 ` Krzysztof Kozlowski
2023-01-18 6:38 ` [PATCH v3 5/5] drivers: iio: adc: Add ADI MAX77541 ADC Support Okan Sahin
2023-01-18 8:23 ` Andy Shevchenko
2023-01-21 17:55 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=04ac07ef-ee4b-abb8-9fb2-114e3a646a2f@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=Okan.Sahin@analog.com \
--cc=Ramona.Bolboaca@analog.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=broonie@kernel.org \
--cc=caleb.connolly@linaro.org \
--cc=cy_huang@richtek.com \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=lee@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcus.folkesson@gmail.com \
--cc=robh+dt@kernel.org \
--cc=william.gray@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.