From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Okan Sahin <okan.sahin@analog.com>
Cc: Lee Jones <lee@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Geert Uytterhoeven <geert+renesas@glider.be>,
ChiYuan Huang <cy_huang@richtek.com>,
Marcelo Schmitt <marcelo.schmitt1@gmail.com>,
Marcus Folkesson <marcus.folkesson@gmail.com>,
William Breathitt Gray <william.gray@linaro.org>,
Ramona Bolboaca <ramona.bolboaca@analog.com>,
Caleb Connolly <caleb.connolly@linaro.org>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-iio@vger.kernel.org
Subject: Re: [PATCH v3 5/5] drivers: iio: adc: Add ADI MAX77541 ADC Support
Date: Wed, 18 Jan 2023 10:23:47 +0200 [thread overview]
Message-ID: <Y8esk8ekNF6S/RVu@smile.fi.intel.com> (raw)
In-Reply-To: <20230118063822.14521-6-okan.sahin@analog.com>
On Wed, Jan 18, 2023 at 09:38:12AM +0300, Okan Sahin wrote:
> The MAX77541 has an 8-bit Successive Approximation Register (SAR) ADC
> with four multiplexers for supporting the telemetry feature.
...
> + * Copyright (c) 2022 Analog Devices, Inc.
HNY!
...
> +#include <linux/bitfield.h>
> +#include <linux/iio/iio.h>
> +#include <linux/mod_devicetable.h>
> +#include <linux/platform_device.h>
> +#include <linux/regmap.h>
> +#include <linux/regulator/driver.h>
> +#include <linux/regulator/of_regulator.h>
What for these two?
Make sure the list of inclusions is not semi-random.
> +#include <linux/units.h>
+ Blank line.
> +#include <linux/mfd/max77541.h>
...
> + *val = DIV_ROUND_CLOSEST(ABSOLUTE_ZERO_MILLICELSIUS,
> + 1725);
This is perfectly one line, please, reduce number of LoCs by unwrapping
such cases.
...
> + if (ret)
> + return ret;
+ Blank line.
> + reg_val = FIELD_GET(MAX77541_BITS_MX_CFG1_RNG, reg_val);
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-01-18 9:06 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-18 6:38 [PATCH v3 0/5] Add MAX77541/MAX77540 PMIC Support Okan Sahin
2023-01-18 6:38 ` [PATCH v3 1/5] drivers: mfd: Add ADI " Okan Sahin
2023-01-18 8:16 ` Andy Shevchenko
2023-01-19 14:27 ` Lee Jones
2023-01-19 15:06 ` Andy Shevchenko
2023-01-19 15:06 ` William Breathitt Gray
2023-01-18 6:38 ` [PATCH v3 2/5] dt-bindings: mfd: Add ADI MAX77541/MAX77540 Okan Sahin
2023-01-18 8:22 ` Krzysztof Kozlowski
2023-01-31 12:02 ` Sahin, Okan
2023-01-31 16:44 ` Krzysztof Kozlowski
2023-01-31 21:28 ` Sahin, Okan
2023-02-01 7:25 ` Krzysztof Kozlowski
2023-02-01 7:46 ` Sahin, Okan
2023-02-01 8:08 ` Krzysztof Kozlowski
2023-01-18 13:10 ` Rob Herring
2023-01-18 6:38 ` [PATCH v3 3/5] drivers: regulator: Add ADI MAX77541/MAX77540 Regulator Support Okan Sahin
2023-01-18 8:19 ` Andy Shevchenko
2023-01-31 7:20 ` Sahin, Okan
2023-01-31 9:27 ` Sahin, Okan
2023-01-31 12:26 ` Andy Shevchenko
2023-01-31 13:23 ` Sahin, Okan
2023-01-31 13:29 ` Andy Shevchenko
2023-01-31 13:59 ` Sahin, Okan
2023-01-31 14:13 ` Andy Shevchenko
2023-01-31 14:38 ` Sahin, Okan
2023-01-31 13:32 ` Mark Brown
2023-01-31 12:24 ` Andy Shevchenko
2023-01-31 13:12 ` Sahin, Okan
2023-01-31 13:26 ` Andy Shevchenko
2023-01-18 6:38 ` [PATCH v3 4/5] dt-bindings: regulator: Add ADI MAX77541/MAX77540 Regulator Okan Sahin
2023-01-18 8:33 ` Krzysztof Kozlowski
2023-01-18 6:38 ` [PATCH v3 5/5] drivers: iio: adc: Add ADI MAX77541 ADC Support Okan Sahin
2023-01-18 8:23 ` Andy Shevchenko [this message]
2023-01-21 17:55 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y8esk8ekNF6S/RVu@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=broonie@kernel.org \
--cc=caleb.connolly@linaro.org \
--cc=cy_huang@richtek.com \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=jic23@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=lee@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo.schmitt1@gmail.com \
--cc=marcus.folkesson@gmail.com \
--cc=okan.sahin@analog.com \
--cc=ramona.bolboaca@analog.com \
--cc=robh+dt@kernel.org \
--cc=william.gray@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.