Re: [PATCH v3 3/5] drivers: regulator: Add ADI MAX77541/MAX77540 Regulator Support

From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Sahin, Okan" <Okan.Sahin@analog.com>
Cc: Lee Jones <lee@kernel.org>, Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	Jonathan Cameron <jic23@kernel.org>,
	Lars-Peter Clausen <lars@metafoo.de>,
	ChiYuan Huang <cy_huang@richtek.com>,
	"Bolboaca, Ramona" <Ramona.Bolboaca@analog.com>,
	Caleb Connolly <caleb.connolly@linaro.org>,
	William Breathitt Gray <william.gray@linaro.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>
Subject: Re: [PATCH v3 3/5] drivers: regulator: Add ADI MAX77541/MAX77540 Regulator Support
Date: Tue, 31 Jan 2023 14:26:58 +0200	[thread overview]
Message-ID: <Y9kJEsjkG8h79tcR@smile.fi.intel.com> (raw)
In-Reply-To: <MN2PR03MB516865804044A798AEB5B6C0E7D09@MN2PR03MB5168.namprd03.prod.outlook.com>

On Tue, Jan 31, 2023 at 09:27:48AM +0000, Sahin, Okan wrote:

First of all, please do avoid top-posting.

> Sorry for second question. I do not want to bother you, but I realized that I
> need to be sure about driver_data before sending new patch. You said that you
> need to use pointers directly for driver_data then I fixed that part in mfd,
> but I do not need or  use driver_data in regulator since chip_id comes from
> mfd device so I think using like below should be enough for my
> implementation.
> 
> static const struct platform_device_id max77541_regulator_platform_id[] = {
> 	{ "max77540-regulator", },
> 	{ "max77541-regulator", },
> 	{  /* sentinel */  }
> };
> MODULE_DEVICE_TABLE(platform, max77541_regulator_platform_id);
> 
> static const struct of_device_id max77541_regulator_of_id[] = {
> 	{ .compatible = "adi,max77540-regulator", },
> 	{ .compatible = "adi,max77541-regulator", },
> 	{ /* sentinel */  }
> };
> MODULE_DEVICE_TABLE(of, max77541_regulator_of_id);
> 
> What do you think?

If you have got all necessary data from the upper layer, why do you need to
have an ID table here? I'm not sure I understand how this OF ID table works
in this case.

-- 
With Best Regards,
Andy Shevchenko