From: Christopher Spinrath <christopher.spinrath-vA1bhqPz9FBZXbeN9DUtxg@public.gmane.org> To: Archit Taneja <architt-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>, Jyri Sarha <jsarha-l0cyMroinI0@public.gmane.org> Cc: Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>, "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, David Airlie <airlied-cv59FeDIM0c@public.gmane.org>, Fabio Estevam <festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>, Russell King - ARM Linux <linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org>, DRI mailing list <dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>, "robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org" <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>, Igor Grinberg <grinberg-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org>, Sascha Hauer <kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>, Fabio Estevam <fabio.estevam-3arQi8VN3Tc@public.gmane.org>, Shawn Guo <shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>, "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" <linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org> Subject: Re: [PATCH 1/2] drm/bridge: ti-tfp410: support hpd via gpio Date: Thu, 30 Mar 2017 23:51:03 +0200 [thread overview] Message-ID: <09a6bf1b-f743-4f1f-9bd3-d2c137365b16@rwth-aachen.de> (raw) In-Reply-To: <e63e628794b044c2a615091697622d50-cBaz+nnMw18umhiu9RXYRl5UTUQ924AY@public.gmane.org> Hi, On 03/30/2017 11:49 AM, Archit Taneja wrote: > > > On 03/28/2017 07:02 PM, Jyri Sarha wrote: >> On 03/27/17 08:58, Archit Taneja wrote: >>> Hi, >>> >>> On 03/07/2017 03:21 AM, Christopher Spinrath wrote: >>>> Hi Fabio, >>>> >>>> On 03/06/2017 10:46 PM, Fabio Estevam wrote: >>>>> Hi Christopher, >>>>> >>>>> On Mon, Mar 6, 2017 at 6:40 PM, >>>>> <christopher.spinrath-vA1bhqPz9FBZXbeN9DUtxg@public.gmane.org> wrote: >>>>>> From: Christopher Spinrath <christopher.spinrath-vA1bhqPz9FBZXbeN9DUtxg@public.gmane.org> >>>>>> >>>>>> On some boards the hpd pin of a hdmi connector is wired up to a gpio >>>>>> pin. Since in the DRM world the tfp410 driver is responsible for >>>>>> handling the connector, add support for hpd gpios in this very >>>>>> driver. >>>>>> >>>>>> Signed-off-by: Christopher Spinrath >>>>>> <christopher.spinrath-vA1bhqPz9FBZXbeN9DUtxg@public.gmane.org> >>>>>> --- >>>>>> drivers/gpu/drm/bridge/ti-tfp410.c | 72 >>>>>> ++++++++++++++++++++++++++++++++++++-- >>>>> >> ... >>>> >>> >>> The patch looks good to me. >>> >>> Jyri, >>> >>> Is it possible for you to verify this on Beaglebone platform? >>> >> >> If I read my BeagleBone DVI-D Cape docs right, it does not have the HPD >> pin connected. At least it does not mention any gpio that could be used >> for the purpose. So I can not easily test this patch in real world >> situation. For what it is worth the patch looks ok to me too. > > Thanks for the review. I looked at the tfp410 data sheet[1], there isn't > a HPD pin on the chip at all. My guess is that boards using tfp410 most > likely have the HPD pin routed to the SoC from the HDMI connector > (with a level shifter/shield in between). Exactly. I tried to say that in the commit message (and, actually, that's what I did in Patch 2/2 for the Utilite Pro). Thanks, Christopher > We would eventually need to move the both ddc and hpd stuff to > a generic hdmi connector driver later on. I've queued this to > drm-misc-next. > > [1]: http://www.ti.com/lit/ds/symlink/tfp410.pdf > > Archit > >> >> Best regards, >> Jyri >> >> >> _______________________________________________ >> linux-arm-kernel mailing list >> linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org >> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel >> > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: christopher.spinrath@rwth-aachen.de (Christopher Spinrath) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 1/2] drm/bridge: ti-tfp410: support hpd via gpio Date: Thu, 30 Mar 2017 23:51:03 +0200 [thread overview] Message-ID: <09a6bf1b-f743-4f1f-9bd3-d2c137365b16@rwth-aachen.de> (raw) In-Reply-To: <e63e628794b044c2a615091697622d50@rwthex-w1-b.rwth-ad.de> Hi, On 03/30/2017 11:49 AM, Archit Taneja wrote: > > > On 03/28/2017 07:02 PM, Jyri Sarha wrote: >> On 03/27/17 08:58, Archit Taneja wrote: >>> Hi, >>> >>> On 03/07/2017 03:21 AM, Christopher Spinrath wrote: >>>> Hi Fabio, >>>> >>>> On 03/06/2017 10:46 PM, Fabio Estevam wrote: >>>>> Hi Christopher, >>>>> >>>>> On Mon, Mar 6, 2017 at 6:40 PM, >>>>> <christopher.spinrath@rwth-aachen.de> wrote: >>>>>> From: Christopher Spinrath <christopher.spinrath@rwth-aachen.de> >>>>>> >>>>>> On some boards the hpd pin of a hdmi connector is wired up to a gpio >>>>>> pin. Since in the DRM world the tfp410 driver is responsible for >>>>>> handling the connector, add support for hpd gpios in this very >>>>>> driver. >>>>>> >>>>>> Signed-off-by: Christopher Spinrath >>>>>> <christopher.spinrath@rwth-aachen.de> >>>>>> --- >>>>>> drivers/gpu/drm/bridge/ti-tfp410.c | 72 >>>>>> ++++++++++++++++++++++++++++++++++++-- >>>>> >> ... >>>> >>> >>> The patch looks good to me. >>> >>> Jyri, >>> >>> Is it possible for you to verify this on Beaglebone platform? >>> >> >> If I read my BeagleBone DVI-D Cape docs right, it does not have the HPD >> pin connected. At least it does not mention any gpio that could be used >> for the purpose. So I can not easily test this patch in real world >> situation. For what it is worth the patch looks ok to me too. > > Thanks for the review. I looked at the tfp410 data sheet[1], there isn't > a HPD pin on the chip at all. My guess is that boards using tfp410 most > likely have the HPD pin routed to the SoC from the HDMI connector > (with a level shifter/shield in between). Exactly. I tried to say that in the commit message (and, actually, that's what I did in Patch 2/2 for the Utilite Pro). Thanks, Christopher > We would eventually need to move the both ddc and hpd stuff to > a generic hdmi connector driver later on. I've queued this to > drm-misc-next. > > [1]: http://www.ti.com/lit/ds/symlink/tfp410.pdf > > Archit > >> >> Best regards, >> Jyri >> >> >> _______________________________________________ >> linux-arm-kernel mailing list >> linux-arm-kernel at lists.infradead.org >> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel >> >
next prev parent reply other threads:[~2017-03-30 21:51 UTC|newest] Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-03-06 21:40 [PATCH 1/2] drm/bridge: ti-tfp410: support hpd via gpio christopher.spinrath 2017-03-06 21:40 ` christopher.spinrath at rwth-aachen.de 2017-03-06 21:46 ` Fabio Estevam 2017-03-06 21:46 ` Fabio Estevam [not found] ` <093b4e9c0ae6413499e5bf8ec309fa41@rwthex-s1-b.rwth-ad.de> [not found] ` <093b4e9c0ae6413499e5bf8ec309fa41-gtPewvpZjL8umhiu9RXYRl5UTUQ924AY@public.gmane.org> 2017-03-06 21:51 ` Christopher Spinrath 2017-03-06 21:51 ` Christopher Spinrath 2017-03-27 5:58 ` Archit Taneja 2017-03-27 5:58 ` Archit Taneja 2017-03-28 13:32 ` Jyri Sarha 2017-03-28 13:32 ` Jyri Sarha 2017-03-30 9:49 ` Archit Taneja 2017-03-30 9:49 ` Archit Taneja [not found] ` <e63e628794b044c2a615091697622d50@rwthex-w1-b.rwth-ad.de> [not found] ` <e63e628794b044c2a615091697622d50-cBaz+nnMw18umhiu9RXYRl5UTUQ924AY@public.gmane.org> 2017-03-30 21:51 ` Christopher Spinrath [this message] 2017-03-30 21:51 ` Christopher Spinrath
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=09a6bf1b-f743-4f1f-9bd3-d2c137365b16@rwth-aachen.de \ --to=christopher.spinrath-va1bhqpz9fbzxben9dutxg@public.gmane.org \ --cc=airlied-cv59FeDIM0c@public.gmane.org \ --cc=architt-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \ --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \ --cc=fabio.estevam-3arQi8VN3Tc@public.gmane.org \ --cc=festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \ --cc=grinberg-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org \ --cc=jsarha-l0cyMroinI0@public.gmane.org \ --cc=kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \ --cc=linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org \ --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \ --cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \ --cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \ --cc=shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.