From: Jyri Sarha <jsarha@ti.com>
To: Archit Taneja <architt@codeaurora.org>,
Christopher Spinrath <christopher.spinrath@rwth-aachen.de>
Cc: Mark Rutland <mark.rutland@arm.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Russell King - ARM Linux <linux@armlinux.org.uk>,
DRI mailing list <dri-devel@lists.freedesktop.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
Igor Grinberg <grinberg@compulab.co.il>,
Sascha Hauer <kernel@pengutronix.de>,
Fabio Estevam <fabio.estevam@nxp.com>,
Shawn Guo <shawnguo@kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 1/2] drm/bridge: ti-tfp410: support hpd via gpio
Date: Tue, 28 Mar 2017 16:32:34 +0300 [thread overview]
Message-ID: <f87195b3-bd89-d698-c935-4e3aa97c01e2@ti.com> (raw)
In-Reply-To: <d6b2391f-3e4a-2761-b6a0-8997d2c78600@codeaurora.org>
On 03/27/17 08:58, Archit Taneja wrote:
> Hi,
>
> On 03/07/2017 03:21 AM, Christopher Spinrath wrote:
>> Hi Fabio,
>>
>> On 03/06/2017 10:46 PM, Fabio Estevam wrote:
>>> Hi Christopher,
>>>
>>> On Mon, Mar 6, 2017 at 6:40 PM,
>>> <christopher.spinrath@rwth-aachen.de> wrote:
>>>> From: Christopher Spinrath <christopher.spinrath@rwth-aachen.de>
>>>>
>>>> On some boards the hpd pin of a hdmi connector is wired up to a gpio
>>>> pin. Since in the DRM world the tfp410 driver is responsible for
>>>> handling the connector, add support for hpd gpios in this very driver.
>>>>
>>>> Signed-off-by: Christopher Spinrath
>>>> <christopher.spinrath@rwth-aachen.de>
>>>> ---
>>>> drivers/gpu/drm/bridge/ti-tfp410.c | 72
>>>> ++++++++++++++++++++++++++++++++++++--
>>>
...
>>
>
> The patch looks good to me.
>
> Jyri,
>
> Is it possible for you to verify this on Beaglebone platform?
>
If I read my BeagleBone DVI-D Cape docs right, it does not have the HPD
pin connected. At least it does not mention any gpio that could be used
for the purpose. So I can not easily test this patch in real world
situation. For what it is worth the patch looks ok to me too.
Best regards,
Jyri
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: jsarha@ti.com (Jyri Sarha)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] drm/bridge: ti-tfp410: support hpd via gpio
Date: Tue, 28 Mar 2017 16:32:34 +0300 [thread overview]
Message-ID: <f87195b3-bd89-d698-c935-4e3aa97c01e2@ti.com> (raw)
In-Reply-To: <d6b2391f-3e4a-2761-b6a0-8997d2c78600@codeaurora.org>
On 03/27/17 08:58, Archit Taneja wrote:
> Hi,
>
> On 03/07/2017 03:21 AM, Christopher Spinrath wrote:
>> Hi Fabio,
>>
>> On 03/06/2017 10:46 PM, Fabio Estevam wrote:
>>> Hi Christopher,
>>>
>>> On Mon, Mar 6, 2017 at 6:40 PM,
>>> <christopher.spinrath@rwth-aachen.de> wrote:
>>>> From: Christopher Spinrath <christopher.spinrath@rwth-aachen.de>
>>>>
>>>> On some boards the hpd pin of a hdmi connector is wired up to a gpio
>>>> pin. Since in the DRM world the tfp410 driver is responsible for
>>>> handling the connector, add support for hpd gpios in this very driver.
>>>>
>>>> Signed-off-by: Christopher Spinrath
>>>> <christopher.spinrath@rwth-aachen.de>
>>>> ---
>>>> drivers/gpu/drm/bridge/ti-tfp410.c | 72
>>>> ++++++++++++++++++++++++++++++++++++--
>>>
...
>>
>
> The patch looks good to me.
>
> Jyri,
>
> Is it possible for you to verify this on Beaglebone platform?
>
If I read my BeagleBone DVI-D Cape docs right, it does not have the HPD
pin connected. At least it does not mention any gpio that could be used
for the purpose. So I can not easily test this patch in real world
situation. For what it is worth the patch looks ok to me too.
Best regards,
Jyri
next prev parent reply other threads:[~2017-03-28 13:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-06 21:40 [PATCH 1/2] drm/bridge: ti-tfp410: support hpd via gpio christopher.spinrath
2017-03-06 21:40 ` christopher.spinrath at rwth-aachen.de
2017-03-06 21:46 ` Fabio Estevam
2017-03-06 21:46 ` Fabio Estevam
[not found] ` <093b4e9c0ae6413499e5bf8ec309fa41@rwthex-s1-b.rwth-ad.de>
[not found] ` <093b4e9c0ae6413499e5bf8ec309fa41-gtPewvpZjL8umhiu9RXYRl5UTUQ924AY@public.gmane.org>
2017-03-06 21:51 ` Christopher Spinrath
2017-03-06 21:51 ` Christopher Spinrath
2017-03-27 5:58 ` Archit Taneja
2017-03-27 5:58 ` Archit Taneja
2017-03-28 13:32 ` Jyri Sarha [this message]
2017-03-28 13:32 ` Jyri Sarha
2017-03-30 9:49 ` Archit Taneja
2017-03-30 9:49 ` Archit Taneja
[not found] ` <e63e628794b044c2a615091697622d50@rwthex-w1-b.rwth-ad.de>
[not found] ` <e63e628794b044c2a615091697622d50-cBaz+nnMw18umhiu9RXYRl5UTUQ924AY@public.gmane.org>
2017-03-30 21:51 ` Christopher Spinrath
2017-03-30 21:51 ` Christopher Spinrath
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f87195b3-bd89-d698-c935-4e3aa97c01e2@ti.com \
--to=jsarha@ti.com \
--cc=architt@codeaurora.org \
--cc=christopher.spinrath@rwth-aachen.de \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=fabio.estevam@nxp.com \
--cc=grinberg@compulab.co.il \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.