From: "Song, Barry" <Barry.Song@analog.com> To: "Mike Frysinger" <vapier.adi@gmail.com>, "Barry Song" <21cnbao@gmail.com> Cc: "Hennerich, Michael" <Michael.Hennerich@analog.com>, "Dmitry Torokhov" <dmitry.torokhov@gmail.com>, <linux-kernel@vger.kernel.org>, <linux-input@vger.kernel.org>, <uclinux-dist-devel@blackfin.uclinux.org> Subject: RE: [Uclinux-dist-devel] [PATCH] input/keyboard: add ADP5588 QWERTYI2C Keyboard Input device driver Date: Wed, 16 Sep 2009 12:18:38 +0800 [thread overview] Message-ID: <0F1B54C89D5F954D8535DB252AF412FA04BEE48B@chinexm1.ad.analog.com> (raw) In-Reply-To: <8bd0f97a0909152103m4848fe9ayb5835a6844ea4ca1@mail.gmail.com> >-----Original Message----- >From: uclinux-dist-devel-bounces@blackfin.uclinux.org >[mailto:uclinux-dist-devel-bounces@blackfin.uclinux.org] On >Behalf Of Mike Frysinger >Sent: Wednesday, September 16, 2009 12:04 PM >To: Barry Song >Cc: Hennerich, Michael; Dmitry Torokhov; >linux-kernel@vger.kernel.org; linux-input@vger.kernel.org; >uclinux-dist-devel@blackfin.uclinux.org >Subject: Re: [Uclinux-dist-devel] [PATCH] input/keyboard: add >ADP5588 QWERTYI2C Keyboard Input device driver > >On Tue, Sep 15, 2009 at 23:49, Barry Song wrote: >> On Wed, Sep 16, 2009 at 12:26 AM, Dmitry Torokhov wrote: >>> On Tue, Sep 15, 2009 at 07:19:14AM -0400, Mike Frysinger wrote: >>>> On Tue, Sep 15, 2009 at 02:20, Dmitry Torokhov wrote: >>>> > BTW, maybe you shoudl convert to threaded IRQs here? >>>> >>>> yes, after your suggestion for the previous driver, we've >been looking >>>> at all our input drivers to convert to threaded IRQs. do >we need to >>>> convert all of them before acceptance, or can we merge now >and post an >>>> updated patch after ? >>> >>> It really depends on the driver. If there is a race between >IRQ and the >>> WQ in the driver I will request you to fix it one way or >another before >>> accepting the driver (and quite often using threaded IRQ >gets rid of the >>> race). In the cases like this particular driver though I am not even >>> convinced that we need threaded IRQ. The driver is not expected to >>> generate lots of events rapidly so using keventd as it does now is >>> probably the best solution. >> >> Even though CONFIG_GENERIC_HARDIRQS is almost always "y", in case >> CONFIG_GENERIC_HARDIRQS is "n" not "y", threaded_irq will become >> original irq, drivers will not work. So is it necessary to check the >> dependence of GENERIC_HARDIRQS while using threaded_irq? > >when is GENERIC_HARDIRQS not "y" ? a quick check shows only s390/m68k >dont set it to "y" in their arch Kconfig ? s390 isnt going to use any >of these drivers, and m68k will eventually update (m68knommu already >has !?). SPARC32 is "n" too. I am not caring about only these several drivers. I just want to find whether that can be a generic problem while using threaded_irq in any driver. >-mike >_______________________________________________ >Uclinux-dist-devel mailing list >Uclinux-dist-devel@blackfin.uclinux.org >https://blackfin.uclinux.org/mailman/listinfo/uclinux-dist-devel >
WARNING: multiple messages have this Message-ID (diff)
From: "Song, Barry" <Barry.Song@analog.com> To: Mike Frysinger <vapier.adi@gmail.com>, Barry Song <21cnbao@gmail.com> Cc: "Hennerich, Michael" <Michael.Hennerich@analog.com>, Dmitry Torokhov <dmitry.torokhov@gmail.com>, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, uclinux-dist-devel@blackfin.uclinux.org Subject: RE: [Uclinux-dist-devel] [PATCH] input/keyboard: add ADP5588 QWERTYI2C Keyboard Input device driver Date: Wed, 16 Sep 2009 12:18:38 +0800 [thread overview] Message-ID: <0F1B54C89D5F954D8535DB252AF412FA04BEE48B@chinexm1.ad.analog.com> (raw) In-Reply-To: <8bd0f97a0909152103m4848fe9ayb5835a6844ea4ca1@mail.gmail.com> >-----Original Message----- >From: uclinux-dist-devel-bounces@blackfin.uclinux.org >[mailto:uclinux-dist-devel-bounces@blackfin.uclinux.org] On >Behalf Of Mike Frysinger >Sent: Wednesday, September 16, 2009 12:04 PM >To: Barry Song >Cc: Hennerich, Michael; Dmitry Torokhov; >linux-kernel@vger.kernel.org; linux-input@vger.kernel.org; >uclinux-dist-devel@blackfin.uclinux.org >Subject: Re: [Uclinux-dist-devel] [PATCH] input/keyboard: add >ADP5588 QWERTYI2C Keyboard Input device driver > >On Tue, Sep 15, 2009 at 23:49, Barry Song wrote: >> On Wed, Sep 16, 2009 at 12:26 AM, Dmitry Torokhov wrote: >>> On Tue, Sep 15, 2009 at 07:19:14AM -0400, Mike Frysinger wrote: >>>> On Tue, Sep 15, 2009 at 02:20, Dmitry Torokhov wrote: >>>> > BTW, maybe you shoudl convert to threaded IRQs here? >>>> >>>> yes, after your suggestion for the previous driver, we've >been looking >>>> at all our input drivers to convert to threaded IRQs. do >we need to >>>> convert all of them before acceptance, or can we merge now >and post an >>>> updated patch after ? >>> >>> It really depends on the driver. If there is a race between >IRQ and the >>> WQ in the driver I will request you to fix it one way or >another before >>> accepting the driver (and quite often using threaded IRQ >gets rid of the >>> race). In the cases like this particular driver though I am not even >>> convinced that we need threaded IRQ. The driver is not expected to >>> generate lots of events rapidly so using keventd as it does now is >>> probably the best solution. >> >> Even though CONFIG_GENERIC_HARDIRQS is almost always "y", in case >> CONFIG_GENERIC_HARDIRQS is "n" not "y", threaded_irq will become >> original irq, drivers will not work. So is it necessary to check the >> dependence of GENERIC_HARDIRQS while using threaded_irq? > >when is GENERIC_HARDIRQS not "y" ? a quick check shows only s390/m68k >dont set it to "y" in their arch Kconfig ? s390 isnt going to use any >of these drivers, and m68k will eventually update (m68knommu already >has !?). SPARC32 is "n" too. I am not caring about only these several drivers. I just want to find whether that can be a generic problem while using threaded_irq in any driver. >-mike >_______________________________________________ >Uclinux-dist-devel mailing list >Uclinux-dist-devel@blackfin.uclinux.org >https://blackfin.uclinux.org/mailman/listinfo/uclinux-dist-devel > -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2009-09-16 4:19 UTC|newest] Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top 2009-09-14 22:18 [PATCH] input/keyboard: add ADP5588 QWERTY I2C Keyboard Input device driver Mike Frysinger 2009-09-15 6:20 ` Dmitry Torokhov 2009-09-15 11:19 ` Mike Frysinger 2009-09-15 11:19 ` Mike Frysinger 2009-09-15 16:26 ` Dmitry Torokhov 2009-09-15 16:26 ` Dmitry Torokhov 2009-09-15 16:46 ` Mike Frysinger 2009-09-15 16:46 ` Mike Frysinger 2009-09-15 17:17 ` Dmitry Torokhov 2009-09-15 17:17 ` Dmitry Torokhov 2009-09-16 3:49 ` Barry Song 2009-09-16 3:49 ` Barry Song 2009-09-16 4:03 ` Mike Frysinger 2009-09-16 4:03 ` Mike Frysinger 2009-09-16 4:18 ` Song, Barry [this message] 2009-09-16 4:18 ` [Uclinux-dist-devel] [PATCH] input/keyboard: add ADP5588 QWERTYI2C " Song, Barry 2009-09-16 4:25 ` Mike Frysinger 2009-09-16 4:25 ` Mike Frysinger 2009-09-16 4:49 ` Dmitry Torokhov 2009-09-16 4:49 ` Dmitry Torokhov 2009-09-16 21:07 ` [PATCH] input/keyboard: add ADP5588 QWERTY I2C " Robin Getz 2009-09-16 21:07 ` Robin Getz 2009-09-16 0:49 ` [PATCH v2] " Mike Frysinger 2009-09-16 5:02 ` Dmitry Torokhov 2009-09-16 5:02 ` Dmitry Torokhov 2009-09-16 12:55 ` [Uclinux-dist-devel] " Mike Frysinger 2009-09-16 12:55 ` Mike Frysinger 2009-09-16 16:33 ` Dmitry Torokhov 2009-09-16 16:33 ` Dmitry Torokhov 2009-09-16 18:20 ` [PATCH v3] " Mike Frysinger 2009-09-18 5:42 ` Dmitry Torokhov 2009-09-21 16:45 ` [Uclinux-dist-devel] [PATCH v2] " Mike Frysinger 2009-09-21 16:45 ` Mike Frysinger 2009-09-21 16:55 ` Dmitry Torokhov 2009-09-21 16:55 ` Dmitry Torokhov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=0F1B54C89D5F954D8535DB252AF412FA04BEE48B@chinexm1.ad.analog.com \ --to=barry.song@analog.com \ --cc=21cnbao@gmail.com \ --cc=Michael.Hennerich@analog.com \ --cc=dmitry.torokhov@gmail.com \ --cc=linux-input@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=uclinux-dist-devel@blackfin.uclinux.org \ --cc=vapier.adi@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.