Re: [PATCH] input/keyboard: add ADP5588 QWERTY I2C Keyboard Input device driver

From: Mike Frysinger <vapier.adi@gmail.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Robin Getz <rgetz@blackfin.uclinux.org>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
	uclinux-dist-devel@blackfin.uclinux.org,
	Michael Hennerich <michael.hennerich@analog.com>,
	Bryan Wu <cooloney@kernel.org>
Subject: Re: [PATCH] input/keyboard: add ADP5588 QWERTY I2C Keyboard Input  device driver
Date: Tue, 15 Sep 2009 07:19:14 -0400	[thread overview]
Message-ID: <8bd0f97a0909150419p1048bfe9j243fa30a0581b198@mail.gmail.com> (raw)
In-Reply-To: <20090915062050.GB10232@core.coreip.homeip.net>

On Tue, Sep 15, 2009 at 02:20, Dmitry Torokhov wrote:
> On Mon, Sep 14, 2009 at 06:18:39PM -0400, Mike Frysinger wrote:
>> +static int __devexit adp5588_remove(struct i2c_client *client)
>> +{
>> +     struct adp5588_kpad *kpad = dev_get_drvdata(&client->dev);
>> +
>> +     adp5588_write(client, CFG, 0);
>> +     free_irq(client->irq, kpad);
>
> cancel_work_sync() is missing. Could you try the updated version below?

i dont think i have any adp5588 hardware.  Robin: do we have any in
Norwood ?  otherwise, it'll have to wait for Michael to get back to
double check.

> BTW, maybe you shoudl convert to threaded IRQs here?

yes, after your suggestion for the previous driver, we've been looking
at all our input drivers to convert to threaded IRQs.  do we need to
convert all of them before acceptance, or can we merge now and post an
updated patch after ?
-mike