From: David Laight <David.Laight@ACULAB.COM>
To: 'Philippe Schenker' <dev@pschenker.ch>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
Jonathan Cameron <jic23@kernel.org>,
"Stefan Agner" <stefan@agner.ch>,
Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>
Cc: Philippe Schenker <philippe.schenker@toradex.com>,
Max Krummenacher <max.krummenacher@toradex.com>,
Alexandre Torgue <alexandre.torgue@st.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Lee Jones <lee.jones@linaro.org>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
"linux-stm32@st-md-mailman.stormreply.com"
<linux-stm32@st-md-mailman.stormreply.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: RE: [PATCH 2/3] iio: stmpe-adc: Make wait_completion non interruptible
Date: Fri, 3 May 2019 14:39:32 +0000 [thread overview]
Message-ID: <0aab3e91bb9644acb430a8beba927b5a@AcuMS.aculab.com> (raw)
In-Reply-To: <20190503135725.9959-2-dev@pschenker.ch>
From: Philippe Schenker
> Sent: 03 May 2019 14:57
> In some cases, the wait_completion got interrupted. This caused the
> error-handling to mutex_unlock the function. The before turned on
> interrupt then got called anyway. In the ISR then completion()
> was called causing problems.
>
> Making this wait_completion non interruptible solves the problem.
Won't the same thing happen if the interrupt occurs just after
the timeout?
David
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)
WARNING: multiple messages have this Message-ID (diff)
From: David Laight <David.Laight@ACULAB.COM>
To: 'Philippe Schenker' <dev@pschenker.ch>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
Jonathan Cameron <jic23@kernel.org>,
"Stefan Agner" <stefan@agner.ch>,
Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>
Cc: Max Krummenacher <max.krummenacher@toradex.com>,
Alexandre Torgue <alexandre.torgue@st.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Philippe Schenker <philippe.schenker@toradex.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Lee Jones <lee.jones@linaro.org>,
"linux-stm32@st-md-mailman.stormreply.com"
<linux-stm32@st-md-mailman.stormreply.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: RE: [PATCH 2/3] iio: stmpe-adc: Make wait_completion non interruptible
Date: Fri, 3 May 2019 14:39:32 +0000 [thread overview]
Message-ID: <0aab3e91bb9644acb430a8beba927b5a@AcuMS.aculab.com> (raw)
In-Reply-To: <20190503135725.9959-2-dev@pschenker.ch>
From: Philippe Schenker
> Sent: 03 May 2019 14:57
> In some cases, the wait_completion got interrupted. This caused the
> error-handling to mutex_unlock the function. The before turned on
> interrupt then got called anyway. In the ISR then completion()
> was called causing problems.
>
> Making this wait_completion non interruptible solves the problem.
Won't the same thing happen if the interrupt occurs just after
the timeout?
David
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-05-03 14:39 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-03 13:57 [PATCH 1/3] iio: stmpe-adc: Remove unnecessary assignment Philippe Schenker
2019-05-03 13:57 ` Philippe Schenker
2019-05-03 13:57 ` [PATCH 2/3] iio: stmpe-adc: Make wait_completion non interruptible Philippe Schenker
2019-05-03 13:57 ` Philippe Schenker
2019-05-03 14:39 ` David Laight [this message]
2019-05-03 14:39 ` David Laight
2019-05-03 15:58 ` Philippe Schenker
2019-05-03 15:58 ` Philippe Schenker
[not found] ` <20190505164409.7976f43e@archlinux>
[not found] ` <4df31129d19c4128a4bbc5e0575886af@AcuMS.aculab.com>
2019-05-07 14:31 ` Philippe Schenker
2019-05-07 14:31 ` Philippe Schenker
2019-05-03 13:57 ` [PATCH 3/3] iio: stmpe-adc: Enable all stmpe-adc interrupts just once Philippe Schenker
2019-05-03 13:57 ` Philippe Schenker
2019-05-05 15:45 ` Jonathan Cameron
2019-05-05 15:45 ` Jonathan Cameron
2019-05-07 14:32 ` Philippe Schenker
2019-05-07 14:32 ` Philippe Schenker
2019-05-05 15:39 ` [PATCH 1/3] iio: stmpe-adc: Remove unnecessary assignment Jonathan Cameron
2019-05-05 15:39 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0aab3e91bb9644acb430a8beba927b5a@AcuMS.aculab.com \
--to=david.laight@aculab.com \
--cc=alexandre.torgue@st.com \
--cc=dev@pschenker.ch \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=max.krummenacher@toradex.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=philippe.schenker@toradex.com \
--cc=pmeerw@pmeerw.net \
--cc=stefan@agner.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.