From: Andrew Lunn <andrew@lunn.ch>
To: "Limonciello, Mario" <mario.limonciello@amd.com>
Cc: Evan Quan <evan.quan@amd.com>,
rafael@kernel.org, lenb@kernel.org, Alexander.Deucher@amd.com,
Christian.Koenig@amd.com, Xinhui.Pan@amd.com, airlied@gmail.com,
daniel@ffwll.ch, johannes@sipsolutions.net, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
mdaenzer@redhat.com, maarten.lankhorst@linux.intel.com,
tzimmermann@suse.de, hdegoede@redhat.com, jingyuwang_vip@163.com,
Lijo.Lazar@amd.com, jim.cromie@gmail.com, bellosilicio@gmail.com,
andrealmeid@igalia.com, trix@redhat.com, jsg@jsg.id.au,
arnd@arndb.de, linux-kernel@vger.kernel.org,
linux-acpi@vger.kernel.org, amd-gfx@lists.freedesktop.org,
dri-devel@lists.freedesktop.org, linux-wireless@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH V5 1/9] drivers core: Add support for Wifi band RF mitigations
Date: Sat, 1 Jul 2023 02:25:17 +0200 [thread overview]
Message-ID: <0f18f4bf-dc38-49e3-a484-ca2456549f0b@lunn.ch> (raw)
In-Reply-To: <3e095621-d7dc-9069-45dc-498c8f3bb4f4@amd.com>
> Right now there are stubs for non CONFIG_WBRF as well as other patches are
> using #ifdef CONFIG_WBRF or having their own stubs. Like mac80211 patch
> looks for #ifdef CONFIG_WBRF.
>
> I think we should pick one or the other.
>
> Having other subsystems #ifdef CONFIG_WBRF will make the series easier to
> land through multiple trees; so I have a slight leaning in that direction.
#ifdef in C files is generally not liked because it makes build
testing harder. There are more permutations to build. It is better to use
if (IS_ENABLED(CONFIG_WBTR)) {
}
so that the code is compiled, and them throw away because
IS_ENABLED(CONFIG_WBTR) evaluates to false.
However, if the stubs are done correctly, the driver should not
care. I doubt this is used in any sort of hot path where every
instruction counts.
Andrew
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew@lunn.ch>
To: "Limonciello, Mario" <mario.limonciello@amd.com>
Cc: jingyuwang_vip@163.com, bellosilicio@gmail.com,
rafael@kernel.org, trix@redhat.com, Lijo.Lazar@amd.com,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
mdaenzer@redhat.com, amd-gfx@lists.freedesktop.org,
linux-acpi@vger.kernel.org, kuba@kernel.org, pabeni@redhat.com,
lenb@kernel.org, andrealmeid@igalia.com, arnd@arndb.de,
hdegoede@redhat.com, Evan Quan <evan.quan@amd.com>,
netdev@vger.kernel.org, Xinhui.Pan@amd.com,
linux-wireless@vger.kernel.org, edumazet@google.com,
Christian.Koenig@amd.com, tzimmermann@suse.de,
Alexander.Deucher@amd.com, johannes@sipsolutions.net,
davem@davemloft.net
Subject: Re: [PATCH V5 1/9] drivers core: Add support for Wifi band RF mitigations
Date: Sat, 1 Jul 2023 02:25:17 +0200 [thread overview]
Message-ID: <0f18f4bf-dc38-49e3-a484-ca2456549f0b@lunn.ch> (raw)
In-Reply-To: <3e095621-d7dc-9069-45dc-498c8f3bb4f4@amd.com>
> Right now there are stubs for non CONFIG_WBRF as well as other patches are
> using #ifdef CONFIG_WBRF or having their own stubs. Like mac80211 patch
> looks for #ifdef CONFIG_WBRF.
>
> I think we should pick one or the other.
>
> Having other subsystems #ifdef CONFIG_WBRF will make the series easier to
> land through multiple trees; so I have a slight leaning in that direction.
#ifdef in C files is generally not liked because it makes build
testing harder. There are more permutations to build. It is better to use
if (IS_ENABLED(CONFIG_WBTR)) {
}
so that the code is compiled, and them throw away because
IS_ENABLED(CONFIG_WBTR) evaluates to false.
However, if the stubs are done correctly, the driver should not
care. I doubt this is used in any sort of hot path where every
instruction counts.
Andrew
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew@lunn.ch>
To: "Limonciello, Mario" <mario.limonciello@amd.com>
Cc: jingyuwang_vip@163.com, bellosilicio@gmail.com,
rafael@kernel.org, trix@redhat.com, Lijo.Lazar@amd.com,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
mdaenzer@redhat.com, airlied@gmail.com,
amd-gfx@lists.freedesktop.org, linux-acpi@vger.kernel.org,
kuba@kernel.org, pabeni@redhat.com, lenb@kernel.org,
andrealmeid@igalia.com, daniel@ffwll.ch, arnd@arndb.de,
maarten.lankhorst@linux.intel.com, hdegoede@redhat.com,
jsg@jsg.id.au, Evan Quan <evan.quan@amd.com>,
jim.cromie@gmail.com, netdev@vger.kernel.org, Xinhui.Pan@amd.com,
linux-wireless@vger.kernel.org, edumazet@google.com,
Christian.Koenig@amd.com, tzimmermann@suse.de,
Alexander.Deucher@amd.com, johannes@sipsolutions.net,
davem@davemloft.net
Subject: Re: [PATCH V5 1/9] drivers core: Add support for Wifi band RF mitigations
Date: Sat, 1 Jul 2023 02:25:17 +0200 [thread overview]
Message-ID: <0f18f4bf-dc38-49e3-a484-ca2456549f0b@lunn.ch> (raw)
In-Reply-To: <3e095621-d7dc-9069-45dc-498c8f3bb4f4@amd.com>
> Right now there are stubs for non CONFIG_WBRF as well as other patches are
> using #ifdef CONFIG_WBRF or having their own stubs. Like mac80211 patch
> looks for #ifdef CONFIG_WBRF.
>
> I think we should pick one or the other.
>
> Having other subsystems #ifdef CONFIG_WBRF will make the series easier to
> land through multiple trees; so I have a slight leaning in that direction.
#ifdef in C files is generally not liked because it makes build
testing harder. There are more permutations to build. It is better to use
if (IS_ENABLED(CONFIG_WBTR)) {
}
so that the code is compiled, and them throw away because
IS_ENABLED(CONFIG_WBTR) evaluates to false.
However, if the stubs are done correctly, the driver should not
care. I doubt this is used in any sort of hot path where every
instruction counts.
Andrew
next prev parent reply other threads:[~2023-07-01 0:25 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-30 10:32 [PATCH V5 0/9] Enable Wifi RFI interference mitigation feature support Evan Quan
2023-06-30 10:32 ` Evan Quan
2023-06-30 10:32 ` [PATCH V5 1/9] drivers core: Add support for Wifi band RF mitigations Evan Quan
2023-06-30 10:32 ` Evan Quan
2023-06-30 13:38 ` Simon Horman
2023-06-30 13:38 ` Simon Horman
2023-06-30 13:38 ` Simon Horman
2023-07-04 3:41 ` Quan, Evan
2023-07-04 3:41 ` Quan, Evan
2023-07-04 3:41 ` Quan, Evan
2023-06-30 16:40 ` Limonciello, Mario
2023-06-30 16:40 ` Limonciello, Mario
2023-07-01 0:25 ` Andrew Lunn [this message]
2023-07-01 0:25 ` Andrew Lunn
2023-07-01 0:25 ` Andrew Lunn
2023-07-04 3:25 ` Quan, Evan
2023-07-04 3:25 ` Quan, Evan
2023-07-04 3:25 ` Quan, Evan
2023-07-04 3:40 ` Quan, Evan
2023-07-04 3:40 ` Quan, Evan
2023-07-04 3:53 ` Mario Limonciello
2023-07-04 3:53 ` Mario Limonciello
2023-07-01 0:19 ` Andrew Lunn
2023-07-01 0:19 ` Andrew Lunn
2023-07-01 0:19 ` Andrew Lunn
2023-07-04 3:30 ` Quan, Evan
2023-07-04 3:30 ` Quan, Evan
2023-07-04 3:30 ` Quan, Evan
2023-07-04 13:07 ` Andrew Lunn
2023-07-04 13:07 ` Andrew Lunn
2023-07-04 13:07 ` Andrew Lunn
2023-07-06 2:58 ` Quan, Evan
2023-07-06 2:58 ` Quan, Evan
2023-07-06 2:58 ` Quan, Evan
2023-07-06 3:09 ` Mario Limonciello
2023-07-06 3:09 ` Mario Limonciello
2023-07-06 3:09 ` Mario Limonciello
2023-06-30 10:32 ` [PATCH V5 2/9] driver core: add ACPI based WBRF mechanism introduced by AMD Evan Quan
2023-06-30 10:32 ` Evan Quan
2023-07-01 0:51 ` Andrew Lunn
2023-07-01 0:51 ` Andrew Lunn
2023-07-01 0:51 ` Andrew Lunn
2023-07-04 3:24 ` Quan, Evan
2023-07-04 3:24 ` Quan, Evan
2023-07-04 3:24 ` Quan, Evan
2023-06-30 10:32 ` [PATCH V5 3/9] cfg80211: expose nl80211_chan_width_to_mhz for wide sharing Evan Quan
2023-06-30 10:32 ` Evan Quan
2023-06-30 10:32 ` [PATCH V5 4/9] wifi: mac80211: Add support for ACPI WBRF Evan Quan
2023-06-30 10:32 ` Evan Quan
2023-06-30 14:08 ` kernel test robot
2023-06-30 14:08 ` kernel test robot
2023-07-01 1:02 ` Andrew Lunn
2023-07-01 1:02 ` Andrew Lunn
2023-07-01 1:02 ` Andrew Lunn
2023-07-04 3:12 ` Quan, Evan
2023-07-04 3:12 ` Quan, Evan
2023-07-04 3:12 ` Quan, Evan
2023-06-30 10:32 ` [PATCH V5 5/9] drm/amd/pm: update driver_if and ppsmc headers for coming wbrf feature Evan Quan
2023-06-30 10:32 ` Evan Quan
2023-06-30 10:32 ` [PATCH V5 6/9] drm/amd/pm: setup the framework to support Wifi RFI mitigation feature Evan Quan
2023-06-30 10:32 ` Evan Quan
2023-06-30 10:32 ` [PATCH V5 7/9] drm/amd/pm: add flood detection for wbrf events Evan Quan
2023-06-30 10:32 ` Evan Quan
2023-06-30 14:29 ` kernel test robot
2023-06-30 14:29 ` kernel test robot
2023-06-30 10:32 ` [PATCH V5 8/9] drm/amd/pm: enable Wifi RFI mitigation feature support for SMU13.0.0 Evan Quan
2023-06-30 10:32 ` Evan Quan
2023-06-30 10:32 ` [PATCH V5 9/9] drm/amd/pm: enable Wifi RFI mitigation feature support for SMU13.0.7 Evan Quan
2023-06-30 10:32 ` Evan Quan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0f18f4bf-dc38-49e3-a484-ca2456549f0b@lunn.ch \
--to=andrew@lunn.ch \
--cc=Alexander.Deucher@amd.com \
--cc=Christian.Koenig@amd.com \
--cc=Lijo.Lazar@amd.com \
--cc=Xinhui.Pan@amd.com \
--cc=airlied@gmail.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=andrealmeid@igalia.com \
--cc=arnd@arndb.de \
--cc=bellosilicio@gmail.com \
--cc=daniel@ffwll.ch \
--cc=davem@davemloft.net \
--cc=dri-devel@lists.freedesktop.org \
--cc=edumazet@google.com \
--cc=evan.quan@amd.com \
--cc=hdegoede@redhat.com \
--cc=jim.cromie@gmail.com \
--cc=jingyuwang_vip@163.com \
--cc=johannes@sipsolutions.net \
--cc=jsg@jsg.id.au \
--cc=kuba@kernel.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mario.limonciello@amd.com \
--cc=mdaenzer@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rafael@kernel.org \
--cc=trix@redhat.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.