From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>, robh+dt@kernel.org
Cc: krzysztof.kozlowski+dt@linaro.org, matthias.bgg@gmail.com,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
konrad.dybcio@somainline.org, marijn.suijten@somainline.org,
martin.botka@somainline.org,
~postmarketos/upstreaming@lists.sr.ht,
phone-devel@vger.kernel.org, paul.bouchara@somainline.org,
kernel@collabora.com
Subject: Re: [PATCH 5/7] arm64: dts: mediatek: mt6795: Add fixed clocks for 32kHz and 26MHz XOs
Date: Mon, 16 May 2022 10:51:44 +0200 [thread overview]
Message-ID: <0f303425-3b12-7573-b201-030d4d044db8@collabora.com> (raw)
In-Reply-To: <03e99a02-1233-3882-e1e5-24ab1bbaf257@linaro.org>
Il 16/05/22 09:10, Krzysztof Kozlowski ha scritto:
> On 13/05/2022 19:16, AngeloGioacchino Del Regno wrote:
>> Add the 32kHz and 26MHz oscillators as fixed clocks in devicetree to
>> provide a good initial clock spec, since this SoC features two always
>
> I don't understand that part with actual patch. You claim here you add
> clocks, but in DTS they were already before.
>
> Additionally, these clocks do not belong to DTSI because, AFAIU, these
> are properties of boards. At least their frequencies should be moved to
> the board DTS.
>
>
I should reword the commit description to be clearer, sorry about that: I
went with "exactly what I've done", but looking at the actual diff, it is
just a rename. What my brain was ticking on here was about removing clocks
that didn't really exist (uart_clk is not a fixed clock, etc), and adding
the ones that do exist.... but then again, the result, casually, is a rename.
In any case... no, these clocks are not board-specific for two reasons:
1. AFAIK, these fixed clock outputs are from the SoC itself, not from
external components placed on the board, and
2. Even if these were from external components, the SoC *needs* these
ones to work and any board that doesn't have these fixed XOs simply
wouldn't be able to work.
Cheers,
Angelo
WARNING: multiple messages have this Message-ID (diff)
From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>, robh+dt@kernel.org
Cc: krzysztof.kozlowski+dt@linaro.org, matthias.bgg@gmail.com,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
konrad.dybcio@somainline.org, marijn.suijten@somainline.org,
martin.botka@somainline.org,
~postmarketos/upstreaming@lists.sr.ht,
phone-devel@vger.kernel.org, paul.bouchara@somainline.org,
kernel@collabora.com
Subject: Re: [PATCH 5/7] arm64: dts: mediatek: mt6795: Add fixed clocks for 32kHz and 26MHz XOs
Date: Mon, 16 May 2022 10:51:44 +0200 [thread overview]
Message-ID: <0f303425-3b12-7573-b201-030d4d044db8@collabora.com> (raw)
In-Reply-To: <03e99a02-1233-3882-e1e5-24ab1bbaf257@linaro.org>
Il 16/05/22 09:10, Krzysztof Kozlowski ha scritto:
> On 13/05/2022 19:16, AngeloGioacchino Del Regno wrote:
>> Add the 32kHz and 26MHz oscillators as fixed clocks in devicetree to
>> provide a good initial clock spec, since this SoC features two always
>
> I don't understand that part with actual patch. You claim here you add
> clocks, but in DTS they were already before.
>
> Additionally, these clocks do not belong to DTSI because, AFAIU, these
> are properties of boards. At least their frequencies should be moved to
> the board DTS.
>
>
I should reword the commit description to be clearer, sorry about that: I
went with "exactly what I've done", but looking at the actual diff, it is
just a rename. What my brain was ticking on here was about removing clocks
that didn't really exist (uart_clk is not a fixed clock, etc), and adding
the ones that do exist.... but then again, the result, casually, is a rename.
In any case... no, these clocks are not board-specific for two reasons:
1. AFAIK, these fixed clock outputs are from the SoC itself, not from
external components placed on the board, and
2. Even if these were from external components, the SoC *needs* these
ones to work and any board that doesn't have these fixed XOs simply
wouldn't be able to work.
Cheers,
Angelo
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>, robh+dt@kernel.org
Cc: krzysztof.kozlowski+dt@linaro.org, matthias.bgg@gmail.com,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
konrad.dybcio@somainline.org, marijn.suijten@somainline.org,
martin.botka@somainline.org,
~postmarketos/upstreaming@lists.sr.ht,
phone-devel@vger.kernel.org, paul.bouchara@somainline.org,
kernel@collabora.com
Subject: Re: [PATCH 5/7] arm64: dts: mediatek: mt6795: Add fixed clocks for 32kHz and 26MHz XOs
Date: Mon, 16 May 2022 10:51:44 +0200 [thread overview]
Message-ID: <0f303425-3b12-7573-b201-030d4d044db8@collabora.com> (raw)
In-Reply-To: <03e99a02-1233-3882-e1e5-24ab1bbaf257@linaro.org>
Il 16/05/22 09:10, Krzysztof Kozlowski ha scritto:
> On 13/05/2022 19:16, AngeloGioacchino Del Regno wrote:
>> Add the 32kHz and 26MHz oscillators as fixed clocks in devicetree to
>> provide a good initial clock spec, since this SoC features two always
>
> I don't understand that part with actual patch. You claim here you add
> clocks, but in DTS they were already before.
>
> Additionally, these clocks do not belong to DTSI because, AFAIU, these
> are properties of boards. At least their frequencies should be moved to
> the board DTS.
>
>
I should reword the commit description to be clearer, sorry about that: I
went with "exactly what I've done", but looking at the actual diff, it is
just a rename. What my brain was ticking on here was about removing clocks
that didn't really exist (uart_clk is not a fixed clock, etc), and adding
the ones that do exist.... but then again, the result, casually, is a rename.
In any case... no, these clocks are not board-specific for two reasons:
1. AFAIK, these fixed clock outputs are from the SoC itself, not from
external components placed on the board, and
2. Even if these were from external components, the SoC *needs* these
ones to work and any board that doesn't have these fixed XOs simply
wouldn't be able to work.
Cheers,
Angelo
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-05-16 8:51 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-13 17:16 [PATCH 0/7] MediaTek Helio X10 MT6795 - Devicetree, part 1 AngeloGioacchino Del Regno
2022-05-13 17:16 ` AngeloGioacchino Del Regno
2022-05-13 17:16 ` AngeloGioacchino Del Regno
2022-05-13 17:16 ` [PATCH 1/7] arm64: dts: mediatek: mt6795: Create soc bus node and move mmio devices AngeloGioacchino Del Regno
2022-05-13 17:16 ` AngeloGioacchino Del Regno
2022-05-13 17:16 ` AngeloGioacchino Del Regno
2022-05-13 17:16 ` [PATCH 2/7] arm64: dts: mediatek: mt6795: Add cpu-map and L2 cache AngeloGioacchino Del Regno
2022-05-13 17:16 ` AngeloGioacchino Del Regno
2022-05-13 17:16 ` AngeloGioacchino Del Regno
2022-05-13 17:16 ` [PATCH 3/7] arm64: dts: mediatek: mt6795: Add Cortex A53 PMU nodes AngeloGioacchino Del Regno
2022-05-13 17:16 ` AngeloGioacchino Del Regno
2022-05-13 17:16 ` AngeloGioacchino Del Regno
2022-05-13 17:16 ` [PATCH 4/7] arm64: dts: mediatek: mt6795: Add watchdog node to avoid timeouts AngeloGioacchino Del Regno
2022-05-13 17:16 ` AngeloGioacchino Del Regno
2022-05-13 17:16 ` AngeloGioacchino Del Regno
2022-05-13 17:16 ` [PATCH 5/7] arm64: dts: mediatek: mt6795: Add fixed clocks for 32kHz and 26MHz XOs AngeloGioacchino Del Regno
2022-05-13 17:16 ` AngeloGioacchino Del Regno
2022-05-13 17:16 ` AngeloGioacchino Del Regno
2022-05-16 7:10 ` Krzysztof Kozlowski
2022-05-16 7:10 ` Krzysztof Kozlowski
2022-05-16 7:10 ` Krzysztof Kozlowski
2022-05-16 8:51 ` AngeloGioacchino Del Regno [this message]
2022-05-16 8:51 ` AngeloGioacchino Del Regno
2022-05-16 8:51 ` AngeloGioacchino Del Regno
2022-05-16 14:51 ` Krzysztof Kozlowski
2022-05-16 14:51 ` Krzysztof Kozlowski
2022-05-16 14:51 ` Krzysztof Kozlowski
2022-05-17 8:14 ` AngeloGioacchino Del Regno
2022-05-17 8:14 ` AngeloGioacchino Del Regno
2022-05-17 8:14 ` AngeloGioacchino Del Regno
2022-05-17 8:18 ` Krzysztof Kozlowski
2022-05-17 8:18 ` Krzysztof Kozlowski
2022-05-17 8:18 ` Krzysztof Kozlowski
2022-05-13 17:16 ` [PATCH 6/7] arm64: dts: mediatek: mt6795: Add general purpose timer node AngeloGioacchino Del Regno
2022-05-13 17:16 ` AngeloGioacchino Del Regno
2022-05-13 17:16 ` AngeloGioacchino Del Regno
2022-05-13 17:16 ` [PATCH 7/7] arm64: dts: mediatek: mt6795: Add ARM CCI-400 node and assign to CPUs AngeloGioacchino Del Regno
2022-05-13 17:16 ` AngeloGioacchino Del Regno
2022-05-13 17:16 ` AngeloGioacchino Del Regno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0f303425-3b12-7573-b201-030d4d044db8@collabora.com \
--to=angelogioacchino.delregno@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=kernel@collabora.com \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=marijn.suijten@somainline.org \
--cc=martin.botka@somainline.org \
--cc=matthias.bgg@gmail.com \
--cc=paul.bouchara@somainline.org \
--cc=phone-devel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.