All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>
Subject: [PATCH 5/6] tools/include: adjust x86-specific population of xen/
Date: Thu, 10 Sep 2020 14:13:00 +0200	[thread overview]
Message-ID: <0f9f05c2-2f76-93d6-21e9-6308741c49b7@suse.com> (raw)
In-Reply-To: <2a9f86aa-9104-8a45-cd21-72acd693f924@suse.com>

There's no need to use a shell loop construct here - ln's destination
can be specified as just the intended directory, as we don't mean to
change the names of any of the files. Also drop XEN_LIB_X86_INCLUDES for
having a single use only, and don't pass -f to ln, to allow noticing
name collisions right away.

Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/tools/include/Makefile
+++ b/tools/include/Makefile
@@ -12,8 +12,6 @@ all-y:
 xen-foreign:
 	$(MAKE) -C xen-foreign
 
-XEN_LIB_X86_INCLUDES = $(filter-out %autogen.h, $(XEN_ROOT)/xen/include/xen/lib/x86/Makefile $(wildcard $(XEN_ROOT)/xen/include/xen/lib/x86/*.h))
-
 xen-dir:
 	@rm -rf xen acpi
 	mkdir -p xen/libelf acpi
@@ -26,11 +24,10 @@ xen-dir:
 	ln -s $(XEN_ROOT)/xen/include/acpi/platform acpi/
 	ln -s $(XEN_ROOT)/xen/include/acpi/ac*.h acpi/
 ifeq ($(CONFIG_X86),y)
-	ln -sf $(XEN_ROOT)/xen/include/asm-x86 xen/asm
+	ln -s $(XEN_ROOT)/xen/include/asm-x86 xen/asm
 	mkdir -p xen/lib/x86
-	for f in $(patsubst $(XEN_ROOT)/xen/include/xen/lib/x86/%,%,$(XEN_LIB_X86_INCLUDES)); do \
-		ln -sf $(XEN_ROOT)/xen/include/xen/lib/x86/$$f xen/lib/x86/$$f; \
-	done
+	ln -s $(filter-out %autogen.h,$(wildcard $(XEN_ROOT)/xen/include/xen/lib/x86/*.h)) xen/lib/x86/
+	ln -s $(XEN_ROOT)/xen/include/xen/lib/x86/Makefile xen/lib/x86/
 endif
 
 all-$(CONFIG_X86): xen-dir



  parent reply	other threads:[~2020-09-10 12:13 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-10 12:09 [PATCH 0/6] tools/include: adjustments to the population of xen/ Jan Beulich
2020-09-10 12:11 ` [PATCH 1/6] tools/include: adjust population of acpi/ Jan Beulich
2020-09-10 12:12 ` [PATCH 2/6] tools/include: fix (drop) dependencies of when to populate xen/ Jan Beulich
2020-09-10 12:12 ` [PATCH 3/6] tools/include: adjust population of public headers into xen/ Jan Beulich
2020-09-10 12:12 ` [PATCH 4/6] tools/include: properly install Arm public headers Jan Beulich
2020-09-10 12:13 ` Jan Beulich [this message]
2020-09-10 12:13 ` [PATCH 6/6] tools/include: drop remaining -f from ln invocations Jan Beulich
2020-09-10 13:51 ` [PATCH 0/6] tools/include: adjustments to the population of xen/ Andrew Cooper
2020-09-10 14:00   ` Jürgen Groß
2020-09-10 14:06   ` Jan Beulich
2020-09-28  8:30 ` Ping: " Jan Beulich
2020-10-01 16:03 ` Jan Beulich
2020-10-01 16:29   ` Bertrand Marquis
2020-10-01 16:43     ` Bertrand Marquis
2020-10-02  4:27       ` Jürgen Groß
2020-10-02  9:46         ` Bertrand Marquis
2020-10-02 10:17           ` Bertrand Marquis
2020-10-02 11:52   ` Wei Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0f9f05c2-2f76-93d6-21e9-6308741c49b7@suse.com \
    --to=jbeulich@suse.com \
    --cc=iwj@xenproject.org \
    --cc=wl@xen.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.