From: Jan Beulich <jbeulich@suse.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH 0/6] tools/include: adjustments to the population of xen/
Date: Thu, 10 Sep 2020 16:06:38 +0200 [thread overview]
Message-ID: <473e6e88-439f-def3-b561-6db66dee4258@suse.com> (raw)
In-Reply-To: <2d5579e4-74cf-fd35-da7d-a8f4de2c2c86@citrix.com>
On 10.09.2020 15:51, Andrew Cooper wrote:
> On 10/09/2020 13:09, Jan Beulich wrote:
>> While looking at what it would take to move around libelf/
>> in the hypervisor subtree, I've run into this rule, which I
>> think can do with a few improvements and some simplification.
>
> I realise this might be a controversial move, but can we *please*
> address this by removing our use of symlinking, rather than kicking the
> problem down the road.
>
> For header files in particular, there is no need to symlink at all.
> Some properly formed -I runes for the compiler will do the right thing,
> and avoid all intermediate regeneration issues.
With some further work to separate headers in e.g. Xen's acpi/
into ones to be exposed and ones not to be exposed, this
would likely be an option. It's not clear to me though how you
mean to deal with libelf.h and elfstructs.h. Nor is it clear
how we'd deal with x86's cpuid-autogen.h, which needs to have
distinct instances in the two subtrees.
And of course the present full exposure of asm-x86 rather wants
limiting than setting in stone by using -I to point into the
hypervisor tree.
Installing of the headers into dist/ will also need re-working
then.
Taking things together - no, I don't think I'm up to doing this,
yet I think the series presented is an improvement.
Jan
next prev parent reply other threads:[~2020-09-10 14:06 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-10 12:09 [PATCH 0/6] tools/include: adjustments to the population of xen/ Jan Beulich
2020-09-10 12:11 ` [PATCH 1/6] tools/include: adjust population of acpi/ Jan Beulich
2020-09-10 12:12 ` [PATCH 2/6] tools/include: fix (drop) dependencies of when to populate xen/ Jan Beulich
2020-09-10 12:12 ` [PATCH 3/6] tools/include: adjust population of public headers into xen/ Jan Beulich
2020-09-10 12:12 ` [PATCH 4/6] tools/include: properly install Arm public headers Jan Beulich
2020-09-10 12:13 ` [PATCH 5/6] tools/include: adjust x86-specific population of xen/ Jan Beulich
2020-09-10 12:13 ` [PATCH 6/6] tools/include: drop remaining -f from ln invocations Jan Beulich
2020-09-10 13:51 ` [PATCH 0/6] tools/include: adjustments to the population of xen/ Andrew Cooper
2020-09-10 14:00 ` Jürgen Groß
2020-09-10 14:06 ` Jan Beulich [this message]
2020-09-28 8:30 ` Ping: " Jan Beulich
2020-10-01 16:03 ` Jan Beulich
2020-10-01 16:29 ` Bertrand Marquis
2020-10-01 16:43 ` Bertrand Marquis
2020-10-02 4:27 ` Jürgen Groß
2020-10-02 9:46 ` Bertrand Marquis
2020-10-02 10:17 ` Bertrand Marquis
2020-10-02 11:52 ` Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=473e6e88-439f-def3-b561-6db66dee4258@suse.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=iwj@xenproject.org \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.