Re: Ping: [PATCH 0/6] tools/include: adjustments to the population of xen/

From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: "Jürgen Groß" <jgross@suse.com>
Cc: Jan Beulich <jbeulich@suse.com>, Ian Jackson <iwj@xenproject.org>,
	Wei Liu <wl@xen.org>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: Ping: [PATCH 0/6] tools/include: adjustments to the population of xen/
Date: Fri, 2 Oct 2020 10:17:16 +0000	[thread overview]
Message-ID: <B41B6364-77EE-4CD2-AB1D-081A4EA099A0@arm.com> (raw)
In-Reply-To: <A4993E3A-6529-4239-ABF8-DD89A01A54D1@arm.com>

> On 2 Oct 2020, at 10:45, Bertrand Marquis <bertrand.marquis@arm.com> wrote:
> 
> 
> 
>> On 2 Oct 2020, at 05:27, Jürgen Groß <jgross@suse.com> wrote:
>> 
>> On 01.10.20 18:43, Bertrand Marquis wrote:
>>> Hi,
>>>> On 1 Oct 2020, at 17:29, Bertrand Marquis <bertrand.marquis@arm.com> wrote:
>>>> 
>>>> Hi Jan,
>>>> 
>>>>> On 1 Oct 2020, at 17:03, Jan Beulich <jbeulich@suse.com> wrote:
>>>>> 
>>>>> On 10.09.2020 14:09, Jan Beulich wrote:
>>>>>> While looking at what it would take to move around libelf/
>>>>>> in the hypervisor subtree, I've run into this rule, which I
>>>>>> think can do with a few improvements and some simplification.
>>>>>> 
>>>>>> 1: adjust population of acpi/
>>>>>> 2: fix (drop) dependencies of when to populate xen/
>>>>>> 3: adjust population of public headers into xen/
>>>>>> 4: properly install Arm public headers
>>>>>> 5: adjust x86-specific population of xen/
>>>>>> 6: drop remaining -f from ln invocations
>>>>> 
>>>>> May I ask for an ack or otherwise here?
>>>> 
>>>> This is going the right way but with this serie (on top of current staging
>>>> status), I have a compilation error in Yocto while compiling qemu:
>>>> In file included from /media/extend-drive/bermar01/Development/xen-dev/yocto-build/build/dom0-fvp.prj/tmp/work/armv8a-poky-linux/qemu/5.1.0-r0/recipe-sysroot/usr/include/xenguest.h:25,
>>>> |                  from /media/extend-drive/bermar01/Development/xen-dev/yocto-build/build/dom0-fvp.prj/tmp/work/armv8a-poky-linux/qemu/5.1.0-r0/qemu-5.1.0/hw/i386/xen/xen_platform.c:41:
>>>> | /media/extend-drive/bermar01/Development/xen-dev/yocto-build/build/dom0-fvp.prj/tmp/work/armv8a-poky-linux/qemu/5.1.0-r0/recipe-sysroot/usr/include/xenctrl_dom.h:19:10: fatal error: xen/libelf/libelf.h: No such file or directory
>>>> |    19 | #include <xen/libelf/libelf.h>
>>>> |       |          ^~~~~~~~~~~~~~~~~~~~~
>>>> | compilation terminated.
>>>> | /media/extend-drive/bermar01/Development/xen-dev/yocto-build/build/dom0-fvp.prj/tmp/work/armv8a-poky-linux/qemu/5.1.0-r0/qemu-5.1.0/rules.mak:69: recipe for target 'hw/i386/xen/xen_platform.o’ failed
>>>> 
>>>> Xen is using xenctrl_dom.h which need the libelf.h header from xen.
>>> Actually this is not coming from your serie and this is actually a problem already present on master.
>> 
>> ... and fixed on staging.
> 
> I can confirm that with tonight staging status this issue is not present anymore.

… and the serie is building and working properly for arm (including compiling everything
on Yocto).

So:
Tested-by: Bertrand Marquis <bertrand.marquis@arm.com>

And i think it is a good improvement.

Cheers
Bertrand