RE: [RFC PATCH 1/2] spi: Add support for Zynq QSPI controller

From: Harini Katakam <harini.katakam@xilinx.com>
To: Mark Brown <broonie@kernel.org>
Cc: "Grant Likely" <grant.likely@linaro.org>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Pawel Moll" <pawel.moll@arm.com>,
	"Mark Rutland" <mark.rutland@arm.com>,
	"ijc+devicetree@hellion.org.uk" <ijc+devicetree@hellion.org.uk>,
	"Kumar Gala" <galak@codeaurora.org>,
	linux-spi <linux-spi@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
	"David Woodhouse" <dwmw2@infradead.org>,
	"Brian Norris" <computersforpeace@gmail.com>,
	"Marek Vašut" <marex@denx.de>,
	"Artem Bityutskiy" <artem.bityutskiy@linux.intel.com>,
	"Geert Uytterhoeven" <geert+renesas@linux-m68k.org>,
	"Sascha Hauer" <s.hauer@pengutronix.de>,
	"Jingoo Han" <jg1.han@samsung.com>,
	"Sourav Poddar" <sourav.poddar@ti.com>,
	"Michal Simek" <michals@xilinx.com>,
	"Punnaiah Choudary Kalluri" <punnaia@xilinx.com>,
	"harinikatakamlinux@gmail.com" <harinikatakamlinux@gmail.com>,
	"Harini Katakam" <harinik@xilinx.com>
Subject: RE: [RFC PATCH 1/2] spi: Add support for Zynq QSPI controller
Date: Mon, 14 Jul 2014 07:22:24 +0000	[thread overview]
Message-ID: <10e00662-1e08-4552-aae7-1e2029e56238@BY2FFO11FD051.protection.gbl> (raw)
In-Reply-To: <03CA77BA8AF6F1469AEDFBDA1322A7B748213306@XAP-PVEXMBX01.xlnx.xilinx.com>

Hi Mark,

My mail seems to have missed the below reply.
Anyway, please find my answer below:

> -----Original Message-----
> From: Punnaiah Choudary Kalluri
> Sent: Monday, July 14, 2014 12:03 PM
> To: Harini Katakam
> Subject: FW: [RFC PATCH 1/2] spi: Add support for Zynq QSPI controller
> 
> 
> 
> >-----Original Message-----
> >From: Mark Brown [mailto:broonie@kernel.org]
> >Sent: Thursday, July 10, 2014 8:37 PM
> >To: Harini Katakam
> >Cc: Geert Uytterhoeven; Grant Likely; Rob Herring; Pawel Moll; Mark
> Rutland;
> >Ian Campbell; Kumar Gala; linux-spi; linux-kernel@vger.kernel.org;
> >devicetree@vger.kernel.org; linux-doc@vger.kernel.org; David
> Woodhouse;
> >Brian Norris; Marek Vašut; Artem Bityutskiy; Geert Uytterhoeven; Sascha
> >Hauer; Jingoo Han; Sourav Poddar; Michal Simek; Punnaiah Choudary
> Kalluri
> >Subject: Re: [RFC PATCH 1/2] spi: Add support for Zynq QSPI controller
> >
> >On Thu, Jul 10, 2014 at 06:09:55PM +0530, Harini Katakam wrote:
> >> On Thu, Jul 10, 2014 at 5:31 PM, Mark Brown <broonie@kernel.org>
> wrote:
> >
> >> > How does the client driver select the width to use for a transfer?
> >
> >> This controller is meant to be used only with flash devices.
> >> The flash devices' supported width will be reflected in a table in MTD
> layer.
> >> When selecting, priority is given to quad over dual and single in the MTD
> and
> >> it will send commands using the supported tx/rx bus width accordingly.
> >> About the supported bus width on board, tx-bus-width and rx-bus-width
> >> properties in dts will have the info; which I believe spi core uses.
> >
> >If it's only intended to be used as a flash controller (and might
> >misbehave if used as such, if the command detection false triggers) then
> >it is probably better to support it as a flash controller rather than as
> >a SPI controller.  Or can the flash-specific features be disabled?

There is provision to switch to legacy (generic spi) mode but it is not usually used.
As you can can see, the flash related specifics come into play only when two flash devices
are used. For a single slave, it will be generic.
As per your suggestions, I could send this driver in multiple stages -
Initially, qspi driver without flash specifics (this will work straight-away for a single flash)
In the next set, flash specifics changes for dual flash configurations (parallel/stacked)
Is that acceptable?

Regards,
Harini