All of lore.kernel.org
 help / color / mirror / Atom feed
From: <Tudor.Ambarus@microchip.com>
To: <michael@walle.cc>, <vigneshr@ti.com>, <p.yadav@ti.com>
Cc: macromorgan@hotmail.com, jaimeliao@mxic.com.tw, richard@nod.at,
	esben@geanix.com, linux@rasmusvillemoes.dk, knaerzche@gmail.com,
	Nicolas.Ferre@microchip.com, linux-mtd@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org, code@reto-schneider.ch,
	miquel.raynal@bootlin.com, heiko.thiery@gmail.com, sr@denx.de,
	mail@david-bauer.net, zhengxunli@mxic.com.tw
Subject: Re: [PATCH v3 20/25] mtd: spi-nor: sst: sst26vf064b: Init flash based on SFDP
Date: Fri, 29 Oct 2021 17:31:00 +0000	[thread overview]
Message-ID: <11ac4016-94ad-39ce-e845-0324543065fa@microchip.com> (raw)
In-Reply-To: <20211029172633.886453-21-tudor.ambarus@microchip.com>

On 10/29/21 8:26 PM, Tudor Ambarus wrote:
> Get rid of the static initialization of the flash parameters and
> init them when parsing SFDP.
> Generated a 256 Kbyte random data and did an erase, write, read back
> and compare test. The flash uses for reads SPINOR_OP_READ_1_4_4 0xeb,
> for erases SPINOR_OP_BE_4K 0x20, and for writes SPINOR_OP_PP 0x02.
> 
> Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>
> ---

root@sama5d2-xplained:~# cat /sys/devices/platform/ahb/ahb:apb/f0020000.spi/spi_master/spi1/spi1.0/spi-nor/jedec_id
bf2643
root@sama5d2-xplained:~# cat /sys/devices/platform/ahb/ahb:apb/f0020000.spi/spi_master/spi1/spi1.0/spi-nor/manufacturer
sst
root@sama5d2-xplained:~# cat /sys/devices/platform/ahb/ahb:apb/f0020000.spi/spi_master/spi1/spi1.0/spi-nor/partname
sst26vf064b
root@sama5d2-xplained:~# cat /sys/devices/platform/ahb/ahb:apb/f0020000.spi/spi_master/spi1/spi1.0/spi-nor/sfdp > sst26vf064b-sfdp
root@sama5d2-xplained:~# hexdump sst26vf064b-sfdp 
0000000 4653 5044 0106 ff02 0600 1001 0030 ff00
0000010 0081 0601 0100 ff00 00bf 1801 0200 0100
0000020 ffff ffff ffff ffff ffff ffff ffff ffff
0000030 20fd fff1 ffff 03ff eb44 6b08 3b08 bb80
0000040 fffe ffff ffff ff00 ffff 0b44 200c d80d
0000050 d80f d810 9120 2448 6f80 811d 0fed 3877
0000060 b030 b030 fff7 ffff c229 ff5c 30f0 80c0
0000070 ffff ffff ffff ffff ffff ffff ffff ffff
*
0000100 00ff ff04 7ff3 0000 7ff5 0000 fff9 007d
0000110 7ff5 0000 7ff3 0000 ffff ffff ffff ffff
0000120 ffff ffff ffff ffff ffff ffff ffff ffff
*
0000200 26bf ff43 5fb9 fffd f230 f360 ff32 120a
0000210 4623 0fff 3219 190f ff19 ffff ffff ffff
0000220 6600 3899 05ff 3501 0406 3202 30b0 4272
0000230 e88d 8898 85a5 9fc0 5aaf ffff ec06 0c06
0000240 0300 0b08 ffff ffff 07ff ffff 0202 06ff
0000250 0003 fdfd 0704 fc00 0003 fefe 0202 0e07
0000260

>  drivers/mtd/spi-nor/sst.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

WARNING: multiple messages have this Message-ID (diff)
From: <Tudor.Ambarus@microchip.com>
To: <michael@walle.cc>, <vigneshr@ti.com>, <p.yadav@ti.com>
Cc: macromorgan@hotmail.com, jaimeliao@mxic.com.tw, richard@nod.at,
	esben@geanix.com, linux@rasmusvillemoes.dk, knaerzche@gmail.com,
	linux-mtd@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org, code@reto-schneider.ch,
	miquel.raynal@bootlin.com, heiko.thiery@gmail.com, sr@denx.de,
	figgyc@figgyc.uk, mail@david-bauer.net, zhengxunli@mxic.com.tw
Subject: Re: [PATCH v3 20/25] mtd: spi-nor: sst: sst26vf064b: Init flash based on SFDP
Date: Fri, 29 Oct 2021 17:31:00 +0000	[thread overview]
Message-ID: <11ac4016-94ad-39ce-e845-0324543065fa@microchip.com> (raw)
In-Reply-To: <20211029172633.886453-21-tudor.ambarus@microchip.com>

On 10/29/21 8:26 PM, Tudor Ambarus wrote:
> Get rid of the static initialization of the flash parameters and
> init them when parsing SFDP.
> Generated a 256 Kbyte random data and did an erase, write, read back
> and compare test. The flash uses for reads SPINOR_OP_READ_1_4_4 0xeb,
> for erases SPINOR_OP_BE_4K 0x20, and for writes SPINOR_OP_PP 0x02.
> 
> Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>
> ---

root@sama5d2-xplained:~# cat /sys/devices/platform/ahb/ahb:apb/f0020000.spi/spi_master/spi1/spi1.0/spi-nor/jedec_id
bf2643
root@sama5d2-xplained:~# cat /sys/devices/platform/ahb/ahb:apb/f0020000.spi/spi_master/spi1/spi1.0/spi-nor/manufacturer
sst
root@sama5d2-xplained:~# cat /sys/devices/platform/ahb/ahb:apb/f0020000.spi/spi_master/spi1/spi1.0/spi-nor/partname
sst26vf064b
root@sama5d2-xplained:~# cat /sys/devices/platform/ahb/ahb:apb/f0020000.spi/spi_master/spi1/spi1.0/spi-nor/sfdp > sst26vf064b-sfdp
root@sama5d2-xplained:~# hexdump sst26vf064b-sfdp 
0000000 4653 5044 0106 ff02 0600 1001 0030 ff00
0000010 0081 0601 0100 ff00 00bf 1801 0200 0100
0000020 ffff ffff ffff ffff ffff ffff ffff ffff
0000030 20fd fff1 ffff 03ff eb44 6b08 3b08 bb80
0000040 fffe ffff ffff ff00 ffff 0b44 200c d80d
0000050 d80f d810 9120 2448 6f80 811d 0fed 3877
0000060 b030 b030 fff7 ffff c229 ff5c 30f0 80c0
0000070 ffff ffff ffff ffff ffff ffff ffff ffff
*
0000100 00ff ff04 7ff3 0000 7ff5 0000 fff9 007d
0000110 7ff5 0000 7ff3 0000 ffff ffff ffff ffff
0000120 ffff ffff ffff ffff ffff ffff ffff ffff
*
0000200 26bf ff43 5fb9 fffd f230 f360 ff32 120a
0000210 4623 0fff 3219 190f ff19 ffff ffff ffff
0000220 6600 3899 05ff 3501 0406 3202 30b0 4272
0000230 e88d 8898 85a5 9fc0 5aaf ffff ec06 0c06
0000240 0300 0b08 ffff ffff 07ff ffff 0202 06ff
0000250 0003 fdfd 0704 fc00 0003 fefe 0202 0e07
0000260

>  drivers/mtd/spi-nor/sst.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-10-29 18:51 UTC|newest]

Thread overview: 156+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-29 17:26 [PATCH v3 00/25] mtd: spi-nor: Clean params init Tudor Ambarus
2021-10-29 17:26 ` Tudor Ambarus
2021-10-29 17:26 ` [PATCH v3 01/25] mtd: spi-nor: core: Fix spi_nor_flash_parameter otp description Tudor Ambarus
2021-10-29 17:26   ` Tudor Ambarus
2021-11-09  8:18   ` Michael Walle
2021-11-09  8:18     ` Michael Walle
2021-10-29 17:26 ` [PATCH v3 02/25] mtd: spi-nor: core: Use container_of to get the pointer to struct spi_nor Tudor Ambarus
2021-10-29 17:26   ` Tudor Ambarus
2021-11-09  8:21   ` Michael Walle
2021-11-09  8:21     ` Michael Walle
2021-11-15 10:59   ` Pratyush Yadav
2021-11-15 10:59     ` Pratyush Yadav
2021-10-29 17:26 ` [PATCH v3 03/25] mtd: spi-nor: Introduce spi_nor_set_mtd_info() Tudor Ambarus
2021-10-29 17:26   ` Tudor Ambarus
2021-11-09  8:22   ` Michael Walle
2021-11-09  8:22     ` Michael Walle
2021-11-15 18:52   ` Pratyush Yadav
2021-11-15 18:52     ` Pratyush Yadav
2021-11-16 14:25     ` Tudor.Ambarus
2021-11-16 14:25       ` Tudor.Ambarus
2021-11-16 18:11       ` Pratyush Yadav
2021-11-16 18:11         ` Pratyush Yadav
2021-11-17 14:36         ` Tudor.Ambarus
2021-11-17 14:36           ` Tudor.Ambarus
2021-11-19 18:23           ` Pratyush Yadav
2021-11-19 18:23             ` Pratyush Yadav
2021-11-22  8:38             ` Tudor.Ambarus
2021-11-22  8:38               ` Tudor.Ambarus
2021-10-29 17:26 ` [PATCH v3 04/25] mtd: spi-nor: Get rid of nor->page_size Tudor Ambarus
2021-10-29 17:26   ` Tudor Ambarus
2021-11-09  8:24   ` Michael Walle
2021-11-09  8:24     ` Michael Walle
2021-11-09  8:34     ` Tudor.Ambarus
2021-11-09  8:34       ` Tudor.Ambarus
2021-10-29 17:26 ` [PATCH v3 05/25] mtd: spi-nor: core: Introduce the late_init() hook Tudor Ambarus
2021-10-29 17:26   ` Tudor Ambarus
2021-11-09  9:31   ` Michael Walle
2021-11-09  9:31     ` Michael Walle
2021-11-15 18:56   ` Pratyush Yadav
2021-11-15 18:56     ` Pratyush Yadav
2021-10-29 17:26 ` [PATCH v3 06/25] mtd: spi-nor: atmel: Use flash late_init() for locking Tudor Ambarus
2021-10-29 17:26   ` Tudor Ambarus
2021-11-09  9:31   ` Michael Walle
2021-11-09  9:31     ` Michael Walle
2021-11-15 18:59   ` Pratyush Yadav
2021-11-15 18:59     ` Pratyush Yadav
2021-10-29 17:26 ` [PATCH v3 07/25] mtd: spi-nor: sst: " Tudor Ambarus
2021-10-29 17:26   ` Tudor Ambarus
2021-11-09  9:34   ` Michael Walle
2021-11-09  9:34     ` Michael Walle
2021-11-15 19:00   ` Pratyush Yadav
2021-11-15 19:00     ` Pratyush Yadav
2021-10-29 17:26 ` [PATCH v3 08/25] mtd: spi-nor: winbond: Use manufacturer late_init() for OTP ops Tudor Ambarus
2021-10-29 17:26   ` Tudor Ambarus
2021-11-09  9:36   ` Michael Walle
2021-11-09  9:36     ` Michael Walle
2021-11-15 19:00   ` Pratyush Yadav
2021-11-15 19:00     ` Pratyush Yadav
2021-10-29 17:26 ` [PATCH v3 09/25] mtd: spi-nor: xilinx: Use manufacturer late_init() to set setup method Tudor Ambarus
2021-10-29 17:26   ` Tudor Ambarus
2021-11-09  9:43   ` Michael Walle
2021-11-09  9:43     ` Michael Walle
2021-11-15 19:01   ` Pratyush Yadav
2021-11-15 19:01     ` Pratyush Yadav
2021-10-29 17:26 ` [PATCH v3 10/25] mtd: spi-nor: sst: Use manufacturer late_init() to set _write() Tudor Ambarus
2021-10-29 17:26   ` Tudor Ambarus
2021-11-09  9:47   ` Michael Walle
2021-11-09  9:47     ` Michael Walle
2021-11-09 10:22     ` Tudor.Ambarus
2021-11-09 10:22       ` Tudor.Ambarus
2021-11-09 10:23       ` Tudor.Ambarus
2021-11-09 10:23         ` Tudor.Ambarus
2021-11-09 10:24       ` Michael Walle
2021-11-09 10:24         ` Michael Walle
2021-11-15 19:03   ` Pratyush Yadav
2021-11-15 19:03     ` Pratyush Yadav
2021-10-29 17:26 ` [PATCH v3 11/25] mtd: spi-nor: spansion: Use manufacturer late_init() Tudor Ambarus
2021-10-29 17:26   ` Tudor Ambarus
2021-11-09  9:48   ` Michael Walle
2021-11-09  9:48     ` Michael Walle
2021-11-15 19:06   ` Pratyush Yadav
2021-11-15 19:06     ` Pratyush Yadav
2021-10-29 17:26 ` [PATCH v3 12/25] mtd: spi-nor: core: Call spi_nor_post_sfdp_fixups() only when SFDP is defined Tudor Ambarus
2021-10-29 17:26   ` Tudor Ambarus
2021-11-09 10:18   ` Michael Walle
2021-11-09 10:18     ` Michael Walle
2021-10-29 17:26 ` [PATCH v3 13/25] mtd: spi-nor: sst: Get rid of SST_WRITE flash_info flag Tudor Ambarus
2021-10-29 17:26   ` Tudor Ambarus
2021-11-09 12:21   ` Michael Walle
2021-11-09 12:21     ` Michael Walle
2021-11-09 12:31     ` Tudor.Ambarus
2021-11-09 12:31       ` Tudor.Ambarus
2021-11-12 21:28       ` Michael Walle
2021-11-12 21:28         ` Michael Walle
2021-10-29 17:26 ` [PATCH v3 14/25] mtd: spi-nor: Introduce flash_info flags masks Tudor Ambarus
2021-10-29 17:26   ` Tudor Ambarus
2021-11-12 21:50   ` Michael Walle
2021-11-12 21:50     ` Michael Walle
2021-11-15  4:55     ` Tudor.Ambarus
2021-11-15  4:55       ` Tudor.Ambarus
2021-10-29 17:26 ` [PATCH v3 15/25] mtd: spi-nor: Introduce spi_nor_nonsfdp_init_flags() Tudor Ambarus
2021-10-29 17:26   ` Tudor Ambarus
2021-11-15 19:12   ` Pratyush Yadav
2021-11-15 19:12     ` Pratyush Yadav
2021-10-29 17:26 ` [PATCH v3 16/25] mtd: spi-nor: Introduce spi_nor_init_fixup_flags() Tudor Ambarus
2021-10-29 17:26   ` Tudor Ambarus
2021-11-16 10:57   ` Pratyush Yadav
2021-11-16 10:57     ` Pratyush Yadav
2021-10-29 17:26 ` [PATCH v3 17/25] mtd: spi-nor: core: Introduce SPI_NOR_PARSE_SFDP Tudor Ambarus
2021-10-29 17:26   ` Tudor Ambarus
2021-10-29 17:26 ` [PATCH v3 18/25] mtd: spi-nor: core: Init flash params based on SFDP first for new flash additions Tudor Ambarus
2021-10-29 17:26   ` Tudor Ambarus
2021-11-16 11:07   ` Pratyush Yadav
2021-11-16 11:07     ` Pratyush Yadav
2021-10-29 17:26 ` [PATCH v3 19/25] mtd: spi-nor: core: Move spi_nor_set_addr_width() in spi_nor_setup() Tudor Ambarus
2021-10-29 17:26   ` Tudor Ambarus
2021-11-12 21:53   ` Michael Walle
2021-11-12 21:53     ` Michael Walle
2021-10-29 17:26 ` [PATCH v3 20/25] mtd: spi-nor: sst: sst26vf064b: Init flash based on SFDP Tudor Ambarus
2021-10-29 17:26   ` Tudor Ambarus
2021-10-29 17:31   ` Tudor.Ambarus [this message]
2021-10-29 17:31     ` Tudor.Ambarus
2021-11-09 12:25     ` Michael Walle
2021-11-09 12:25       ` Michael Walle
2021-11-09 12:33       ` Tudor.Ambarus
2021-11-09 12:33         ` Tudor.Ambarus
2021-11-09 12:37         ` Michael Walle
2021-11-09 12:37           ` Michael Walle
2021-10-29 17:26 ` [PATCH v3 21/25] mtd: spi-nor: winbond: w25q256jvm: " Tudor Ambarus
2021-10-29 17:26   ` Tudor Ambarus
2021-10-29 17:31   ` Tudor.Ambarus
2021-10-29 17:31     ` Tudor.Ambarus
2021-10-29 17:26 ` [PATCH v3 22/25] mtd: spi-nor: spansion: s25fl256s0: Skip SFDP parsing Tudor Ambarus
2021-10-29 17:26   ` Tudor Ambarus
2021-10-29 17:26 ` [PATCH v3 23/25] mtd: spi-nor: gigadevice: gd25q256: Init flash based on SFDP Tudor Ambarus
2021-10-29 17:26   ` Tudor Ambarus
2021-10-29 17:33   ` Tudor.Ambarus
2021-10-29 17:33     ` Tudor.Ambarus
2021-10-29 17:26 ` [PATCH v3 24/25] mtd: spi-nor: issi: is25lp256: " Tudor Ambarus
2021-10-29 17:26   ` Tudor Ambarus
2021-10-29 17:33   ` Tudor.Ambarus
2021-10-29 17:33     ` Tudor.Ambarus
2021-10-29 17:26 ` [PATCH v3 25/25] mtd: spi-nor: macronix: mx25l25635e: " Tudor Ambarus
2021-10-29 17:26   ` Tudor Ambarus
2021-10-29 17:34   ` Tudor.Ambarus
2021-10-29 17:34     ` Tudor.Ambarus
2021-11-08 10:15 ` [PATCH v3 00/25] mtd: spi-nor: Clean params init Tudor.Ambarus
2021-11-08 10:15   ` Tudor.Ambarus
2021-11-08 10:31   ` Michael Walle
2021-11-08 10:31     ` Michael Walle
2021-11-16 11:36 ` Pratyush Yadav
2021-11-16 11:36   ` Pratyush Yadav
2021-11-16 11:56   ` Michael Walle
2021-11-16 11:56     ` Michael Walle
2021-11-17 13:17 ` (subset)[PATCH " Tudor Ambarus
2021-11-17 13:17   ` Tudor Ambarus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=11ac4016-94ad-39ce-e845-0324543065fa@microchip.com \
    --to=tudor.ambarus@microchip.com \
    --cc=Nicolas.Ferre@microchip.com \
    --cc=code@reto-schneider.ch \
    --cc=esben@geanix.com \
    --cc=heiko.thiery@gmail.com \
    --cc=jaimeliao@mxic.com.tw \
    --cc=knaerzche@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linux@rasmusvillemoes.dk \
    --cc=macromorgan@hotmail.com \
    --cc=mail@david-bauer.net \
    --cc=michael@walle.cc \
    --cc=miquel.raynal@bootlin.com \
    --cc=p.yadav@ti.com \
    --cc=richard@nod.at \
    --cc=sr@denx.de \
    --cc=vigneshr@ti.com \
    --cc=zhengxunli@mxic.com.tw \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.