From: Peter Zijlstra <peterz@infradead.org>
To: Mark Langsdorf <mark.langsdorf@amd.com>
Cc: Joerg Roedel <joerg.roedel@amd.com>,
avi@redhat.com, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH][KVM][retry 3] Add support for Pause Filtering to AMD SVM
Date: Wed, 20 May 2009 09:59:46 +0200 [thread overview]
Message-ID: <1242806386.26820.549.camel@twins> (raw)
In-Reply-To: <200905191356.37071.mark.langsdorf@amd.com>
On Tue, 2009-05-19 at 13:56 -0500, Mark Langsdorf wrote:
> @@ -1947,6 +1947,11 @@ task_hot(struct task_struct *p, u64 now, struct sched_domain *sd)
> return delta < (s64)sysctl_sched_migration_cost;
> }
>
> +void set_task_delay(struct task_struct *p, unsigned int delay)
> +{
> + p->se.vruntime += delay;
> +}
> +EXPORT_SYMBOL(set_task_delay);
That's broken, you cannot assume that a task is SCHED_OTHER like that.
Furthermore, you cannot simply change vruntime of any odd task, this
only works for current. Also, you really need to call schedule() after
doing this for it to have any immediate effect.
Also, if you mean delay to be ns, you need to scale it. Furthermore, I
would really really want to export this as GPL only (ok, preferably not
at all).
That said, I still thoroughly dislike this whole approach.
/*
* Dumb broken yield like interface -- use at your own peril and know
* RT people will hate you.
*
* Like yield, except for SCHED_OTHER/BATCH, where it will give up @ns
* time for the 'good' cause.
*/
void sched_delay_yield(unsigned long ns)
{
struct task_struct *curr = current;
if (curr->sched_class == &fair_sched_class) {
struct sched_entity *se = &curr->se;
__update_curr(cfs_rq_of(se), se, ns);
schedule();
/* XXX: task accounting ? */
} else
sched_yield();
}
EXPORT_SYMBOL_GPL(sched_delay_yield);
WARNING: multiple messages have this Message-ID (diff)
From: Peter Zijlstra <peterz@infradead.org>
To: Mark Langsdorf <mark.langsdorf@amd.com>
Cc: Joerg Roedel <joerg.roedel@amd.com>,
avi@redhat.com, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH][retry 3] Add support for Pause Filtering to AMD SVM
Date: Wed, 20 May 2009 09:59:46 +0200 [thread overview]
Message-ID: <1242806386.26820.549.camel@twins> (raw)
In-Reply-To: <200905191356.37071.mark.langsdorf@amd.com>
On Tue, 2009-05-19 at 13:56 -0500, Mark Langsdorf wrote:
> @@ -1947,6 +1947,11 @@ task_hot(struct task_struct *p, u64 now, struct sched_domain *sd)
> return delta < (s64)sysctl_sched_migration_cost;
> }
>
> +void set_task_delay(struct task_struct *p, unsigned int delay)
> +{
> + p->se.vruntime += delay;
> +}
> +EXPORT_SYMBOL(set_task_delay);
That's broken, you cannot assume that a task is SCHED_OTHER like that.
Furthermore, you cannot simply change vruntime of any odd task, this
only works for current. Also, you really need to call schedule() after
doing this for it to have any immediate effect.
Also, if you mean delay to be ns, you need to scale it. Furthermore, I
would really really want to export this as GPL only (ok, preferably not
at all).
That said, I still thoroughly dislike this whole approach.
/*
* Dumb broken yield like interface -- use at your own peril and know
* RT people will hate you.
*
* Like yield, except for SCHED_OTHER/BATCH, where it will give up @ns
* time for the 'good' cause.
*/
void sched_delay_yield(unsigned long ns)
{
struct task_struct *curr = current;
if (curr->sched_class == &fair_sched_class) {
struct sched_entity *se = &curr->se;
__update_curr(cfs_rq_of(se), se, ns);
schedule();
/* XXX: task accounting ? */
} else
sched_yield();
}
EXPORT_SYMBOL_GPL(sched_delay_yield);
next prev parent reply other threads:[~2009-05-20 7:59 UTC|newest]
Thread overview: 79+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-05 14:09 [PATCH][KVM] Add support for Pause Filtering to AMD SVM Mark Langsdorf
2009-05-05 16:05 ` Bert Wesarg
2009-05-07 13:55 ` Joerg Roedel
2009-05-07 15:00 ` [PATCH][KVM][retry 1] " Mark Langsdorf
2009-05-07 15:00 ` [PATCH][retry " Mark Langsdorf
2009-05-07 15:31 ` [PATCH][KVM][retry " Avi Kivity
2009-05-11 14:15 ` Ingo Molnar
2009-05-11 14:15 ` [PATCH][retry " Ingo Molnar
2009-05-11 14:24 ` [PATCH][KVM][retry " Avi Kivity
2009-05-11 14:24 ` [PATCH][retry " Avi Kivity
2009-05-11 14:33 ` [PATCH][KVM][retry " Ingo Molnar
2009-05-11 14:33 ` [PATCH][retry " Ingo Molnar
2009-05-11 14:51 ` [PATCH][KVM][retry " Avi Kivity
2009-05-11 14:51 ` [PATCH][retry " Avi Kivity
2009-05-11 14:59 ` [PATCH][KVM][retry " Ingo Molnar
2009-05-11 14:59 ` [PATCH][retry " Ingo Molnar
2009-05-11 15:12 ` [PATCH][KVM][retry " Avi Kivity
2009-05-11 15:12 ` [PATCH][retry " Avi Kivity
2009-05-11 15:18 ` [PATCH][KVM][retry " Ingo Molnar
2009-05-11 15:18 ` [PATCH][retry " Ingo Molnar
2009-05-11 15:28 ` [PATCH][KVM][retry " Avi Kivity
2009-05-11 15:28 ` [PATCH][retry " Avi Kivity
2009-05-11 15:36 ` [PATCH][KVM][retry " Langsdorf, Mark
2009-05-11 15:36 ` [PATCH][retry " Langsdorf, Mark
2009-05-11 15:40 ` [PATCH][KVM][retry " Avi Kivity
2009-05-11 15:58 ` [PATCH][KVM][retry 1] Add support for Pause Filtering to AMDSVM Langsdorf, Mark
2009-05-11 15:58 ` [PATCH][retry " Langsdorf, Mark
2009-05-11 15:01 ` [PATCH][KVM][retry 1] Add support for Pause Filtering to AMD SVM Peter Zijlstra
2009-05-11 15:01 ` [PATCH][retry " Peter Zijlstra
2009-05-11 15:06 ` [PATCH][KVM][retry " Avi Kivity
2009-05-11 15:06 ` [PATCH][retry " Avi Kivity
2009-05-11 14:42 ` [PATCH][KVM][retry " Peter Zijlstra
2009-05-11 15:05 ` Avi Kivity
2009-05-11 15:05 ` [PATCH][retry " Avi Kivity
2009-05-08 17:03 ` [PATCH][KVM][retry 2] " Mark Langsdorf
2009-05-08 17:03 ` [PATCH][retry " Mark Langsdorf
2009-05-08 18:44 ` [PATCH][KVM][retry " Avi Kivity
2009-05-08 18:44 ` [PATCH][retry " Avi Kivity
2009-05-08 18:47 ` [PATCH][KVM][retry " Langsdorf, Mark
2009-05-08 18:47 ` [PATCH][retry " Langsdorf, Mark
2009-05-19 18:56 ` [PATCH][KVM][retry 3] " Mark Langsdorf
2009-05-19 18:56 ` [PATCH][retry " Mark Langsdorf
2009-05-20 7:40 ` [PATCH][KVM][retry " Ingo Molnar
2009-05-20 7:59 ` Peter Zijlstra [this message]
2009-05-20 7:59 ` [PATCH][retry " Peter Zijlstra
2009-05-20 8:38 ` [PATCH][KVM][retry " Avi Kivity
2009-05-20 8:38 ` [PATCH][retry " Avi Kivity
2009-05-20 8:42 ` [PATCH][KVM][retry " Peter Zijlstra
2009-05-20 8:42 ` [PATCH][retry " Peter Zijlstra
2009-05-20 8:49 ` [PATCH][KVM][retry " Avi Kivity
2009-05-20 8:49 ` [PATCH][retry " Avi Kivity
2009-05-20 8:54 ` [PATCH][KVM][retry " Peter Zijlstra
2009-05-20 8:54 ` [PATCH][retry " Peter Zijlstra
2009-05-20 9:04 ` [PATCH][KVM][retry " Avi Kivity
2009-05-20 9:04 ` [PATCH][retry " Avi Kivity
2009-05-20 9:10 ` [PATCH][KVM][retry " Peter Zijlstra
2009-05-20 9:10 ` [PATCH][retry " Peter Zijlstra
2009-05-20 9:17 ` [PATCH][KVM][retry " Avi Kivity
2009-05-20 9:17 ` [PATCH][retry " Avi Kivity
2009-05-20 13:52 ` [PATCH][KVM][retry " Langsdorf, Mark
2009-05-20 13:52 ` [PATCH][retry " Langsdorf, Mark
2009-05-20 12:00 ` [PATCH][KVM][retry " Avi Kivity
2009-05-20 12:00 ` [PATCH][retry " Avi Kivity
2009-05-20 22:25 ` [PATCH][KVM][retry 4] " Mark Langsdorf
2009-05-20 22:25 ` [PATCH][retry " Mark Langsdorf
2009-05-21 8:47 ` [PATCH][KVM][retry " Avi Kivity
2009-05-21 8:47 ` [PATCH][retry " Avi Kivity
2009-07-08 5:19 ` [PATCH][KVM][retry " Sheng Yang
2009-07-08 5:19 ` [PATCH][retry " Sheng Yang
2009-07-08 14:59 ` [PATCH][KVM][retry " Langsdorf, Mark
2009-07-08 14:59 ` [PATCH][retry " Langsdorf, Mark
2009-07-09 1:50 ` [PATCH][KVM][retry " Sheng Yang
2009-07-09 1:50 ` [PATCH][retry " Sheng Yang
2009-07-22 22:40 ` [PATCH][KVM][retry " Langsdorf, Mark
2009-07-22 22:40 ` [PATCH][retry " Langsdorf, Mark
2009-08-05 9:08 ` [PATCH][KVM][retry " Zhai, Edwin
2009-08-05 9:08 ` [PATCH][retry " Zhai, Edwin
2009-05-11 14:38 ` [PATCH][KVM] " Peter Zijlstra
2009-05-11 14:51 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1242806386.26820.549.camel@twins \
--to=peterz@infradead.org \
--cc=avi@redhat.com \
--cc=joerg.roedel@amd.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.langsdorf@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.