All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kever Yang <kever.yang@rock-chips.com>
To: Jagan Teki <jagan@amarulasolutions.com>
Cc: U-Boot-Denx <u-boot@lists.denx.de>,
	linux-rockchip@lists.infradead.org,
	Akash Gajjar <akash@openedev.com>,
	linux-amarula@amarulasolutions.com
Subject: Re: [PATCH v2 09/14] rockchip: rk3399: Add 4GB LPDDR3-1866 DMC settings【请注意,邮件由linux-rockchip-bounces+kever.yang=rock-chips.com@lists.infradead.org代发】
Date: Thu, 18 Apr 2019 10:57:06 +0800	[thread overview]
Message-ID: <12b48e92-be80-3600-6ab2-2c0d4c132603@rock-chips.com> (raw)
In-Reply-To: <CAMty3ZC4fm7GtH91ztdyaozh8v-xpMGa23KhR_GCoZ9saCeknQ@mail.gmail.com>

Hi Jagan,


On 04/17/2019 07:11 PM, Jagan Teki wrote:
> On Wed, Apr 17, 2019 at 1:10 PM Kever Yang <kever.yang@rock-chips.com> wrote:
>> Hi Jagan,
>>
>>
>> On 04/16/2019 06:56 PM, Jagan Teki wrote:
>>> Add sdram dtsi file for 4GB LPDDR3-1866 DMC settings by reverse
>>> engineered from the rk3399_ddr_933Mhz_v1.14.bin file.
>>>
>>> Full credits to 'Liviu Dudau' who is the real author for this change.
>>>
>>> Signed-off-by: Liviu Dudau <liviu@dudau.co.uk>
>>> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
>>> ---
>>>  .../arm/dts/rk3399-sdram-lpddr3-4GB-1866.dtsi | 1535 +++++++++++++++++
>> Could you use rk3399-sdram-lpddr3-samsung-4GB-1866.dtsi directly?
>> I think it should able to work.
> I supposed to take the same, but thought that it would be some samsung
> specific setting. but seems like it is nearly same and it worked. will
> update to use this. thanks!

I have check with rockchip dram driver owner, this setting is more generic
while the -samsung- dtsi is more for dedicate chromebook.
So I think we can merge this patch for other boards who using Rockchip
reference design.

Reviewed-by: Kever Yang <kever.yang@rock-chips.com>

Thanks,
- Kever



_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

WARNING: multiple messages have this Message-ID (diff)
From: Kever Yang <kever.yang@rock-chips.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 09/14] rockchip: rk3399: Add 4GB LPDDR3-1866 DMC settings【请注意,邮件由linux-rockchip-bounces+kever.yang=rock-chips.com@lists.infradead.org代发】
Date: Thu, 18 Apr 2019 10:57:06 +0800	[thread overview]
Message-ID: <12b48e92-be80-3600-6ab2-2c0d4c132603@rock-chips.com> (raw)
In-Reply-To: <CAMty3ZC4fm7GtH91ztdyaozh8v-xpMGa23KhR_GCoZ9saCeknQ@mail.gmail.com>

Hi Jagan,


On 04/17/2019 07:11 PM, Jagan Teki wrote:
> On Wed, Apr 17, 2019 at 1:10 PM Kever Yang <kever.yang@rock-chips.com> wrote:
>> Hi Jagan,
>>
>>
>> On 04/16/2019 06:56 PM, Jagan Teki wrote:
>>> Add sdram dtsi file for 4GB LPDDR3-1866 DMC settings by reverse
>>> engineered from the rk3399_ddr_933Mhz_v1.14.bin file.
>>>
>>> Full credits to 'Liviu Dudau' who is the real author for this change.
>>>
>>> Signed-off-by: Liviu Dudau <liviu@dudau.co.uk>
>>> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
>>> ---
>>>  .../arm/dts/rk3399-sdram-lpddr3-4GB-1866.dtsi | 1535 +++++++++++++++++
>> Could you use rk3399-sdram-lpddr3-samsung-4GB-1866.dtsi directly?
>> I think it should able to work.
> I supposed to take the same, but thought that it would be some samsung
> specific setting. but seems like it is nearly same and it worked. will
> update to use this. thanks!

I have check with rockchip dram driver owner, this setting is more generic
while the -samsung- dtsi is more for dedicate chromebook.
So I think we can merge this patch for other boards who using Rockchip
reference design.

Reviewed-by: Kever Yang <kever.yang@rock-chips.com>

Thanks,
- Kever

  reply	other threads:[~2019-04-18  2:57 UTC|newest]

Thread overview: 68+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-16 10:56 [PATCH v2 00/14] rockchip: Add new rk3399 boards Jagan Teki
2019-04-16 10:56 ` [U-Boot] " Jagan Teki
     [not found] ` <20190416105647.18437-1-jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org>
2019-04-16 10:56   ` [PATCH v2 01/14] rockchip: dts: rk3399: Sync rk3399-opp from Linux Jagan Teki
2019-04-16 10:56     ` [U-Boot] " Jagan Teki
     [not found]     ` <20190416105647.18437-2-jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org>
2019-04-16 11:59       ` Paul Kocialkowski
2019-04-16 11:59         ` Paul Kocialkowski
2019-04-16 10:56   ` [PATCH v2 02/14] rockchip: dts: rk3399: Sync pwm2_pin_pull_down from Linux 5.1-rc2 Jagan Teki
2019-04-16 10:56     ` [U-Boot] " Jagan Teki
     [not found]     ` <20190416105647.18437-3-jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org>
2019-04-16 12:00       ` Paul Kocialkowski
2019-04-16 12:00         ` Paul Kocialkowski
2019-04-16 10:56   ` [PATCH v2 03/14] rockchip: dts: rk3399: Create initial rk3399-u-boot.dtsi Jagan Teki
2019-04-16 10:56     ` [U-Boot] " Jagan Teki
     [not found]     ` <20190416105647.18437-4-jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org>
2019-04-16 12:00       ` Paul Kocialkowski
2019-04-16 12:00         ` Paul Kocialkowski
2019-04-16 10:56   ` [PATCH v2 04/14] Kconfig: Add default SPL_FIT_GENERATOR for rockchip Jagan Teki
2019-04-16 10:56     ` [U-Boot] " Jagan Teki
     [not found]     ` <20190416105647.18437-5-jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org>
2019-04-16 12:01       ` Paul Kocialkowski
2019-04-16 12:01         ` Paul Kocialkowski
2019-04-16 10:56   ` [PATCH v2 05/14] arm: rockchip: rk3399: Move common configs in Kconfig Jagan Teki
2019-04-16 10:56     ` [U-Boot] " Jagan Teki
     [not found]     ` <20190416105647.18437-6-jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org>
2019-04-16 12:02       ` Paul Kocialkowski
2019-04-16 12:02         ` Paul Kocialkowski
2019-04-16 10:56   ` [PATCH v2 06/14] rockchip: rk3399: Add Orangepi RK3399 support Jagan Teki
2019-04-16 10:56     ` [U-Boot] " Jagan Teki
     [not found]     ` <20190416105647.18437-7-jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org>
2019-04-16 12:03       ` Paul Kocialkowski
2019-04-16 12:03         ` Paul Kocialkowski
2019-04-16 10:56   ` [PATCH v2 07/14] rockchip: dts: rk3399: Sync rk3399-nanopi4.dtsi from Linux Jagan Teki
2019-04-16 10:56     ` [U-Boot] " Jagan Teki
     [not found]     ` <20190416105647.18437-8-jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org>
2019-04-16 12:04       ` Paul Kocialkowski
2019-04-16 12:04         ` Paul Kocialkowski
2019-04-16 10:56   ` [PATCH v2 08/14] rockchip: dts: rk3399: nanopi4: Use CD pin as RK_FUNC_1 Jagan Teki
2019-04-16 10:56     ` [U-Boot] " Jagan Teki
     [not found]     ` <20190416105647.18437-9-jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org>
2019-04-16 11:10       ` Robin Murphy
2019-04-16 11:10         ` [U-Boot] " Robin Murphy
     [not found]         ` <148886f2-b1f2-8e90-c6cc-00fd49d98c86-5wv7dgnIgG8@public.gmane.org>
2019-04-17 11:09           ` Jagan Teki
2019-04-17 11:09             ` [U-Boot] " Jagan Teki
2019-04-16 10:56   ` [PATCH v2 09/14] rockchip: rk3399: Add 4GB LPDDR3-1866 DMC settings Jagan Teki
2019-04-16 10:56     ` [U-Boot] " Jagan Teki
2019-04-17  7:40     ` [PATCH v2 09/14] rockchip: rk3399: Add 4GB LPDDR3-1866 DMC settings【请注意,邮件由linux-rockchip-bounces+kever.yang=rock-chips.com@lists.infradead.org代发】 Kever Yang
2019-04-17  7:40       ` [U-Boot] " Kever Yang
2019-04-17 11:11       ` Jagan Teki
2019-04-17 11:11         ` [U-Boot] " Jagan Teki
2019-04-18  2:57         ` Kever Yang [this message]
2019-04-18  2:57           ` Kever Yang
     [not found]           ` <12b48e92-be80-3600-6ab2-2c0d4c132603-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2019-04-18  6:30             ` Philipp Tomsich
2019-04-18  6:30               ` [U-Boot] " Philipp Tomsich
2019-04-16 10:56   ` [PATCH v2 10/14] rockchip: rk3399: Add Nanopi M4 board support Jagan Teki
2019-04-16 10:56     ` [U-Boot] " Jagan Teki
     [not found]     ` <20190416105647.18437-11-jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org>
2019-04-16 12:04       ` Paul Kocialkowski
2019-04-16 12:04         ` Paul Kocialkowski
2019-04-16 10:56   ` [PATCH v2 11/14] rockchip: rk3399: Add Nanopc T4 " Jagan Teki
2019-04-16 10:56     ` [U-Boot] " Jagan Teki
     [not found]     ` <20190416105647.18437-12-jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org>
2019-04-16 12:05       ` Paul Kocialkowski
2019-04-16 12:05         ` Paul Kocialkowski
2019-04-16 10:56   ` [PATCH v2 12/14] rockchip: rk3399: Add Nanopi NEO4 " Jagan Teki
2019-04-16 10:56     ` [U-Boot] " Jagan Teki
     [not found]     ` <20190416105647.18437-13-jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org>
2019-04-16 12:06       ` Paul Kocialkowski
2019-04-16 12:06         ` Paul Kocialkowski
2019-04-16 10:56   ` [PATCH v2 13/14] rockchip: rk3399: Add Rockpro64 " Jagan Teki
2019-04-16 10:56     ` [U-Boot] " Jagan Teki
     [not found]     ` <20190416105647.18437-14-jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org>
2019-04-16 12:07       ` Paul Kocialkowski
2019-04-16 12:07         ` [U-Boot] " Paul Kocialkowski
2019-04-16 10:56   ` [PATCH v2 14/14] doc: rockchip: Add global doc for rk3399 build/flash Jagan Teki
2019-04-16 10:56     ` [U-Boot] " Jagan Teki
2019-04-16 11:58 ` [PATCH v2 00/14] rockchip: Add new rk3399 boards Paul Kocialkowski
2019-04-16 11:58   ` [U-Boot] " Paul Kocialkowski
2019-04-17 11:19   ` Jagan Teki
2019-04-17 11:19     ` [U-Boot] " Jagan Teki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=12b48e92-be80-3600-6ab2-2c0d4c132603@rock-chips.com \
    --to=kever.yang@rock-chips.com \
    --cc=akash@openedev.com \
    --cc=jagan@amarulasolutions.com \
    --cc=linux-amarula@amarulasolutions.com \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.