From: Rob Herring <robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org
Cc: Rob Herring <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>
Subject: [PATCH 1/2] dt: check for devices already created fron DT scan
Date: Thu, 19 May 2011 13:28:23 -0500 [thread overview]
Message-ID: <1305829704-11774-2-git-send-email-robherring2@gmail.com> (raw)
In-Reply-To: <1305829704-11774-1-git-send-email-robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
From: Rob Herring <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>
of_platform_bus_create may create duplicate devices if already
added when scanning other buses like amba bus.
Signed-off-by: Rob Herring <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>
---
drivers/of/platform.c | 8 ++++++++
1 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/drivers/of/platform.c b/drivers/of/platform.c
index 9b785be..7bf74fb 100644
--- a/drivers/of/platform.c
+++ b/drivers/of/platform.c
@@ -234,6 +234,13 @@ static int of_platform_bus_create(struct device_node *bus,
return 0;
}
+ /* Has the device already been registered? */
+ if (of_find_device_by_node(bus)) {
+ pr_debug("%s() - skipping %s, already registered\n",
+ __func__, bus->full_name);
+ return 0;
+ }
+
dev = of_platform_device_create(bus, NULL, parent);
if (!dev || !of_match_node(matches, bus))
return 0;
@@ -326,4 +333,5 @@ int of_platform_populate(struct device_node *root,
of_node_put(root);
return rc;
}
+EXPORT_SYMBOL(of_platform_populate);
#endif /* !CONFIG_SPARC */
--
1.7.4.1
WARNING: multiple messages have this Message-ID (diff)
From: robherring2@gmail.com (Rob Herring)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] dt: check for devices already created fron DT scan
Date: Thu, 19 May 2011 13:28:23 -0500 [thread overview]
Message-ID: <1305829704-11774-2-git-send-email-robherring2@gmail.com> (raw)
In-Reply-To: <1305829704-11774-1-git-send-email-robherring2@gmail.com>
From: Rob Herring <rob.herring@calxeda.com>
of_platform_bus_create may create duplicate devices if already
added when scanning other buses like amba bus.
Signed-off-by: Rob Herring <rob.herring@calxeda.com>
---
drivers/of/platform.c | 8 ++++++++
1 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/drivers/of/platform.c b/drivers/of/platform.c
index 9b785be..7bf74fb 100644
--- a/drivers/of/platform.c
+++ b/drivers/of/platform.c
@@ -234,6 +234,13 @@ static int of_platform_bus_create(struct device_node *bus,
return 0;
}
+ /* Has the device already been registered? */
+ if (of_find_device_by_node(bus)) {
+ pr_debug("%s() - skipping %s, already registered\n",
+ __func__, bus->full_name);
+ return 0;
+ }
+
dev = of_platform_device_create(bus, NULL, parent);
if (!dev || !of_match_node(matches, bus))
return 0;
@@ -326,4 +333,5 @@ int of_platform_populate(struct device_node *root,
of_node_put(root);
return rc;
}
+EXPORT_SYMBOL(of_platform_populate);
#endif /* !CONFIG_SPARC */
--
1.7.4.1
next prev parent reply other threads:[~2011-05-19 18:28 UTC|newest]
Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-19 18:28 [PATCH v2 0/2] amba bus device tree probing Rob Herring
2011-05-19 18:28 ` Rob Herring
[not found] ` <1305829704-11774-1-git-send-email-robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2011-05-19 18:28 ` Rob Herring [this message]
2011-05-19 18:28 ` [PATCH 1/2] dt: check for devices already created fron DT scan Rob Herring
[not found] ` <1305829704-11774-2-git-send-email-robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2011-05-19 19:54 ` Grant Likely
2011-05-19 19:54 ` Grant Likely
2011-05-19 18:28 ` [PATCH 2/2] drivers/amba: probe via device tree Rob Herring
2011-05-19 18:28 ` Rob Herring
[not found] ` <1305829704-11774-3-git-send-email-robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2011-05-19 20:01 ` Grant Likely
2011-05-19 20:01 ` Grant Likely
[not found] ` <20110519200158.GW5109-e0URQFbLeQY2iJbIjFUEsiwD8/FfD2ys@public.gmane.org>
2011-05-19 23:30 ` Rob Herring
2011-05-19 23:30 ` Rob Herring
2011-05-19 23:39 ` Grant Likely
2011-05-19 23:39 ` Grant Likely
[not found] ` <20110519233958.GB18181-e0URQFbLeQY2iJbIjFUEsiwD8/FfD2ys@public.gmane.org>
2011-05-20 13:24 ` Rob Herring
2011-05-20 13:24 ` Rob Herring
[not found] ` <4DD66B8A.5040404-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2011-05-20 14:21 ` Arnd Bergmann
2011-05-20 14:21 ` Arnd Bergmann
[not found] ` <201105201621.03801.arnd-r2nGTMty4D4@public.gmane.org>
2011-05-20 15:17 ` Rob Herring
2011-05-20 15:17 ` Rob Herring
[not found] ` <4DD68614.6090209-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2011-05-20 16:08 ` Stephen Neuendorffer
2011-05-20 16:08 ` Stephen Neuendorffer
2011-05-21 17:42 ` Grant Likely
2011-05-21 17:42 ` Grant Likely
2011-05-21 23:47 ` Russell King - ARM Linux
2011-05-21 23:47 ` Russell King - ARM Linux
2011-05-21 23:47 ` Russell King - ARM Linux
2011-05-22 10:00 ` Rafael J. Wysocki
2011-05-22 10:00 ` Rafael J. Wysocki
2011-05-22 10:00 ` Rafael J. Wysocki
2011-05-22 15:46 ` Rob Herring
2011-05-22 15:46 ` Rob Herring
2011-05-22 15:46 ` Rob Herring
2011-05-23 15:23 ` Grant Likely
2011-05-23 15:23 ` Grant Likely
2011-05-22 10:03 ` Arnd Bergmann
2011-05-22 10:03 ` Arnd Bergmann
2011-05-22 10:03 ` Arnd Bergmann
2011-05-25 9:03 ` Linus Walleij
2011-05-25 9:03 ` Linus Walleij
2011-05-23 9:37 ` Kristoffer Glembo
2011-05-23 9:37 ` Kristoffer Glembo
2011-05-23 9:37 ` Kristoffer Glembo
2011-05-23 9:58 ` Russell King - ARM Linux
2011-05-23 9:58 ` Russell King - ARM Linux
2011-05-23 15:09 ` Grant Likely
2011-05-23 15:09 ` Grant Likely
2011-05-23 15:09 ` Grant Likely
2011-05-24 15:03 ` Rob Herring
2011-05-24 15:03 ` Rob Herring
2011-05-24 15:03 ` Rob Herring
2011-05-25 3:02 ` Shawn Guo
2011-05-25 3:02 ` Shawn Guo
2011-05-25 3:02 ` Shawn Guo
2011-05-25 9:07 ` Linus Walleij
2011-05-25 9:07 ` Linus Walleij
[not found] ` <a42f0c27-2811-4b68-bedf-7dfaa7bff6ff-+Ck8Kgl/v0/6UOWq+LNw4LjjLBE8jN/0@public.gmane.org>
2011-05-21 23:35 ` Russell King - ARM Linux
2011-05-21 23:35 ` Russell King - ARM Linux
[not found] ` <20110521233558.GA17672-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org>
2011-05-23 15:00 ` Stephen Neuendorffer
2011-05-23 15:00 ` Stephen Neuendorffer
[not found] ` <1007bcf2-7786-4f03-bff7-8d8af83939f1-+Ck8Kgl/v0+GljRhoabY2LjjLBE8jN/0@public.gmane.org>
2011-05-23 15:47 ` Russell King - ARM Linux
2011-05-23 15:47 ` Russell King - ARM Linux
2011-05-21 4:00 ` Segher Boessenkool
2011-05-21 4:00 ` Segher Boessenkool
[not found] ` <80f20ac921a33e9f0bf3e249f539a8ef-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org>
2011-05-21 14:55 ` Rob Herring
2011-05-21 14:55 ` Rob Herring
[not found] ` <4DD7D24D.2070604-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2011-05-21 15:18 ` Segher Boessenkool
2011-05-21 15:18 ` Segher Boessenkool
[not found] ` <ad5605c2a3d4b36f63f36f52afe89cfd-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org>
2011-05-21 17:43 ` Grant Likely
2011-05-21 17:43 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1305829704-11774-2-git-send-email-robherring2@gmail.com \
--to=robherring2-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
--cc=grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.