From: Linus Walleij <linus.walleij@linaro.org>
To: Rob Herring <robherring2@gmail.com>
Cc: Grant Likely <grant.likely@secretlab.ca>,
Russell King - ARM Linux <linux@arm.linux.org.uk>,
Kevin Hilman <khilman@ti.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"Rafael J. Wysocki" <rjw@sisk.pl>,
Jeremy Kerr <jeremy.kerr@canonical.com>,
devicetree-discuss@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/2] drivers/amba: probe via device tree
Date: Wed, 25 May 2011 11:07:18 +0200 [thread overview]
Message-ID: <BANLkTin4xKHbxysxN8M-5AP2143VkoLG=g@mail.gmail.com> (raw)
In-Reply-To: <4DDBC8C7.4000001@gmail.com>
2011/5/24 Rob Herring <robherring2@gmail.com>:
> I think having "arm,amba-deviceid" is not needed. The current code does
> nothing but warn if it doesn't match the h/w value. The drivers already have
> a list of id's that they support and the amba bus only matches against the
> h/w id value. The only use I can see is overriding a broken h/w value.
We have this usecase in the Ux500. See these patches:
http://www.arm.linux.org.uk/developer/patches/viewpatch.php?id=6829/1
http://www.arm.linux.org.uk/developer/patches/viewpatch.php?id=6830/1
Alas, it's not yet merged for the old boardfile world usecase, and
causing us problems to drive our hardware already.
Yours,
Linus Walleij
WARNING: multiple messages have this Message-ID (diff)
From: linus.walleij@linaro.org (Linus Walleij)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] drivers/amba: probe via device tree
Date: Wed, 25 May 2011 11:07:18 +0200 [thread overview]
Message-ID: <BANLkTin4xKHbxysxN8M-5AP2143VkoLG=g@mail.gmail.com> (raw)
In-Reply-To: <4DDBC8C7.4000001@gmail.com>
2011/5/24 Rob Herring <robherring2@gmail.com>:
> I think having "arm,amba-deviceid" is not needed. The current code does
> nothing but warn if it doesn't match the h/w value. The drivers already have
> a list of id's that they support and the amba bus only matches against the
> h/w id value. The only use I can see is overriding a broken h/w value.
We have this usecase in the Ux500. See these patches:
http://www.arm.linux.org.uk/developer/patches/viewpatch.php?id=6829/1
http://www.arm.linux.org.uk/developer/patches/viewpatch.php?id=6830/1
Alas, it's not yet merged for the old boardfile world usecase, and
causing us problems to drive our hardware already.
Yours,
Linus Walleij
next prev parent reply other threads:[~2011-05-25 9:07 UTC|newest]
Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-19 18:28 [PATCH v2 0/2] amba bus device tree probing Rob Herring
2011-05-19 18:28 ` Rob Herring
[not found] ` <1305829704-11774-1-git-send-email-robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2011-05-19 18:28 ` [PATCH 1/2] dt: check for devices already created fron DT scan Rob Herring
2011-05-19 18:28 ` Rob Herring
[not found] ` <1305829704-11774-2-git-send-email-robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2011-05-19 19:54 ` Grant Likely
2011-05-19 19:54 ` Grant Likely
2011-05-19 18:28 ` [PATCH 2/2] drivers/amba: probe via device tree Rob Herring
2011-05-19 18:28 ` Rob Herring
[not found] ` <1305829704-11774-3-git-send-email-robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2011-05-19 20:01 ` Grant Likely
2011-05-19 20:01 ` Grant Likely
[not found] ` <20110519200158.GW5109-e0URQFbLeQY2iJbIjFUEsiwD8/FfD2ys@public.gmane.org>
2011-05-19 23:30 ` Rob Herring
2011-05-19 23:30 ` Rob Herring
2011-05-19 23:39 ` Grant Likely
2011-05-19 23:39 ` Grant Likely
[not found] ` <20110519233958.GB18181-e0URQFbLeQY2iJbIjFUEsiwD8/FfD2ys@public.gmane.org>
2011-05-20 13:24 ` Rob Herring
2011-05-20 13:24 ` Rob Herring
[not found] ` <4DD66B8A.5040404-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2011-05-20 14:21 ` Arnd Bergmann
2011-05-20 14:21 ` Arnd Bergmann
[not found] ` <201105201621.03801.arnd-r2nGTMty4D4@public.gmane.org>
2011-05-20 15:17 ` Rob Herring
2011-05-20 15:17 ` Rob Herring
[not found] ` <4DD68614.6090209-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2011-05-20 16:08 ` Stephen Neuendorffer
2011-05-20 16:08 ` Stephen Neuendorffer
2011-05-21 17:42 ` Grant Likely
2011-05-21 17:42 ` Grant Likely
2011-05-21 23:47 ` Russell King - ARM Linux
2011-05-21 23:47 ` Russell King - ARM Linux
2011-05-21 23:47 ` Russell King - ARM Linux
2011-05-22 10:00 ` Rafael J. Wysocki
2011-05-22 10:00 ` Rafael J. Wysocki
2011-05-22 10:00 ` Rafael J. Wysocki
2011-05-22 15:46 ` Rob Herring
2011-05-22 15:46 ` Rob Herring
2011-05-22 15:46 ` Rob Herring
2011-05-23 15:23 ` Grant Likely
2011-05-23 15:23 ` Grant Likely
2011-05-22 10:03 ` Arnd Bergmann
2011-05-22 10:03 ` Arnd Bergmann
2011-05-22 10:03 ` Arnd Bergmann
2011-05-25 9:03 ` Linus Walleij
2011-05-25 9:03 ` Linus Walleij
2011-05-23 9:37 ` Kristoffer Glembo
2011-05-23 9:37 ` Kristoffer Glembo
2011-05-23 9:37 ` Kristoffer Glembo
2011-05-23 9:58 ` Russell King - ARM Linux
2011-05-23 9:58 ` Russell King - ARM Linux
2011-05-23 15:09 ` Grant Likely
2011-05-23 15:09 ` Grant Likely
2011-05-23 15:09 ` Grant Likely
2011-05-24 15:03 ` Rob Herring
2011-05-24 15:03 ` Rob Herring
2011-05-24 15:03 ` Rob Herring
2011-05-25 3:02 ` Shawn Guo
2011-05-25 3:02 ` Shawn Guo
2011-05-25 3:02 ` Shawn Guo
2011-05-25 9:07 ` Linus Walleij [this message]
2011-05-25 9:07 ` Linus Walleij
[not found] ` <a42f0c27-2811-4b68-bedf-7dfaa7bff6ff-+Ck8Kgl/v0/6UOWq+LNw4LjjLBE8jN/0@public.gmane.org>
2011-05-21 23:35 ` Russell King - ARM Linux
2011-05-21 23:35 ` Russell King - ARM Linux
[not found] ` <20110521233558.GA17672-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org>
2011-05-23 15:00 ` Stephen Neuendorffer
2011-05-23 15:00 ` Stephen Neuendorffer
[not found] ` <1007bcf2-7786-4f03-bff7-8d8af83939f1-+Ck8Kgl/v0+GljRhoabY2LjjLBE8jN/0@public.gmane.org>
2011-05-23 15:47 ` Russell King - ARM Linux
2011-05-23 15:47 ` Russell King - ARM Linux
2011-05-21 4:00 ` Segher Boessenkool
2011-05-21 4:00 ` Segher Boessenkool
[not found] ` <80f20ac921a33e9f0bf3e249f539a8ef-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org>
2011-05-21 14:55 ` Rob Herring
2011-05-21 14:55 ` Rob Herring
[not found] ` <4DD7D24D.2070604-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2011-05-21 15:18 ` Segher Boessenkool
2011-05-21 15:18 ` Segher Boessenkool
[not found] ` <ad5605c2a3d4b36f63f36f52afe89cfd-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org>
2011-05-21 17:43 ` Grant Likely
2011-05-21 17:43 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='BANLkTin4xKHbxysxN8M-5AP2143VkoLG=g@mail.gmail.com' \
--to=linus.walleij@linaro.org \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=jeremy.kerr@canonical.com \
--cc=khilman@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=rjw@sisk.pl \
--cc=robherring2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.