All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: Marc Zyngier <Marc.Zyngier@arm.com>
Cc: Ingo Molnar <mingo@elte.hu>,
	Frank Rowand <frank.rowand@am.sony.com>,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [BUG]  "sched: Remove rq->lock from the first half of ttwu()"  locks up on ARM
Date: Tue, 24 May 2011 23:32:30 +0200	[thread overview]
Message-ID: <1306272750.2497.79.camel@laptop> (raw)
In-Reply-To: <1306260792.27474.133.camel@e102391-lin.cambridge.arm.com>

On Tue, 2011-05-24 at 19:13 +0100, Marc Zyngier wrote:
> Peter,
> 
> I've experienced all kind of lock-ups on ARM SMP platforms recently, and
> finally tracked it down to the following patch:
> 
> e4a52bcb9a18142d79e231b6733cabdbf2e67c1f [sched: Remove rq->lock from the first half of ttwu()].
> 
> Even on moderate load, the machine locks up, often silently, and
> sometimes with a few messages like:
> INFO: rcu_preempt_state detected stalls on CPUs/tasks: { 0} (detected by 1, t=12002 jiffies)
> 
> Another side effect of this patch is that the load average is always 0,
> whatever load I throw at the system.
> 
> Reverting the sched changes up to that patch (included) gives me a
> working system again, which happily survives parallel kernel
> compilations without complaining.
> 
> My knowledge of the scheduler being rather limited, I haven't been able
> to pinpoint the exact problem (though it probably have something to do
> with __ARCH_WANT_INTERRUPTS_ON_CTXSW being defined on ARM). The enclosed
> patch somehow papers over the load average problem, but the system ends
> up locking up anyway:

Hurm.. I'll try and make x86 use __ARCH_WANT_INTERRUPTS_ON_CTXSW, IIRC
Ingo once said that that is possible and try to see if I can reproduce.
No clear ideas atm.

Thanks for reporting.


WARNING: multiple messages have this Message-ID (diff)
From: a.p.zijlstra@chello.nl (Peter Zijlstra)
To: linux-arm-kernel@lists.infradead.org
Subject: [BUG]  "sched: Remove rq->lock from the first half of ttwu()" locks up on ARM
Date: Tue, 24 May 2011 23:32:30 +0200	[thread overview]
Message-ID: <1306272750.2497.79.camel@laptop> (raw)
In-Reply-To: <1306260792.27474.133.camel@e102391-lin.cambridge.arm.com>

On Tue, 2011-05-24 at 19:13 +0100, Marc Zyngier wrote:
> Peter,
> 
> I've experienced all kind of lock-ups on ARM SMP platforms recently, and
> finally tracked it down to the following patch:
> 
> e4a52bcb9a18142d79e231b6733cabdbf2e67c1f [sched: Remove rq->lock from the first half of ttwu()].
> 
> Even on moderate load, the machine locks up, often silently, and
> sometimes with a few messages like:
> INFO: rcu_preempt_state detected stalls on CPUs/tasks: { 0} (detected by 1, t=12002 jiffies)
> 
> Another side effect of this patch is that the load average is always 0,
> whatever load I throw at the system.
> 
> Reverting the sched changes up to that patch (included) gives me a
> working system again, which happily survives parallel kernel
> compilations without complaining.
> 
> My knowledge of the scheduler being rather limited, I haven't been able
> to pinpoint the exact problem (though it probably have something to do
> with __ARCH_WANT_INTERRUPTS_ON_CTXSW being defined on ARM). The enclosed
> patch somehow papers over the load average problem, but the system ends
> up locking up anyway:

Hurm.. I'll try and make x86 use __ARCH_WANT_INTERRUPTS_ON_CTXSW, IIRC
Ingo once said that that is possible and try to see if I can reproduce.
No clear ideas atm.

Thanks for reporting.

  reply	other threads:[~2011-05-24 21:29 UTC|newest]

Thread overview: 102+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-24 18:13 [BUG] "sched: Remove rq->lock from the first half of ttwu()" locks up on ARM Marc Zyngier
2011-05-24 18:13 ` Marc Zyngier
2011-05-24 21:32 ` Peter Zijlstra [this message]
2011-05-24 21:32   ` Peter Zijlstra
2011-05-24 21:39   ` Ingo Molnar
2011-05-24 21:39     ` Ingo Molnar
2011-05-25 12:23     ` Marc Zyngier
2011-05-25 12:23       ` Marc Zyngier
2011-05-25 17:08   ` Peter Zijlstra
2011-05-25 17:08     ` Peter Zijlstra
2011-05-25 21:15     ` Peter Zijlstra
2011-05-25 21:15       ` Peter Zijlstra
2011-05-26  7:29       ` Yong Zhang
2011-05-26  7:29         ` Yong Zhang
2011-05-26 10:32         ` Peter Zijlstra
2011-05-26 10:32           ` Peter Zijlstra
2011-05-26 11:02           ` Marc Zyngier
2011-05-26 11:02             ` Marc Zyngier
2011-05-26 11:32             ` Peter Zijlstra
2011-05-26 11:32               ` Peter Zijlstra
2011-05-26 12:21               ` Peter Zijlstra
2011-05-26 12:21                 ` Peter Zijlstra
2011-05-26 12:26                 ` Ingo Molnar
2011-05-26 12:26                   ` Ingo Molnar
2011-05-26 12:31                   ` Russell King - ARM Linux
2011-05-26 12:31                     ` Russell King - ARM Linux
2011-05-26 12:37                     ` Peter Zijlstra
2011-05-26 12:37                       ` Peter Zijlstra
2011-05-26 12:50                     ` Ingo Molnar
2011-05-26 12:50                       ` Ingo Molnar
2011-05-26 13:36                       ` Russell King - ARM Linux
2011-05-26 13:36                         ` Russell King - ARM Linux
2011-05-26 14:45                       ` Catalin Marinas
2011-05-26 14:45                         ` Catalin Marinas
2011-05-27 12:06                         ` Ingo Molnar
2011-05-27 12:06                           ` Ingo Molnar
2011-05-27 17:55                           ` Russell King - ARM Linux
2011-05-27 17:55                             ` Russell King - ARM Linux
2011-05-27 19:41                           ` Nicolas Pitre
2011-05-27 19:41                             ` Nicolas Pitre
2011-05-27 20:52                           ` Russell King - ARM Linux
2011-05-27 20:52                             ` Russell King - ARM Linux
2011-05-28 13:13                             ` Peter Zijlstra
2011-05-28 13:13                               ` Peter Zijlstra
2011-05-31 11:08                               ` Michal Simek
2011-05-31 11:08                                 ` Michal Simek
2011-05-31 13:22                                 ` Peter Zijlstra
2011-05-31 13:22                                   ` Peter Zijlstra
2011-05-31 13:37                                   ` Michal Simek
2011-05-31 13:37                                     ` Michal Simek
2011-05-31 13:52                                     ` Peter Zijlstra
2011-05-31 13:52                                       ` Peter Zijlstra
2011-05-31 14:08                                       ` Michal Simek
2011-05-31 14:08                                         ` Michal Simek
2011-05-31 14:29                                         ` Peter Zijlstra
2011-05-31 14:29                                           ` Peter Zijlstra
2011-05-29 10:21                             ` Catalin Marinas
2011-05-29 10:21                               ` Catalin Marinas
2011-05-29 10:26                               ` Russell King - ARM Linux
2011-05-29 10:26                                 ` Russell King - ARM Linux
2011-05-29 12:01                                 ` Catalin Marinas
2011-05-29 12:01                                   ` Catalin Marinas
2011-05-29 13:19                                   ` Russell King - ARM Linux
2011-05-29 13:19                                     ` Russell King - ARM Linux
2011-05-29 21:21                                     ` Catalin Marinas
2011-05-29 21:21                                       ` Catalin Marinas
2011-05-29  9:51                           ` Catalin Marinas
2011-05-29  9:51                             ` Catalin Marinas
2011-06-06 10:29                           ` Pavel Machek
2011-06-06 10:29                             ` Pavel Machek
2011-05-26 14:56                 ` Marc Zyngier
2011-05-26 14:56                   ` Marc Zyngier
2011-05-26 15:45                 ` Oleg Nesterov
2011-05-26 15:45                   ` Oleg Nesterov
2011-05-26 15:59                   ` Peter Zijlstra
2011-05-26 15:59                     ` Peter Zijlstra
2011-05-26 16:09                     ` Peter Zijlstra
2011-05-26 16:09                       ` Peter Zijlstra
2011-05-26 16:20                       ` Marc Zyngier
2011-05-26 16:20                         ` Marc Zyngier
2011-05-26 16:32                         ` Peter Zijlstra
2011-05-26 16:32                           ` Peter Zijlstra
2011-05-27  8:01                           ` Marc Zyngier
2011-05-27  8:01                             ` Marc Zyngier
2011-05-26 16:22                       ` Marc Zyngier
2011-05-26 16:22                         ` Marc Zyngier
2011-05-26 17:04                       ` Oleg Nesterov
2011-05-26 17:04                         ` Oleg Nesterov
2011-05-26 17:17                         ` Peter Zijlstra
2011-05-26 17:17                           ` Peter Zijlstra
2011-05-26 17:23                           ` Peter Zijlstra
2011-05-26 17:23                             ` Peter Zijlstra
2011-05-26 17:49                             ` Oleg Nesterov
2011-05-26 17:49                               ` Oleg Nesterov
2011-05-27  7:01                             ` Yong Zhang
2011-05-27  7:01                               ` Yong Zhang
2011-05-27 15:23                             ` Santosh Shilimkar
2011-05-27 15:23                               ` Santosh Shilimkar
2011-05-27 15:29                               ` Marc Zyngier
2011-05-27 15:29                                 ` Marc Zyngier
2011-05-27 15:30                                 ` Santosh Shilimkar
2011-05-27 15:30                                   ` Santosh Shilimkar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1306272750.2497.79.camel@laptop \
    --to=a.p.zijlstra@chello.nl \
    --cc=Marc.Zyngier@arm.com \
    --cc=frank.rowand@am.sony.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.