All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: avi@redhat.com, mtosatti@redhat.com, kvm@vger.kernel.org,
	anthony.perard@citrix.com, jan.kiszka@siemens.com,
	mst@redhat.com, stefano.stabellini@eu.citrix.com
Subject: [PATCH uq/master 7/9] event_notifier: add event_notifier_set_handler
Date: Thu,  5 Jul 2012 17:16:28 +0200	[thread overview]
Message-ID: <1341501390-797-8-git-send-email-pbonzini@redhat.com> (raw)
In-Reply-To: <1341501390-797-1-git-send-email-pbonzini@redhat.com>

Win32 event notifiers are not file descriptors, so they will not be able
to use qemu_set_fd_handler.  But even if for now we only have a POSIX
version of EventNotifier, we can add a specific function that wraps
the call.

The wrapper passes the EventNotifier as the opaque value so that it will
be used with container_of.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 event_notifier.c |    7 +++++++
 event_notifier.h |    3 +++
 2 files changed, 10 insertions(+)

diff --git a/event_notifier.c b/event_notifier.c
index 99c376c..2c207e1 100644
--- a/event_notifier.c
+++ b/event_notifier.c
@@ -12,6 +12,7 @@
 
 #include "qemu-common.h"
 #include "event_notifier.h"
+#include "qemu-char.h"
 
 #ifdef CONFIG_EVENTFD
 #include <sys/eventfd.h>
@@ -45,6 +46,12 @@ int event_notifier_get_fd(EventNotifier *e)
     return e->fd;
 }
 
+int event_notifier_set_handler(EventNotifier *e,
+                               EventNotifierHandler *handler)
+{
+    return qemu_set_fd_handler(e->fd, (IOHandler *)handler, NULL, e);
+}
+
 int event_notifier_set(EventNotifier *e)
 {
     uint64_t value = 1;
diff --git a/event_notifier.h b/event_notifier.h
index 30c12dd..e5888ed 100644
--- a/event_notifier.h
+++ b/event_notifier.h
@@ -19,11 +19,14 @@ struct EventNotifier {
         int fd;
 };
 
+typedef void EventNotifierHandler(EventNotifier *);
+
 void event_notifier_init_fd(EventNotifier *, int fd);
 int event_notifier_init(EventNotifier *, int active);
 void event_notifier_cleanup(EventNotifier *);
 int event_notifier_get_fd(EventNotifier *);
 int event_notifier_set(EventNotifier *);
 int event_notifier_test_and_clear(EventNotifier *);
+int event_notifier_set_handler(EventNotifier *, EventNotifierHandler *);
 
 #endif
-- 
1.7.10.2



WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: kvm@vger.kernel.org, mst@redhat.com, jan.kiszka@siemens.com,
	mtosatti@redhat.com, avi@redhat.com, anthony.perard@citrix.com,
	stefano.stabellini@eu.citrix.com
Subject: [Qemu-devel] [PATCH uq/master 7/9] event_notifier: add event_notifier_set_handler
Date: Thu,  5 Jul 2012 17:16:28 +0200	[thread overview]
Message-ID: <1341501390-797-8-git-send-email-pbonzini@redhat.com> (raw)
In-Reply-To: <1341501390-797-1-git-send-email-pbonzini@redhat.com>

Win32 event notifiers are not file descriptors, so they will not be able
to use qemu_set_fd_handler.  But even if for now we only have a POSIX
version of EventNotifier, we can add a specific function that wraps
the call.

The wrapper passes the EventNotifier as the opaque value so that it will
be used with container_of.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 event_notifier.c |    7 +++++++
 event_notifier.h |    3 +++
 2 files changed, 10 insertions(+)

diff --git a/event_notifier.c b/event_notifier.c
index 99c376c..2c207e1 100644
--- a/event_notifier.c
+++ b/event_notifier.c
@@ -12,6 +12,7 @@
 
 #include "qemu-common.h"
 #include "event_notifier.h"
+#include "qemu-char.h"
 
 #ifdef CONFIG_EVENTFD
 #include <sys/eventfd.h>
@@ -45,6 +46,12 @@ int event_notifier_get_fd(EventNotifier *e)
     return e->fd;
 }
 
+int event_notifier_set_handler(EventNotifier *e,
+                               EventNotifierHandler *handler)
+{
+    return qemu_set_fd_handler(e->fd, (IOHandler *)handler, NULL, e);
+}
+
 int event_notifier_set(EventNotifier *e)
 {
     uint64_t value = 1;
diff --git a/event_notifier.h b/event_notifier.h
index 30c12dd..e5888ed 100644
--- a/event_notifier.h
+++ b/event_notifier.h
@@ -19,11 +19,14 @@ struct EventNotifier {
         int fd;
 };
 
+typedef void EventNotifierHandler(EventNotifier *);
+
 void event_notifier_init_fd(EventNotifier *, int fd);
 int event_notifier_init(EventNotifier *, int active);
 void event_notifier_cleanup(EventNotifier *);
 int event_notifier_get_fd(EventNotifier *);
 int event_notifier_set(EventNotifier *);
 int event_notifier_test_and_clear(EventNotifier *);
+int event_notifier_set_handler(EventNotifier *, EventNotifierHandler *);
 
 #endif
-- 
1.7.10.2

  parent reply	other threads:[~2012-07-05 15:17 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-05 15:16 [PATCH uq/master 0/9] remove event_notifier_get_fd from non-KVM code Paolo Bonzini
2012-07-05 15:16 ` [Qemu-devel] " Paolo Bonzini
2012-07-05 15:16 ` [PATCH uq/master 1/9] event_notifier: add event_notifier_set Paolo Bonzini
2012-07-05 15:16   ` [Qemu-devel] " Paolo Bonzini
2012-07-05 15:16 ` [PATCH uq/master 2/9] event_notifier: remove event_notifier_test Paolo Bonzini
2012-07-05 15:16   ` [Qemu-devel] " Paolo Bonzini
2012-07-12  9:10   ` Avi Kivity
2012-07-12  9:10     ` [Qemu-devel] " Avi Kivity
2012-07-12 10:30     ` Paolo Bonzini
2012-07-12 10:30       ` [Qemu-devel] " Paolo Bonzini
2012-07-12 11:04       ` Avi Kivity
2012-07-12 11:04         ` [Qemu-devel] " Avi Kivity
2012-07-12 11:16         ` Paolo Bonzini
2012-07-12 11:16           ` [Qemu-devel] " Paolo Bonzini
2012-07-05 15:16 ` [PATCH uq/master 3/9] event_notifier: add event_notifier_init_fd Paolo Bonzini
2012-07-05 15:16   ` [Qemu-devel] " Paolo Bonzini
2012-07-12  9:11   ` Avi Kivity
2012-07-12  9:11     ` [Qemu-devel] " Avi Kivity
2012-07-05 15:16 ` [PATCH uq/master 4/9] ivshmem: use EventNotifier and memory API Paolo Bonzini
2012-07-05 15:16   ` [Qemu-devel] " Paolo Bonzini
2012-07-05 15:16 ` [PATCH uq/master 5/9] ivshmem: wrap ivshmem_del_eventfd loops with transaction Paolo Bonzini
2012-07-05 15:16   ` [Qemu-devel] " Paolo Bonzini
2012-07-05 15:16 ` [PATCH uq/master 6/9] memory: pass EventNotifier, not eventfd Paolo Bonzini
2012-07-05 15:16   ` [Qemu-devel] " Paolo Bonzini
2012-07-05 15:16 ` Paolo Bonzini [this message]
2012-07-05 15:16   ` [Qemu-devel] [PATCH uq/master 7/9] event_notifier: add event_notifier_set_handler Paolo Bonzini
2012-07-05 15:16 ` [PATCH uq/master 8/9] virtio: move common ioeventfd handling out of virtio-pci Paolo Bonzini
2012-07-05 15:16   ` [Qemu-devel] " Paolo Bonzini
2012-07-05 15:16 ` [PATCH uq/master 9/9] virtio: move common irqfd " Paolo Bonzini
2012-07-05 15:16   ` [Qemu-devel] " Paolo Bonzini
2012-07-12  9:30 ` [PATCH uq/master 0/9] remove event_notifier_get_fd from non-KVM code Avi Kivity
2012-07-12  9:30   ` [Qemu-devel] " Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1341501390-797-8-git-send-email-pbonzini@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=anthony.perard@citrix.com \
    --cc=avi@redhat.com \
    --cc=jan.kiszka@siemens.com \
    --cc=kvm@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=mtosatti@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefano.stabellini@eu.citrix.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.