Re: [PATCH uq/master 0/9] remove event_notifier_get_fd from non-KVM code

From: Avi Kivity <avi@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, mtosatti@redhat.com, kvm@vger.kernel.org,
	anthony.perard@citrix.com, jan.kiszka@siemens.com,
	mst@redhat.com, stefano.stabellini@eu.citrix.com
Subject: Re: [PATCH uq/master 0/9] remove event_notifier_get_fd from non-KVM code
Date: Thu, 12 Jul 2012 12:30:34 +0300	[thread overview]
Message-ID: <4FFE993A.9090600@redhat.com> (raw)
In-Reply-To: <1341501390-797-1-git-send-email-pbonzini@redhat.com>

On 07/05/2012 06:16 PM, Paolo Bonzini wrote:
> This is part 1 of a three-part series that expands usage of EventNotifier
> in QEMU (including AIO and the main loop).  I started working on this when
> playing with the threaded block layer; the part of that work that I hope
> will be in 1.2 is generalizing posix-aio-compat.c to be a generic portable
> thread pool + porting AIO to Win32 (part 2).  On top of this, discard
> can be easily made asynchronous (part 3), which is a prerequisite for
> enabling it.
> 
> This first part does the necessary changes for porting EventNotifier
> to Win32.  The Win32 version will not have event_notifier_get_fd,
> and thus I want to remove all calls in portable code.  Instead, all
> functions used in portable code after this series take an EventNotifier;
> KVM-specific implementations retrieve the file descriptor internally
> (these calls are in hw/ivshmem.c, hw/vhost.c, kvm-all.c).
> 
> Patches 1 to 6 cover ivshmem and the memory API, first adding the
> required EventNotifier APIs and then using them.  Patches 7 to 9 do the
> same with KVM ioeventfd and irqfd, refactoring transport-independent
> code in the process from virtio-pci to virtio (the two steps are a bit
> hard to separate).

Looks good, all that is needed is an explanation for patch 2.

-- 
error compiling committee.c: too many arguments to function