From: Benoit Taine <benoit.taine@lip6.fr>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: benoit.taine@lip6.fr, linux-wireless@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 14/25] adm8211: Replace DEFINE_PCI_DEVICE_TABLE macro use
Date: Fri, 18 Jul 2014 17:27:01 +0200 [thread overview]
Message-ID: <1405697232-11785-15-git-send-email-benoit.taine@lip6.fr> (raw)
In-Reply-To: <1405697232-11785-1-git-send-email-benoit.taine@lip6.fr>
We should prefer `struct pci_device_id` over `DEFINE_PCI_DEVICE_TABLE` to meet
kernel coding style guidelines. This issue was reported by checkpatch.
Signed-off-by: Benoit Taine <benoit.taine@lip6.fr>
---
Tested by compilation without errors.
drivers/net/wireless/adm8211.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/adm8211.c b/drivers/net/wireless/adm8211.c
index f35f93c..17fcaab 100644
--- a/drivers/net/wireless/adm8211.c
+++ b/drivers/net/wireless/adm8211.c
@@ -41,7 +41,7 @@ static unsigned int rx_ring_size __read_mostly = 16;
module_param(tx_ring_size, uint, 0);
module_param(rx_ring_size, uint, 0);
-static DEFINE_PCI_DEVICE_TABLE(adm8211_pci_id_table) = {
+static const struct pci_device_id adm8211_pci_id_table[] = {
/* ADMtek ADM8211 */
{ PCI_DEVICE(0x10B7, 0x6000) }, /* 3Com 3CRSHPW796 */
{ PCI_DEVICE(0x1200, 0x8201) }, /* ? */
next prev parent reply other threads:[~2014-07-18 15:35 UTC|newest]
Thread overview: 123+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-18 15:26 [PATCH 0/25] Replace DEFINE_PCI_DEVICE_TABLE macro use Benoit Taine
2014-07-18 15:26 ` Benoit Taine
2014-07-18 15:26 ` [ath9k-devel] " Benoit Taine
2014-07-18 15:26 ` Benoit Taine
2014-07-18 15:26 ` Benoit Taine
2014-07-18 15:26 ` [PATCH 1/25] bna: " Benoit Taine
2014-07-18 15:26 ` [PATCH 2/25] BusLogic: " Benoit Taine
2014-07-21 14:48 ` Khalid Aziz
2014-07-18 15:26 ` [PATCH 3/25] iwlegacy: " Benoit Taine
2014-07-18 15:26 ` [PATCH 4/25] net: pasemi: " Benoit Taine
2014-07-18 15:26 ` [PATCH 5/25] net/ethernet/sgi/ioc3-eth: " Benoit Taine
2014-07-18 15:26 ` [PATCH 6/25] x86: " Benoit Taine
2014-07-18 15:26 ` [PATCH 7/25] rt2x00: " Benoit Taine
2014-07-18 15:26 ` [PATCH 8/25] dscc4: " Benoit Taine
2014-07-18 15:26 ` [PATCH 9/25] net: neterion: " Benoit Taine
2014-07-18 15:26 ` [PATCH 10/25] netxen: " Benoit Taine
2014-07-18 15:26 ` [PATCH 11/25] pcnet32: " Benoit Taine
2014-07-18 15:26 ` [PATCH 12/25] r8169: " Benoit Taine
2014-07-18 15:27 ` [PATCH 13/25] IB/mlx5: " Benoit Taine
2014-07-18 15:27 ` Benoit Taine [this message]
2014-07-18 15:27 ` [PATCH 15/25] qlcnic: " Benoit Taine
2014-07-18 15:27 ` [PATCH 16/25] be2net: " Benoit Taine
2014-07-18 15:27 ` [PATCH 17/25] block: " Benoit Taine
2014-07-18 15:27 ` [PATCH 18/25] smsc9420: " Benoit Taine
2014-07-18 15:27 ` [PATCH 19/25] irda: " Benoit Taine
2014-07-18 15:27 ` [PATCH 20/25] via-rhine: " Benoit Taine
2014-07-18 15:27 ` [PATCH 21/25] hostap: " Benoit Taine
2014-07-18 15:27 ` [PATCH 22/25] drivers/net: " Benoit Taine
2014-07-18 15:27 ` [PATCH 23/25] virtio: " Benoit Taine
2014-07-18 15:27 ` Benoit Taine
2014-07-21 1:22 ` Rusty Russell
2014-07-21 1:22 ` Rusty Russell
2014-07-18 15:27 ` [PATCH 24/25] starfire: " Benoit Taine
2014-07-18 15:27 ` [PATCH 25/25] ipack: " Benoit Taine
2014-07-18 15:59 ` Samuel Iglesias Gonsálvez
2014-07-18 23:03 ` Greg Kroah-Hartman
2014-07-18 16:22 ` [PATCH 0/25] " John W. Linville
2014-07-18 16:22 ` John W. Linville
2014-07-18 16:22 ` [ath9k-devel] " John W. Linville
2014-07-18 16:22 ` John W. Linville
2014-07-18 16:22 ` John W. Linville
2014-07-18 16:43 ` Greg KH
2014-07-18 16:43 ` Greg KH
2014-07-18 16:43 ` [ath9k-devel] " Greg KH
2014-07-18 16:43 ` Greg KH
2014-07-18 16:43 ` Greg KH
2014-07-18 16:54 ` James Bottomley
2014-07-18 16:54 ` James Bottomley
2014-07-18 16:54 ` James Bottomley
2014-07-18 16:54 ` [ath9k-devel] " James Bottomley
2014-07-18 16:54 ` James Bottomley
2014-07-18 16:54 ` James Bottomley
2014-07-18 16:54 ` James Bottomley
2014-07-18 18:17 ` Greg KH
2014-07-18 18:17 ` Greg KH
2014-07-18 18:17 ` Greg KH
2014-07-18 18:17 ` Greg KH
2014-07-18 18:17 ` [ath9k-devel] " Greg KH
2014-07-18 18:17 ` Greg KH
2014-07-18 18:17 ` Greg KH
2014-07-18 18:17 ` Greg KH
2014-07-18 18:50 ` James Bottomley
2014-07-18 18:50 ` James Bottomley
2014-07-18 18:50 ` [ath9k-devel] " James Bottomley
2014-07-18 18:50 ` James Bottomley
2014-07-18 18:50 ` James Bottomley
2014-07-18 18:50 ` James Bottomley
2014-07-21 23:16 ` Bjorn Helgaas
2014-07-21 23:16 ` Bjorn Helgaas
2014-07-21 23:16 ` Bjorn Helgaas
2014-07-21 23:16 ` [ath9k-devel] " Bjorn Helgaas
2014-07-21 23:16 ` Bjorn Helgaas
2014-07-21 23:16 ` Bjorn Helgaas
2014-07-22 17:12 ` Benoit Taine
2014-07-22 17:12 ` Benoit Taine
2014-07-22 17:12 ` Benoit Taine
2014-07-22 17:12 ` [ath9k-devel] " Benoit Taine
2014-07-22 17:12 ` Benoit Taine
2014-07-22 17:12 ` Benoit Taine
2014-07-22 17:12 ` Benoit Taine
2014-07-18 18:50 ` James Bottomley
2014-07-18 21:14 ` Dave Airlie
2014-07-18 21:14 ` Dave Airlie
2014-07-18 21:14 ` Dave Airlie
2014-07-18 21:14 ` [ath9k-devel] " Dave Airlie
2014-07-18 21:14 ` Dave Airlie
2014-07-18 21:14 ` Dave Airlie
2014-07-18 21:27 ` Greg KH
2014-07-18 21:27 ` Greg KH
2014-07-18 21:27 ` Greg KH
2014-07-18 21:27 ` [ath9k-devel] " Greg KH
2014-07-18 21:27 ` Greg KH
2014-07-18 21:27 ` Greg KH
2014-07-18 18:05 ` Joe Perches
2014-07-18 18:05 ` Joe Perches
2014-07-18 18:05 ` [ath9k-devel] " Joe Perches
2014-07-18 18:05 ` Joe Perches
2014-07-18 18:05 ` Joe Perches
2014-07-18 18:05 ` Joe Perches
2014-07-18 18:05 ` Joe Perches
2014-07-18 18:05 ` Joe Perches
2014-07-18 16:43 ` Greg KH
2014-07-18 16:22 ` John W. Linville
2014-07-18 16:22 ` John W. Linville
2014-07-18 16:28 ` James Bottomley
2014-07-18 16:28 ` James Bottomley
2014-07-18 16:28 ` James Bottomley
2014-07-18 16:28 ` [ath9k-devel] " James Bottomley
2014-07-18 16:28 ` James Bottomley
2014-07-18 16:28 ` James Bottomley
2014-07-18 16:33 ` Keller, Jacob E
2014-07-18 16:33 ` Keller, Jacob E
2014-07-18 16:33 ` Keller, Jacob E
2014-07-18 16:33 ` Keller, Jacob E
2014-07-18 16:33 ` [ath9k-devel] " Keller, Jacob E
2014-07-18 16:33 ` Keller, Jacob E
2014-07-18 16:33 ` Keller, Jacob E
2014-07-21 4:18 ` David Miller
2014-07-21 4:18 ` David Miller
2014-07-21 4:18 ` [ath9k-devel] " David Miller
2014-07-21 4:18 ` David Miller
2014-07-21 4:18 ` David Miller
2014-07-21 4:18 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1405697232-11785-15-git-send-email-benoit.taine@lip6.fr \
--to=benoit.taine@lip6.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.