Re: [PATCH 25/25] ipack: Replace DEFINE_PCI_DEVICE_TABLE macro use

From: "Samuel Iglesias Gonsálvez" <siglesias@igalia.com>
To: Benoit Taine <benoit.taine@lip6.fr>
Cc: Jens Taprogge <jens.taprogge@taprogge.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	industrypack-devel@lists.sourceforge.net,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 25/25] ipack: Replace DEFINE_PCI_DEVICE_TABLE macro use
Date: Fri, 18 Jul 2014 17:59:16 +0200	[thread overview]
Message-ID: <1405699156.2237.4.camel@fourier> (raw)
In-Reply-To: <1405697232-11785-26-git-send-email-benoit.taine@lip6.fr>

[-- Attachment #1: Type: text/plain, Size: 1137 bytes --]

On Fri, 2014-07-18 at 17:27 +0200, Benoit Taine wrote:
> We should prefer `struct pci_device_id` over `DEFINE_PCI_DEVICE_TABLE` to meet
> kernel coding style guidelines. This issue was reported by checkpatch.
> 
> Signed-off-by: Benoit Taine <benoit.taine@lip6.fr>
> 
> ---
> Tested by compilation without errors.
> 
>  drivers/ipack/carriers/tpci200.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/ipack/carriers/tpci200.c b/drivers/ipack/carriers/tpci200.c
> index c276fde..de5e321 100644
> --- a/drivers/ipack/carriers/tpci200.c
> +++ b/drivers/ipack/carriers/tpci200.c
> @@ -618,7 +618,7 @@ static void tpci200_pci_remove(struct pci_dev *dev)
>  	__tpci200_pci_remove(tpci200);
>  }
>  
> -static DEFINE_PCI_DEVICE_TABLE(tpci200_idtable) = {
> +static const struct pci_device_id tpci200_idtable[] = {
>  	{ TPCI200_VENDOR_ID, TPCI200_DEVICE_ID, TPCI200_SUBVENDOR_ID,
>  	  TPCI200_SUBDEVICE_ID },
>  	{ 0, },
> 
> 

Acked-by: Samuel Iglesias Gonsalvez <siglesias@igalia.com>

Greg, Would you mind picking this patch through your char-misc tree?

Thanks,

Sam

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]