All of lore.kernel.org
 help / color / mirror / Atom feed
From: "John W. Linville" <linville@tuxdriver.com>
To: Benoit Taine <benoit.taine@lip6.fr>
Cc: linux-pci@vger.kernel.org, ath5k-devel@venema.h4ckr.net,
	ath9k-devel@venema.h4ckr.net, linux-hippi@sunsite.dk,
	dri-devel@lists.freedesktop.org, linux-acenic@sunsite.dk,
	wil6210@qca.qualcomm.com, platform-driver-x86@vger.kernel.org,
	linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
	netdev@vger.kernel.org, linux-wireless@vger.kernel.org,
	linux-mips@linux-mips.org, users@rt2x00.serialmonkey.com,
	linux-rdma@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	industrypack-devel@lists.sourceforge.net,
	linux-can@vger.kernel.org, linux-mmc@vger.kernel.org,
	linux-fbdev@vger.kernel.org, ath10k@lists.infradead.org,
	linux-crypto@vger.kernel.org, MPT-FusionLinux.pdl@avagotech.com,
	devel@linuxdriverproject.org, xen-devel@lists.xenproject.org,
	linux-pcmcia@lists.infradead.org,
	e1000-devel@lists.sourceforge.net
Subject: Re: [PATCH 0/25] Replace DEFINE_PCI_DEVICE_TABLE macro use
Date: Fri, 18 Jul 2014 12:22:13 -0400	[thread overview]
Message-ID: <20140718162213.GC31114@tuxdriver.com> (raw)
In-Reply-To: <1405697232-11785-1-git-send-email-benoit.taine@lip6.fr>

On Fri, Jul 18, 2014 at 05:26:47PM +0200, Benoit Taine wrote:
> We should prefer `const struct pci_device_id` over
> `DEFINE_PCI_DEVICE_TABLE` to meet kernel coding style guidelines.
> This issue was reported by checkpatch.

Honestly, I prefer the macro -- it stands-out more.  Maybe the style
guidelines and/or checkpatch should change instead?

John
-- 
John W. Linville		Someday the world will need a hero, and you
linville@tuxdriver.com			might be all we have.  Be ready.

WARNING: multiple messages have this Message-ID (diff)
From: "John W. Linville" <linville@tuxdriver.com>
To: Benoit Taine <benoit.taine@lip6.fr>
Cc: linux-mips@linux-mips.org, linux-fbdev@vger.kernel.org,
	linux-pci@vger.kernel.org, dri-devel@lists.freedesktop.org,
	linux-kernel@vger.kernel.org, ath5k-devel@venema.h4ckr.net,
	MPT-FusionLinux.pdl@avagotech.com, linux-acenic@sunsite.dk,
	linux-scsi@vger.kernel.org, linux-rdma@vger.kernel.org,
	ath10k@lists.infradead.org, linux-hippi@sunsite.dk,
	industrypack-devel@lists.sourceforge.net,
	linux-mmc@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	ath9k-devel@venema.h4ckr.net, wil6210@qca.qualcomm.com,
	linux-pcmcia@lists.infradead.org, linux-can@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	platform-driver-x86@vger.kernel.org, netdev@vger.kernel.org,
	linux-wireless@vger.kernel.org, users@rt2x00.serialmonkey.com,
	e1000-devel@lists.sourceforge.net, linux-crypto@vger.kernel.org,
	devel@linuxdriverproject.org
Subject: Re: [PATCH 0/25] Replace DEFINE_PCI_DEVICE_TABLE macro use
Date: Fri, 18 Jul 2014 12:22:13 -0400	[thread overview]
Message-ID: <20140718162213.GC31114@tuxdriver.com> (raw)
In-Reply-To: <1405697232-11785-1-git-send-email-benoit.taine@lip6.fr>

On Fri, Jul 18, 2014 at 05:26:47PM +0200, Benoit Taine wrote:
> We should prefer `const struct pci_device_id` over
> `DEFINE_PCI_DEVICE_TABLE` to meet kernel coding style guidelines.
> This issue was reported by checkpatch.

Honestly, I prefer the macro -- it stands-out more.  Maybe the style
guidelines and/or checkpatch should change instead?

John
-- 
John W. Linville		Someday the world will need a hero, and you
linville@tuxdriver.com			might be all we have.  Be ready.

------------------------------------------------------------------------------
Want fast and easy access to all the code in your enterprise? Index and
search up to 200,000 lines of code with a free copy of Black Duck
Code Sight - the same software that powers the world's largest code
search on Ohloh, the Black Duck Open Hub! Try it now.
http://p.sf.net/sfu/bds
_______________________________________________
E1000-devel mailing list
E1000-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/e1000-devel
To learn more about Intel&#174; Ethernet, visit http://communities.intel.com/community/wired

WARNING: multiple messages have this Message-ID (diff)
From: "John W. Linville" <linville@tuxdriver.com>
To: Benoit Taine <benoit.taine@lip6.fr>
Cc: linux-mips@linux-mips.org, linux-fbdev@vger.kernel.org,
	linux-pci@vger.kernel.org, dri-devel@lists.freedesktop.org,
	linux-kernel@vger.kernel.org, ath5k-devel@venema.h4ckr.net,
	MPT-FusionLinux.pdl@avagotech.com, linux-acenic@sunsite.dk,
	linux-scsi@vger.kernel.org, linux-rdma@vger.kernel.org,
	ath10k@lists.infradead.org, linux-hippi@sunsite.dk,
	industrypack-devel@lists.sourceforge.net,
	linux-mmc@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	ath9k-devel@venema.h4ckr.net, wil6210@qca.qualcomm.com,
	linux-pcmcia@lists.infradead.org, linux-can@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	platform-driver-x86@vger.kernel.org, netdev@vger.kernel.org,
	linux-wireless@vger.kernel.org, users@rt2x00.serialmonkey.com,
	e1000-devel@lists.sourceforge.net, linux-crypto@vger.kernel.org,
	devel@linuxdriverproject.org
Subject: Re: [PATCH 0/25] Replace DEFINE_PCI_DEVICE_TABLE macro use
Date: Fri, 18 Jul 2014 16:22:13 +0000	[thread overview]
Message-ID: <20140718162213.GC31114@tuxdriver.com> (raw)
In-Reply-To: <1405697232-11785-1-git-send-email-benoit.taine@lip6.fr>

On Fri, Jul 18, 2014 at 05:26:47PM +0200, Benoit Taine wrote:
> We should prefer `const struct pci_device_id` over
> `DEFINE_PCI_DEVICE_TABLE` to meet kernel coding style guidelines.
> This issue was reported by checkpatch.

Honestly, I prefer the macro -- it stands-out more.  Maybe the style
guidelines and/or checkpatch should change instead?

John
-- 
John W. Linville		Someday the world will need a hero, and you
linville@tuxdriver.com			might be all we have.  Be ready.

WARNING: multiple messages have this Message-ID (diff)
From: John W. Linville <linville@tuxdriver.com>
To: ath9k-devel@lists.ath9k.org
Subject: [ath9k-devel] [PATCH 0/25] Replace DEFINE_PCI_DEVICE_TABLE macro use
Date: Fri, 18 Jul 2014 12:22:13 -0400	[thread overview]
Message-ID: <20140718162213.GC31114@tuxdriver.com> (raw)
In-Reply-To: <1405697232-11785-1-git-send-email-benoit.taine@lip6.fr>

On Fri, Jul 18, 2014 at 05:26:47PM +0200, Benoit Taine wrote:
> We should prefer `const struct pci_device_id` over
> `DEFINE_PCI_DEVICE_TABLE` to meet kernel coding style guidelines.
> This issue was reported by checkpatch.

Honestly, I prefer the macro -- it stands-out more.  Maybe the style
guidelines and/or checkpatch should change instead?

John
-- 
John W. Linville		Someday the world will need a hero, and you
linville at tuxdriver.com			might be all we have.  Be ready.

WARNING: multiple messages have this Message-ID (diff)
From: "John W. Linville" <linville@tuxdriver.com>
To: Benoit Taine <benoit.taine@lip6.fr>
Cc: linux-mips@linux-mips.org, linux-fbdev@vger.kernel.org,
	linux-pci@vger.kernel.org, dri-devel@lists.freedesktop.org,
	linux-kernel@vger.kernel.org, ath5k-devel@venema.h4ckr.net,
	linux-acenic@sunsite.dk, linux-scsi@vger.kernel.org,
	linux-rdma@vger.kernel.org, ath10k@lists.infradead.org,
	linux-hippi@sunsite.dk, industrypack-devel@lists.sourceforge.net,
	linux-mmc@vger.kernel.org, MPT-FusionLinux.pdl@avagotech.com,
	virtualization@lists.linux-foundation.org,
	ath9k-devel@venema.h4ckr.net, wil6210@qca.qualcomm.com,
	linux-pcmcia@lists.infradead.org, linux-can@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	platform-driver-x86@vger.kernel.org, netdev@vger.kernel.org,
	linux-wireless@vger.kernel.org, users@rt2x00.serialmonkey.com,
	e1000-devel@lists.sourceforge.net, linux-crypto@vger.kernel.org,
	devel@linuxdriverproject.org
Subject: Re: [PATCH 0/25] Replace DEFINE_PCI_DEVICE_TABLE macro use
Date: Fri, 18 Jul 2014 12:22:13 -0400	[thread overview]
Message-ID: <20140718162213.GC31114@tuxdriver.com> (raw)
In-Reply-To: <1405697232-11785-1-git-send-email-benoit.taine@lip6.fr>

On Fri, Jul 18, 2014 at 05:26:47PM +0200, Benoit Taine wrote:
> We should prefer `const struct pci_device_id` over
> `DEFINE_PCI_DEVICE_TABLE` to meet kernel coding style guidelines.
> This issue was reported by checkpatch.

Honestly, I prefer the macro -- it stands-out more.  Maybe the style
guidelines and/or checkpatch should change instead?

John
-- 
John W. Linville		Someday the world will need a hero, and you
linville@tuxdriver.com			might be all we have.  Be ready.

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

  parent reply	other threads:[~2014-07-18 16:30 UTC|newest]

Thread overview: 125+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-18 15:26 [PATCH 0/25] Replace DEFINE_PCI_DEVICE_TABLE macro use Benoit Taine
2014-07-18 15:26 ` Benoit Taine
2014-07-18 15:26 ` [ath9k-devel] " Benoit Taine
2014-07-18 15:26 ` Benoit Taine
2014-07-18 15:26 ` Benoit Taine
2014-07-18 15:26 ` [PATCH 1/25] bna: " Benoit Taine
2014-07-18 15:26 ` [PATCH 2/25] BusLogic: " Benoit Taine
2014-07-21 14:48   ` Khalid Aziz
2014-07-18 15:26 ` [PATCH 3/25] iwlegacy: " Benoit Taine
2014-07-18 15:26 ` [PATCH 4/25] net: pasemi: " Benoit Taine
2014-07-18 15:26 ` [PATCH 5/25] net/ethernet/sgi/ioc3-eth: " Benoit Taine
2014-07-18 15:26 ` [PATCH 6/25] x86: " Benoit Taine
2014-07-18 15:26 ` [PATCH 7/25] rt2x00: " Benoit Taine
2014-07-18 15:26 ` [PATCH 8/25] dscc4: " Benoit Taine
2014-07-18 15:26 ` [PATCH 9/25] net: neterion: " Benoit Taine
2014-07-18 15:26 ` [PATCH 10/25] netxen: " Benoit Taine
2014-07-18 15:26 ` [PATCH 11/25] pcnet32: " Benoit Taine
2014-07-18 15:26 ` [PATCH 12/25] r8169: " Benoit Taine
2014-07-18 15:27 ` [PATCH 13/25] IB/mlx5: " Benoit Taine
2014-07-18 15:27 ` [PATCH 14/25] adm8211: " Benoit Taine
2014-07-18 15:27 ` [PATCH 15/25] qlcnic: " Benoit Taine
2014-07-18 15:27 ` [PATCH 16/25] be2net: " Benoit Taine
2014-07-18 15:27 ` [PATCH 17/25] block: " Benoit Taine
2014-07-18 15:27 ` [PATCH 18/25] smsc9420: " Benoit Taine
2014-07-18 15:27 ` [PATCH 19/25] irda: " Benoit Taine
2014-07-18 15:27 ` [PATCH 20/25] via-rhine: " Benoit Taine
2014-07-18 15:27 ` [PATCH 21/25] hostap: " Benoit Taine
2014-07-18 15:27 ` [PATCH 22/25] drivers/net: " Benoit Taine
2014-07-18 15:27 ` [PATCH 23/25] virtio: " Benoit Taine
2014-07-18 15:27 ` Benoit Taine
2014-07-21  1:22   ` Rusty Russell
2014-07-21  1:22     ` Rusty Russell
2014-07-18 15:27 ` [PATCH 24/25] starfire: " Benoit Taine
2014-07-18 15:27 ` [PATCH 25/25] ipack: " Benoit Taine
2014-07-18 15:59   ` Samuel Iglesias Gonsálvez
2014-07-18 23:03     ` Greg Kroah-Hartman
2014-07-18 16:22 ` John W. Linville [this message]
2014-07-18 16:22   ` [PATCH 0/25] " John W. Linville
2014-07-18 16:22   ` [ath9k-devel] " John W. Linville
2014-07-18 16:22   ` John W. Linville
2014-07-18 16:22   ` John W. Linville
2014-07-18 16:43   ` Greg KH
2014-07-18 16:43     ` Greg KH
2014-07-18 16:43     ` [ath9k-devel] " Greg KH
2014-07-18 16:43     ` Greg KH
2014-07-18 16:43     ` Greg KH
2014-07-18 16:54     ` James Bottomley
2014-07-18 16:54     ` James Bottomley
2014-07-18 16:54       ` James Bottomley
2014-07-18 16:54       ` [ath9k-devel] " James Bottomley
2014-07-18 16:54       ` James Bottomley
2014-07-18 16:54       ` James Bottomley
2014-07-18 16:54       ` James Bottomley
2014-07-18 18:17       ` Greg KH
2014-07-18 18:17       ` Greg KH
2014-07-18 18:17       ` Greg KH
2014-07-18 18:17         ` Greg KH
2014-07-18 18:17         ` [ath9k-devel] " Greg KH
2014-07-18 18:17         ` Greg KH
2014-07-18 18:17         ` Greg KH
2014-07-18 18:17         ` Greg KH
2014-07-18 18:50         ` James Bottomley
2014-07-18 18:50           ` James Bottomley
2014-07-18 18:50           ` [ath9k-devel] " James Bottomley
2014-07-18 18:50           ` James Bottomley
2014-07-18 18:50           ` James Bottomley
2014-07-18 18:50           ` James Bottomley
2014-07-21 23:16           ` Bjorn Helgaas
2014-07-21 23:16           ` Bjorn Helgaas
2014-07-21 23:16             ` Bjorn Helgaas
2014-07-21 23:16             ` [ath9k-devel] " Bjorn Helgaas
2014-07-21 23:16             ` Bjorn Helgaas
2014-07-21 23:16             ` Bjorn Helgaas
2014-07-22 17:12             ` Benoit Taine
2014-07-22 17:12             ` Benoit Taine
2014-07-22 17:12               ` Benoit Taine
2014-07-22 17:12               ` [ath9k-devel] " Benoit Taine
2014-07-22 17:12               ` Benoit Taine
2014-07-22 17:12               ` Benoit Taine
2014-07-22 17:12             ` Benoit Taine
2014-07-18 18:50         ` James Bottomley
2014-07-18 21:14         ` Dave Airlie
2014-07-18 21:14         ` Dave Airlie
2014-07-18 21:14           ` Dave Airlie
2014-07-18 21:14           ` [ath9k-devel] " Dave Airlie
2014-07-18 21:14           ` Dave Airlie
2014-07-18 21:14           ` Dave Airlie
2014-07-18 21:27           ` Greg KH
2014-07-18 21:27           ` Greg KH
2014-07-18 21:27             ` Greg KH
2014-07-18 21:27             ` [ath9k-devel] " Greg KH
2014-07-18 21:27             ` Greg KH
2014-07-18 21:27             ` Greg KH
2014-07-18 18:05     ` Joe Perches
2014-07-18 18:05       ` Joe Perches
2014-07-18 18:05       ` [ath9k-devel] " Joe Perches
2014-07-18 18:05       ` Joe Perches
2014-07-18 18:05       ` Joe Perches
2014-07-18 18:05       ` Joe Perches
2014-07-18 18:05     ` Joe Perches
2014-07-18 18:05     ` Joe Perches
2014-07-18 16:43   ` Greg KH
2014-07-18 16:22 ` John W. Linville
2014-07-18 16:22 ` John W. Linville
2014-07-18 16:28 ` James Bottomley
2014-07-18 16:28 ` James Bottomley
2014-07-18 16:28   ` James Bottomley
2014-07-18 16:28   ` [ath9k-devel] " James Bottomley
2014-07-18 16:28   ` James Bottomley
2014-07-18 16:28   ` James Bottomley
2014-07-18 16:33   ` Keller, Jacob E
2014-07-18 16:33   ` Keller, Jacob E
2014-07-18 16:33   ` Keller, Jacob E
2014-07-18 16:33     ` Keller, Jacob E
2014-07-18 16:33     ` [ath9k-devel] " Keller, Jacob E
2014-07-18 16:33     ` Keller, Jacob E
2014-07-18 16:33     ` Keller, Jacob E
2014-07-21  4:18 ` David Miller
2014-07-21  4:18   ` David Miller
2014-07-21  4:18   ` [ath9k-devel] " David Miller
2014-07-21  4:18   ` David Miller
2014-07-21  4:18 ` David Miller
2014-07-21  4:18 ` David Miller
2014-07-18 15:26 Benoit Taine
2014-07-18 15:26 Benoit Taine

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140718162213.GC31114@tuxdriver.com \
    --to=linville@tuxdriver.com \
    --cc=MPT-FusionLinux.pdl@avagotech.com \
    --cc=ath10k@lists.infradead.org \
    --cc=ath5k-devel@venema.h4ckr.net \
    --cc=ath9k-devel@venema.h4ckr.net \
    --cc=benoit.taine@lip6.fr \
    --cc=devel@linuxdriverproject.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=e1000-devel@lists.sourceforge.net \
    --cc=industrypack-devel@lists.sourceforge.net \
    --cc=linux-acenic@sunsite.dk \
    --cc=linux-can@vger.kernel.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-hippi@sunsite.dk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@linux-mips.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-pcmcia@lists.infradead.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=users@rt2x00.serialmonkey.com \
    --cc=virtualization@lists.linux-foundation.org \
    --cc=wil6210@qca.qualcomm.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.