From: Aaro Koskinen <aaro.koskinen@iki.fi>
To: Tony Lindgren <tony@atomide.com>,
Samuel Ortiz <sameo@linux.intel.com>,
Lee Jones <lee.jones@linaro.org>,
devicetree@vger.kernel.org, linux-omap@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Cc: Aaro Koskinen <aaro.koskinen@iki.fi>
Subject: [PATCH 7/7] mfd: menelaus: use macro for magic number
Date: Sat, 27 Dec 2014 19:52:59 +0200 [thread overview]
Message-ID: <1419702779-16001-8-git-send-email-aaro.koskinen@iki.fi> (raw)
In-Reply-To: <1419702779-16001-1-git-send-email-aaro.koskinen@iki.fi>
Use macro to check a register bit.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
---
drivers/mfd/menelaus.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mfd/menelaus.c b/drivers/mfd/menelaus.c
index 8660adf..05bae40 100644
--- a/drivers/mfd/menelaus.c
+++ b/drivers/mfd/menelaus.c
@@ -1242,7 +1242,7 @@ static int menelaus_probe(struct i2c_client *client,
err = menelaus_read_reg(MENELAUS_VCORE_CTRL1);
if (err < 0)
goto fail;
- if (err & BIT(7))
+ if (err & VCORE_CTRL1_HW_NSW)
menelaus->vcore_hw_mode = 1;
else
menelaus->vcore_hw_mode = 0;
--
2.2.0
WARNING: multiple messages have this Message-ID (diff)
From: aaro.koskinen@iki.fi (Aaro Koskinen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 7/7] mfd: menelaus: use macro for magic number
Date: Sat, 27 Dec 2014 19:52:59 +0200 [thread overview]
Message-ID: <1419702779-16001-8-git-send-email-aaro.koskinen@iki.fi> (raw)
In-Reply-To: <1419702779-16001-1-git-send-email-aaro.koskinen@iki.fi>
Use macro to check a register bit.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
---
drivers/mfd/menelaus.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mfd/menelaus.c b/drivers/mfd/menelaus.c
index 8660adf..05bae40 100644
--- a/drivers/mfd/menelaus.c
+++ b/drivers/mfd/menelaus.c
@@ -1242,7 +1242,7 @@ static int menelaus_probe(struct i2c_client *client,
err = menelaus_read_reg(MENELAUS_VCORE_CTRL1);
if (err < 0)
goto fail;
- if (err & BIT(7))
+ if (err & VCORE_CTRL1_HW_NSW)
menelaus->vcore_hw_mode = 1;
else
menelaus->vcore_hw_mode = 0;
--
2.2.0
next prev parent reply other threads:[~2014-12-27 17:52 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-27 17:52 [PATCH 0/7] Menelaus cleanup for DT, phase 1 Aaro Koskinen
2014-12-27 17:52 ` Aaro Koskinen
2014-12-27 17:52 ` [PATCH 1/7] mfd: menelaus: delete omap_has_menelaus Aaro Koskinen
2014-12-27 17:52 ` Aaro Koskinen
2015-01-20 13:50 ` Lee Jones
2015-01-20 13:50 ` Lee Jones
2014-12-27 17:52 ` [PATCH 2/7] mfd: menelaus: drop support for SW controller VCORE Aaro Koskinen
2014-12-27 17:52 ` Aaro Koskinen
2015-01-20 13:52 ` Lee Jones
2015-01-20 13:52 ` Lee Jones
2014-12-27 17:52 ` [PATCH 3/7] mfd: menelaus: add initial DT support Aaro Koskinen
2014-12-27 17:52 ` Aaro Koskinen
2014-12-27 21:25 ` Felipe Balbi
2014-12-27 21:25 ` Felipe Balbi
2014-12-28 23:34 ` Aaro Koskinen
2014-12-28 23:34 ` Aaro Koskinen
2014-12-29 18:12 ` Felipe Balbi
2014-12-29 18:12 ` Felipe Balbi
2014-12-27 17:52 ` [PATCH 5/7] mfd: menelaus: delete platform data support Aaro Koskinen
2014-12-27 17:52 ` Aaro Koskinen
2015-01-20 13:54 ` Lee Jones
2015-01-20 13:54 ` Lee Jones
2014-12-27 17:52 ` [PATCH 6/7] mfd: menelaus: make vcore and regulator controls internal Aaro Koskinen
2014-12-27 17:52 ` Aaro Koskinen
2015-01-20 13:58 ` Lee Jones
2015-01-20 13:58 ` Lee Jones
2015-01-20 14:01 ` Lee Jones
2015-01-20 14:01 ` Lee Jones
2014-12-27 17:52 ` Aaro Koskinen [this message]
2014-12-27 17:52 ` [PATCH 7/7] mfd: menelaus: use macro for magic number Aaro Koskinen
[not found] ` <1419702779-16001-8-git-send-email-aaro.koskinen-X3B1VOXEql0@public.gmane.org>
2015-01-20 14:01 ` Lee Jones
2015-01-20 14:01 ` Lee Jones
[not found] ` <1419702779-16001-1-git-send-email-aaro.koskinen-X3B1VOXEql0@public.gmane.org>
2014-12-27 17:52 ` [PATCH 4/7] ARM: OMAP: N8x0: configure menelaus using DT Aaro Koskinen
2014-12-27 17:52 ` Aaro Koskinen
2015-01-20 17:13 ` [PATCH 0/7] Menelaus cleanup for DT, phase 1 Lee Jones
2015-01-20 17:13 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1419702779-16001-8-git-send-email-aaro.koskinen@iki.fi \
--to=aaro.koskinen@iki.fi \
--cc=devicetree@vger.kernel.org \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=sameo@linux.intel.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.