From: Aaro Koskinen <aaro.koskinen@iki.fi> To: Felipe Balbi <balbi@ti.com> Cc: Tony Lindgren <tony@atomide.com>, Samuel Ortiz <sameo@linux.intel.com>, Lee Jones <lee.jones@linaro.org>, devicetree@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 3/7] mfd: menelaus: add initial DT support Date: Mon, 29 Dec 2014 01:34:45 +0200 [thread overview] Message-ID: <20141228233445.GD582@fuloong-minipc.musicnaut.iki.fi> (raw) In-Reply-To: <20141227212553.GA21729@saruman> Hi, On Sat, Dec 27, 2014 at 03:25:53PM -0600, Felipe Balbi wrote: > On Sat, Dec 27, 2014 at 07:52:55PM +0200, Aaro Koskinen wrote: > > Add initial DT support. > > > > Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi> > > --- > > Documentation/devicetree/bindings/mfd/menelaus.txt | 30 +++++++++++++ > > drivers/mfd/menelaus.c | 52 ++++++++++++++++++++-- > > 2 files changed, 78 insertions(+), 4 deletions(-) > > create mode 100644 Documentation/devicetree/bindings/mfd/menelaus.txt > > > > diff --git a/Documentation/devicetree/bindings/mfd/menelaus.txt b/Documentation/devicetree/bindings/mfd/menelaus.txt > > new file mode 100644 > > index 0000000..5f69f23 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/mfd/menelaus.txt > > @@ -0,0 +1,30 @@ > > +Menelaus (Texas Instruments TWL92330) Power Management chip > > + > > +Menelaus provides facilities to control the power resources. > > + > > +Required properties: > > +- compatible: must be "menelaus" > > +- reg: I2C address of the chip > > + > > +Optional properties: > > +- interrupts: the interrupt > > +- ti,autosleep: All regulators are put to sleep by default. > > +- ti,vcore-min-microvolt: Range floor for the HW controlled VCORE > > +- ti,vcore-max-microvolt: Range roof for the HW controlled VCORE > > + > > +The use of ti,autosleep is recommended at least on Nokia N800/N810. > > + > > +Example: > > + > > +&i2c1 { > > + clock-frequency = <400000>; > > + > > + pmic@72 { > > + compatible = "menelaus"; > > + reg = <0x72>; > > + interrupts = <7 IRQ_TYPE_EDGE_RISING>; > > + ti,autosleep; > > + ti,vcore-min-microvolt = <1050000>; > > + ti,vcore-max-microvolt = <1400000>; > > looks like these should be first converted to actual regulators > otherwise we will have to maintain this binding forever which means that > any effort of adding regulator fwk support for menelaus will become a > lot more difficult because it'll have to cope with the legacy/bogus > binding. I was thinking such conversion could be done with incremental patches... There's basically only one board (n8x0) that uses this and not likely to be any others. Is there a way to declare bindings unstable? > I started doing irqchip/irqdomain conversion but I don't have where to > test and got side-tracked by other stuff. I'll see if I can restart that > work early next year. > > Then, if you change your series so that first you add proper regulator > fwk support, we should be pretty good with menelaus. Ok, let's see. A.
WARNING: multiple messages have this Message-ID (diff)
From: aaro.koskinen@iki.fi (Aaro Koskinen) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 3/7] mfd: menelaus: add initial DT support Date: Mon, 29 Dec 2014 01:34:45 +0200 [thread overview] Message-ID: <20141228233445.GD582@fuloong-minipc.musicnaut.iki.fi> (raw) In-Reply-To: <20141227212553.GA21729@saruman> Hi, On Sat, Dec 27, 2014 at 03:25:53PM -0600, Felipe Balbi wrote: > On Sat, Dec 27, 2014 at 07:52:55PM +0200, Aaro Koskinen wrote: > > Add initial DT support. > > > > Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi> > > --- > > Documentation/devicetree/bindings/mfd/menelaus.txt | 30 +++++++++++++ > > drivers/mfd/menelaus.c | 52 ++++++++++++++++++++-- > > 2 files changed, 78 insertions(+), 4 deletions(-) > > create mode 100644 Documentation/devicetree/bindings/mfd/menelaus.txt > > > > diff --git a/Documentation/devicetree/bindings/mfd/menelaus.txt b/Documentation/devicetree/bindings/mfd/menelaus.txt > > new file mode 100644 > > index 0000000..5f69f23 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/mfd/menelaus.txt > > @@ -0,0 +1,30 @@ > > +Menelaus (Texas Instruments TWL92330) Power Management chip > > + > > +Menelaus provides facilities to control the power resources. > > + > > +Required properties: > > +- compatible: must be "menelaus" > > +- reg: I2C address of the chip > > + > > +Optional properties: > > +- interrupts: the interrupt > > +- ti,autosleep: All regulators are put to sleep by default. > > +- ti,vcore-min-microvolt: Range floor for the HW controlled VCORE > > +- ti,vcore-max-microvolt: Range roof for the HW controlled VCORE > > + > > +The use of ti,autosleep is recommended at least on Nokia N800/N810. > > + > > +Example: > > + > > +&i2c1 { > > + clock-frequency = <400000>; > > + > > + pmic at 72 { > > + compatible = "menelaus"; > > + reg = <0x72>; > > + interrupts = <7 IRQ_TYPE_EDGE_RISING>; > > + ti,autosleep; > > + ti,vcore-min-microvolt = <1050000>; > > + ti,vcore-max-microvolt = <1400000>; > > looks like these should be first converted to actual regulators > otherwise we will have to maintain this binding forever which means that > any effort of adding regulator fwk support for menelaus will become a > lot more difficult because it'll have to cope with the legacy/bogus > binding. I was thinking such conversion could be done with incremental patches... There's basically only one board (n8x0) that uses this and not likely to be any others. Is there a way to declare bindings unstable? > I started doing irqchip/irqdomain conversion but I don't have where to > test and got side-tracked by other stuff. I'll see if I can restart that > work early next year. > > Then, if you change your series so that first you add proper regulator > fwk support, we should be pretty good with menelaus. Ok, let's see. A.
next prev parent reply other threads:[~2014-12-28 23:34 UTC|newest] Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-12-27 17:52 [PATCH 0/7] Menelaus cleanup for DT, phase 1 Aaro Koskinen 2014-12-27 17:52 ` Aaro Koskinen 2014-12-27 17:52 ` [PATCH 1/7] mfd: menelaus: delete omap_has_menelaus Aaro Koskinen 2014-12-27 17:52 ` Aaro Koskinen 2015-01-20 13:50 ` Lee Jones 2015-01-20 13:50 ` Lee Jones 2014-12-27 17:52 ` [PATCH 2/7] mfd: menelaus: drop support for SW controller VCORE Aaro Koskinen 2014-12-27 17:52 ` Aaro Koskinen 2015-01-20 13:52 ` Lee Jones 2015-01-20 13:52 ` Lee Jones 2014-12-27 17:52 ` [PATCH 3/7] mfd: menelaus: add initial DT support Aaro Koskinen 2014-12-27 17:52 ` Aaro Koskinen 2014-12-27 21:25 ` Felipe Balbi 2014-12-27 21:25 ` Felipe Balbi 2014-12-28 23:34 ` Aaro Koskinen [this message] 2014-12-28 23:34 ` Aaro Koskinen 2014-12-29 18:12 ` Felipe Balbi 2014-12-29 18:12 ` Felipe Balbi 2014-12-27 17:52 ` [PATCH 5/7] mfd: menelaus: delete platform data support Aaro Koskinen 2014-12-27 17:52 ` Aaro Koskinen 2015-01-20 13:54 ` Lee Jones 2015-01-20 13:54 ` Lee Jones 2014-12-27 17:52 ` [PATCH 6/7] mfd: menelaus: make vcore and regulator controls internal Aaro Koskinen 2014-12-27 17:52 ` Aaro Koskinen 2015-01-20 13:58 ` Lee Jones 2015-01-20 13:58 ` Lee Jones 2015-01-20 14:01 ` Lee Jones 2015-01-20 14:01 ` Lee Jones 2014-12-27 17:52 ` [PATCH 7/7] mfd: menelaus: use macro for magic number Aaro Koskinen 2014-12-27 17:52 ` Aaro Koskinen [not found] ` <1419702779-16001-8-git-send-email-aaro.koskinen-X3B1VOXEql0@public.gmane.org> 2015-01-20 14:01 ` Lee Jones 2015-01-20 14:01 ` Lee Jones [not found] ` <1419702779-16001-1-git-send-email-aaro.koskinen-X3B1VOXEql0@public.gmane.org> 2014-12-27 17:52 ` [PATCH 4/7] ARM: OMAP: N8x0: configure menelaus using DT Aaro Koskinen 2014-12-27 17:52 ` Aaro Koskinen 2015-01-20 17:13 ` [PATCH 0/7] Menelaus cleanup for DT, phase 1 Lee Jones 2015-01-20 17:13 ` Lee Jones
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20141228233445.GD582@fuloong-minipc.musicnaut.iki.fi \ --to=aaro.koskinen@iki.fi \ --cc=balbi@ti.com \ --cc=devicetree@vger.kernel.org \ --cc=lee.jones@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-omap@vger.kernel.org \ --cc=sameo@linux.intel.com \ --cc=tony@atomide.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.