[PATCHv2 16/32] metag: copy_thread(): rename 'arg' argument to 'kthread_arg'

From: Alex Dowad <alexinbeijing@gmail.com>
To: james.hogan@imgtec.com
Cc: linux-kernel@vger.kernel.org, linux-metag@vger.kernel.org
Subject: [PATCHv2 16/32] metag: copy_thread(): rename 'arg' argument to 'kthread_arg'
Date: Mon, 16 Mar 2015 15:13:50 +0200	[thread overview]
Message-ID: <1426511630-19370-1-git-send-email-alexinbeijing@gmail.com> (raw)
In-Reply-To: <5506C0E0.80901@imgtec.com>

The 'arg' argument to copy_thread() is only ever used when forking a new
kernel thread. Hence, rename it to 'kthread_arg' for clarity.

Signed-off-by: Alex Dowad <alexinbeijing@gmail.com>
---

James Hogan,

Thanks for reviewing this patch. The comment has been updated as you suggested.

You said: "I'll assume you plan to get all these patches merged together rather than
via individual arch trees..." The truth is that I am as green as green can be and have
no idea how I plan to get these patches merged. I was just reading the Linux source and
saw what looked like an opportunity to make the code a tiny bit easier to read. If you
have any suggestions on how to proceed, please let me know.

Kind regards, Alex Dowad

 arch/metag/kernel/process.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/arch/metag/kernel/process.c b/arch/metag/kernel/process.c
index 483dff9..dcb4609 100644
--- a/arch/metag/kernel/process.c
+++ b/arch/metag/kernel/process.c
@@ -174,8 +174,11 @@ void show_regs(struct pt_regs *regs)
 	show_trace(NULL, (unsigned long *)regs->ctx.AX[0].U0, regs);
 }
 
+/*
+ * Copy architecture-specific thread state
+ */
 int copy_thread(unsigned long clone_flags, unsigned long usp,
-		unsigned long arg, struct task_struct *tsk)
+		unsigned long kthread_arg, struct task_struct *tsk)
 {
 	struct pt_regs *childregs = task_pt_regs(tsk);
 	void *kernel_context = ((void *) childregs +
@@ -204,10 +207,11 @@ int copy_thread(unsigned long clone_flags, unsigned long usp,
 		childregs->ctx.AX[0].U0 = (unsigned long) kernel_context;
-   /* Set D1Ar1=arg and D1RtP=usp (fn) */
+ 	/* Set D1Ar1=kthread_arg and D1RtP=usp (fn) */
 		childregs->ctx.DX[4].U1 = usp;
-		childregs->ctx.DX[3].U1 = arg;
+		childregs->ctx.DX[3].U1 = kthread_arg;
 		tsk->thread.int_depth = 2;
 		return 0;
 	}
+
 	/*
 	 * Get a pointer to where the new child's register block should have
 	 * been pushed.
-- 
2.0.0.GIT

