From: James Hogan <james.hogan@imgtec.com> To: Alex Dowad <alexinbeijing@gmail.com> Cc: <linux-kernel@vger.kernel.org>, <linux-metag@vger.kernel.org> Subject: Re: [PATCHv3 16/32] metag: copy_thread(): rename 'arg' argument to 'kthread_arg' Date: Mon, 16 Mar 2015 14:52:25 +0000 [thread overview] Message-ID: <5506EE29.50802@imgtec.com> (raw) In-Reply-To: <1426516727-20692-1-git-send-email-alexinbeijing@gmail.com> [-- Attachment #1: Type: text/plain, Size: 1779 bytes --] On 16/03/15 14:38, Alex Dowad wrote: > The 'arg' argument to copy_thread() is only ever used when forking a new > kernel thread. Hence, rename it to 'kthread_arg' for clarity. > > Signed-off-by: Alex Dowad <alexinbeijing@gmail.com> > --- > > Fixed problem with whitespace, sending again. AD > > arch/metag/kernel/process.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/arch/metag/kernel/process.c b/arch/metag/kernel/process.c > index 483dff9..dcb4609 100644 > --- a/arch/metag/kernel/process.c > +++ b/arch/metag/kernel/process.c > @@ -174,8 +174,11 @@ void show_regs(struct pt_regs *regs) > show_trace(NULL, (unsigned long *)regs->ctx.AX[0].U0, regs); > } > > +/* > + * Copy architecture-specific thread state > + */ > int copy_thread(unsigned long clone_flags, unsigned long usp, > - unsigned long arg, struct task_struct *tsk) > + unsigned long kthread_arg, struct task_struct *tsk) > { > struct pt_regs *childregs = task_pt_regs(tsk); > void *kernel_context = ((void *) childregs + > @@ -204,10 +207,11 @@ int copy_thread(unsigned long clone_flags, unsigned long usp, > childregs->ctx.AX[0].U0 = (unsigned long) kernel_context; > - /* Set D1Ar1=arg and D1RtP=usp (fn) */ > + /* Set D1Ar1=kthread_arg and D1RtP=usp (fn) */ FYI this still has a space before the tab, and isn't indented to the same level as the surrounding code, but I'll just fix that up when I apply it. Thanks James > childregs->ctx.DX[4].U1 = usp; > - childregs->ctx.DX[3].U1 = arg; > + childregs->ctx.DX[3].U1 = kthread_arg; > tsk->thread.int_depth = 2; > return 0; > } > + > /* > * Get a pointer to where the new child's register block should have > * been pushed. > [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: James Hogan <james.hogan-1AXoQHu6uovQT0dZR+AlfA@public.gmane.org> To: Alex Dowad <alexinbeijing-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-metag-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Subject: Re: [PATCHv3 16/32] metag: copy_thread(): rename 'arg' argument to 'kthread_arg' Date: Mon, 16 Mar 2015 14:52:25 +0000 [thread overview] Message-ID: <5506EE29.50802@imgtec.com> (raw) In-Reply-To: <1426516727-20692-1-git-send-email-alexinbeijing-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> [-- Attachment #1: Type: text/plain, Size: 1809 bytes --] On 16/03/15 14:38, Alex Dowad wrote: > The 'arg' argument to copy_thread() is only ever used when forking a new > kernel thread. Hence, rename it to 'kthread_arg' for clarity. > > Signed-off-by: Alex Dowad <alexinbeijing-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> > --- > > Fixed problem with whitespace, sending again. AD > > arch/metag/kernel/process.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/arch/metag/kernel/process.c b/arch/metag/kernel/process.c > index 483dff9..dcb4609 100644 > --- a/arch/metag/kernel/process.c > +++ b/arch/metag/kernel/process.c > @@ -174,8 +174,11 @@ void show_regs(struct pt_regs *regs) > show_trace(NULL, (unsigned long *)regs->ctx.AX[0].U0, regs); > } > > +/* > + * Copy architecture-specific thread state > + */ > int copy_thread(unsigned long clone_flags, unsigned long usp, > - unsigned long arg, struct task_struct *tsk) > + unsigned long kthread_arg, struct task_struct *tsk) > { > struct pt_regs *childregs = task_pt_regs(tsk); > void *kernel_context = ((void *) childregs + > @@ -204,10 +207,11 @@ int copy_thread(unsigned long clone_flags, unsigned long usp, > childregs->ctx.AX[0].U0 = (unsigned long) kernel_context; > - /* Set D1Ar1=arg and D1RtP=usp (fn) */ > + /* Set D1Ar1=kthread_arg and D1RtP=usp (fn) */ FYI this still has a space before the tab, and isn't indented to the same level as the surrounding code, but I'll just fix that up when I apply it. Thanks James > childregs->ctx.DX[4].U1 = usp; > - childregs->ctx.DX[3].U1 = arg; > + childregs->ctx.DX[3].U1 = kthread_arg; > tsk->thread.int_depth = 2; > return 0; > } > + > /* > * Get a pointer to where the new child's register block should have > * been pushed. > [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-03-16 14:52 UTC|newest] Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-03-13 18:14 [PATCH 11/32] frv: copy_thread(): rename 'arg' argument to 'kthread_arg' Alex Dowad 2015-03-13 18:14 ` [PATCH 12/32] hexagon: " Alex Dowad 2015-03-13 18:14 ` Alex Dowad 2015-03-16 16:25 ` rkuo 2015-03-13 18:14 ` [PATCH 13/32] ia64: copy_thread(): rename 'user_stack_size' " Alex Dowad 2015-03-13 18:14 ` Alex Dowad 2015-03-14 17:54 ` Alex Dowad 2015-03-14 17:54 ` Alex Dowad 2015-03-13 18:14 ` [PATCH 14/32] m32r: copy_thread(): rename 'arg' " Alex Dowad 2015-03-13 18:14 ` [PATCH 15/32] m68k: " Alex Dowad 2015-03-13 18:14 ` Alex Dowad 2015-03-13 18:14 ` [PATCH 16/32] metag: " Alex Dowad 2015-03-13 18:14 ` Alex Dowad 2015-03-16 11:39 ` James Hogan 2015-03-16 11:39 ` James Hogan 2015-03-16 13:13 ` [PATCHv2 " Alex Dowad 2015-03-16 14:31 ` James Hogan 2015-03-16 14:31 ` James Hogan 2015-03-16 14:38 ` Alex Dowad 2015-03-16 14:38 ` [PATCHv3 " Alex Dowad 2015-03-16 14:52 ` James Hogan [this message] 2015-03-16 14:52 ` James Hogan 2015-03-13 18:14 ` [PATCH 17/32] microblaze: " Alex Dowad 2015-03-13 18:14 ` [PATCH 18/32] mips: " Alex Dowad 2015-03-13 18:14 ` Alex Dowad 2015-03-13 18:14 ` [PATCH 19/32] mn10300: copy_thread(): rename 'ustk_size' " Alex Dowad 2015-03-13 18:14 ` [PATCH 20/32] nios2: copy_thread(): rename 'arg' " Alex Dowad 2015-03-13 18:14 ` [PATCH 21/32] openrisc: " Alex Dowad 2015-03-13 18:14 ` [PATCH 22/32] parisc: " Alex Dowad 2015-03-13 18:14 ` [PATCH 23/32] powerpc: " Alex Dowad 2015-03-13 18:14 ` Alex Dowad 2015-03-19 6:45 ` [23/32] " Michael Ellerman 2015-03-19 6:45 ` Michael Ellerman 2015-03-19 7:22 ` Alex Dowad 2015-03-19 7:22 ` Alex Dowad 2015-03-19 23:54 ` Michael Ellerman 2015-03-19 23:54 ` Michael Ellerman 2015-03-24 19:49 ` Alex Dowad 2015-03-24 19:49 ` Alex Dowad 2015-03-25 1:35 ` Michael Ellerman 2015-03-25 1:35 ` Michael Ellerman 2015-03-13 18:14 ` [PATCH 24/32] s390: " Alex Dowad 2015-03-13 18:14 ` Alex Dowad 2015-03-13 18:14 ` [PATCH 25/32] score: " Alex Dowad 2015-03-13 18:14 ` [PATCH 26/32] sh: " Alex Dowad 2015-03-13 18:14 ` Alex Dowad 2015-03-13 18:14 ` [PATCH 27/32] sparc: " Alex Dowad 2015-03-13 18:14 ` Alex Dowad 2015-03-13 18:14 ` [PATCH 28/32] tile: " Alex Dowad 2015-03-16 20:19 ` Chris Metcalf 2015-03-16 20:44 ` Alex Dowad 2015-03-19 18:06 ` Chris Metcalf 2015-03-13 18:14 ` [PATCH 29/32] um: " Alex Dowad 2015-03-13 18:14 ` [PATCH 30/32] unicore32: copy_thread(): rename 'stk_sz' " Alex Dowad 2015-03-13 18:14 ` [PATCH 31/32] x86: copy_thread(): rename 'arg' " Alex Dowad 2015-03-13 18:14 ` [PATCH 32/32] xtensa: " Alex Dowad
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=5506EE29.50802@imgtec.com \ --to=james.hogan@imgtec.com \ --cc=alexinbeijing@gmail.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-metag@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.