From: Alex Dowad <alexinbeijing@gmail.com> To: linux-kernel@vger.kernel.org Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>, Paul Mackerras <paulus@samba.org>, Michael Ellerman <mpe@ellerman.id.au>, Anton Blanchard <anton@samba.org>, Paul Gortmaker <paul.gortmaker@windriver.com>, Christoph Lameter <cl@linux.com>, Michael Neuling <mikey@neuling.org>, Vineeth Vijayan <vvijayan@mvista.com>, linuxppc-dev@lists.ozlabs.org (open list:LINUX FOR POWERPC...) Subject: [PATCH 23/32] powerpc: copy_thread(): rename 'arg' argument to 'kthread_arg' Date: Fri, 13 Mar 2015 20:14:46 +0200 [thread overview] Message-ID: <1426270496-26362-13-git-send-email-alexinbeijing@gmail.com> (raw) In-Reply-To: <1426270496-26362-1-git-send-email-alexinbeijing@gmail.com> The 'arg' argument to copy_thread() is only ever used when forking a new kernel thread. Hence, rename it to 'kthread_arg' for clarity (and consistency with do_fork() and other arch-specific implementations of copy_thread()). Signed-off-by: Alex Dowad <alexinbeijing@gmail.com> --- arch/powerpc/kernel/process.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/arch/powerpc/kernel/process.c b/arch/powerpc/kernel/process.c index b4cc7be..febb50d 100644 --- a/arch/powerpc/kernel/process.c +++ b/arch/powerpc/kernel/process.c @@ -1114,8 +1114,11 @@ static void setup_ksp_vsid(struct task_struct *p, unsigned long sp) */ extern unsigned long dscr_default; /* defined in arch/powerpc/kernel/sysfs.c */ +/* + * Copy architecture-specific thread state + */ int copy_thread(unsigned long clone_flags, unsigned long usp, - unsigned long arg, struct task_struct *p) + unsigned long kthread_arg, struct task_struct *p) { struct pt_regs *childregs, *kregs; extern void ret_from_fork(void); @@ -1127,6 +1130,7 @@ int copy_thread(unsigned long clone_flags, unsigned long usp, sp -= sizeof(struct pt_regs); childregs = (struct pt_regs *) sp; if (unlikely(p->flags & PF_KTHREAD)) { + /* kernel thread */ struct thread_info *ti = (void *)task_stack_page(p); memset(childregs, 0, sizeof(struct pt_regs)); childregs->gpr[1] = sp + sizeof(struct pt_regs); @@ -1137,11 +1141,12 @@ int copy_thread(unsigned long clone_flags, unsigned long usp, clear_tsk_thread_flag(p, TIF_32BIT); childregs->softe = 1; #endif - childregs->gpr[15] = arg; + childregs->gpr[15] = kthread_arg; p->thread.regs = NULL; /* no user register state */ ti->flags |= _TIF_RESTOREALL; f = ret_from_kernel_thread; } else { + /* user thread */ struct pt_regs *regs = current_pt_regs(); CHECK_FULL_REGS(regs); *childregs = *regs; -- 2.0.0.GIT
WARNING: multiple messages have this Message-ID (diff)
From: Alex Dowad <alexinbeijing@gmail.com> To: linux-kernel@vger.kernel.org Cc: Michael Neuling <mikey@neuling.org>, Paul Gortmaker <paul.gortmaker@windriver.com>, Paul Mackerras <paulus@samba.org>, Anton Blanchard <anton@samba.org>, Vineeth Vijayan <vvijayan@mvista.com>, Christoph Lameter <cl@linux.com>, "open list:LINUX FOR POWERPC..." <linuxppc-dev@lists.ozlabs.org> Subject: [PATCH 23/32] powerpc: copy_thread(): rename 'arg' argument to 'kthread_arg' Date: Fri, 13 Mar 2015 20:14:46 +0200 [thread overview] Message-ID: <1426270496-26362-13-git-send-email-alexinbeijing@gmail.com> (raw) In-Reply-To: <1426270496-26362-1-git-send-email-alexinbeijing@gmail.com> The 'arg' argument to copy_thread() is only ever used when forking a new kernel thread. Hence, rename it to 'kthread_arg' for clarity (and consistency with do_fork() and other arch-specific implementations of copy_thread()). Signed-off-by: Alex Dowad <alexinbeijing@gmail.com> --- arch/powerpc/kernel/process.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/arch/powerpc/kernel/process.c b/arch/powerpc/kernel/process.c index b4cc7be..febb50d 100644 --- a/arch/powerpc/kernel/process.c +++ b/arch/powerpc/kernel/process.c @@ -1114,8 +1114,11 @@ static void setup_ksp_vsid(struct task_struct *p, unsigned long sp) */ extern unsigned long dscr_default; /* defined in arch/powerpc/kernel/sysfs.c */ +/* + * Copy architecture-specific thread state + */ int copy_thread(unsigned long clone_flags, unsigned long usp, - unsigned long arg, struct task_struct *p) + unsigned long kthread_arg, struct task_struct *p) { struct pt_regs *childregs, *kregs; extern void ret_from_fork(void); @@ -1127,6 +1130,7 @@ int copy_thread(unsigned long clone_flags, unsigned long usp, sp -= sizeof(struct pt_regs); childregs = (struct pt_regs *) sp; if (unlikely(p->flags & PF_KTHREAD)) { + /* kernel thread */ struct thread_info *ti = (void *)task_stack_page(p); memset(childregs, 0, sizeof(struct pt_regs)); childregs->gpr[1] = sp + sizeof(struct pt_regs); @@ -1137,11 +1141,12 @@ int copy_thread(unsigned long clone_flags, unsigned long usp, clear_tsk_thread_flag(p, TIF_32BIT); childregs->softe = 1; #endif - childregs->gpr[15] = arg; + childregs->gpr[15] = kthread_arg; p->thread.regs = NULL; /* no user register state */ ti->flags |= _TIF_RESTOREALL; f = ret_from_kernel_thread; } else { + /* user thread */ struct pt_regs *regs = current_pt_regs(); CHECK_FULL_REGS(regs); *childregs = *regs; -- 2.0.0.GIT
next prev parent reply other threads:[~2015-03-13 18:16 UTC|newest] Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-03-13 18:14 [PATCH 11/32] frv: copy_thread(): rename 'arg' argument to 'kthread_arg' Alex Dowad 2015-03-13 18:14 ` [PATCH 12/32] hexagon: " Alex Dowad 2015-03-13 18:14 ` Alex Dowad 2015-03-16 16:25 ` rkuo 2015-03-13 18:14 ` [PATCH 13/32] ia64: copy_thread(): rename 'user_stack_size' " Alex Dowad 2015-03-13 18:14 ` Alex Dowad 2015-03-14 17:54 ` Alex Dowad 2015-03-14 17:54 ` Alex Dowad 2015-03-13 18:14 ` [PATCH 14/32] m32r: copy_thread(): rename 'arg' " Alex Dowad 2015-03-13 18:14 ` [PATCH 15/32] m68k: " Alex Dowad 2015-03-13 18:14 ` Alex Dowad 2015-03-13 18:14 ` [PATCH 16/32] metag: " Alex Dowad 2015-03-13 18:14 ` Alex Dowad 2015-03-16 11:39 ` James Hogan 2015-03-16 11:39 ` James Hogan 2015-03-16 13:13 ` [PATCHv2 " Alex Dowad 2015-03-16 14:31 ` James Hogan 2015-03-16 14:31 ` James Hogan 2015-03-16 14:38 ` Alex Dowad 2015-03-16 14:38 ` [PATCHv3 " Alex Dowad 2015-03-16 14:52 ` James Hogan 2015-03-16 14:52 ` James Hogan 2015-03-13 18:14 ` [PATCH 17/32] microblaze: " Alex Dowad 2015-03-13 18:14 ` [PATCH 18/32] mips: " Alex Dowad 2015-03-13 18:14 ` Alex Dowad 2015-03-13 18:14 ` [PATCH 19/32] mn10300: copy_thread(): rename 'ustk_size' " Alex Dowad 2015-03-13 18:14 ` [PATCH 20/32] nios2: copy_thread(): rename 'arg' " Alex Dowad 2015-03-13 18:14 ` [PATCH 21/32] openrisc: " Alex Dowad 2015-03-13 18:14 ` [PATCH 22/32] parisc: " Alex Dowad 2015-03-13 18:14 ` Alex Dowad [this message] 2015-03-13 18:14 ` [PATCH 23/32] powerpc: " Alex Dowad 2015-03-19 6:45 ` [23/32] " Michael Ellerman 2015-03-19 6:45 ` Michael Ellerman 2015-03-19 7:22 ` Alex Dowad 2015-03-19 7:22 ` Alex Dowad 2015-03-19 23:54 ` Michael Ellerman 2015-03-19 23:54 ` Michael Ellerman 2015-03-24 19:49 ` Alex Dowad 2015-03-24 19:49 ` Alex Dowad 2015-03-25 1:35 ` Michael Ellerman 2015-03-25 1:35 ` Michael Ellerman 2015-03-13 18:14 ` [PATCH 24/32] s390: " Alex Dowad 2015-03-13 18:14 ` Alex Dowad 2015-03-13 18:14 ` [PATCH 25/32] score: " Alex Dowad 2015-03-13 18:14 ` [PATCH 26/32] sh: " Alex Dowad 2015-03-13 18:14 ` Alex Dowad 2015-03-13 18:14 ` [PATCH 27/32] sparc: " Alex Dowad 2015-03-13 18:14 ` Alex Dowad 2015-03-13 18:14 ` [PATCH 28/32] tile: " Alex Dowad 2015-03-16 20:19 ` Chris Metcalf 2015-03-16 20:44 ` Alex Dowad 2015-03-19 18:06 ` Chris Metcalf 2015-03-13 18:14 ` [PATCH 29/32] um: " Alex Dowad 2015-03-13 18:14 ` [PATCH 30/32] unicore32: copy_thread(): rename 'stk_sz' " Alex Dowad 2015-03-13 18:14 ` [PATCH 31/32] x86: copy_thread(): rename 'arg' " Alex Dowad 2015-03-13 18:14 ` [PATCH 32/32] xtensa: " Alex Dowad
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1426270496-26362-13-git-send-email-alexinbeijing@gmail.com \ --to=alexinbeijing@gmail.com \ --cc=anton@samba.org \ --cc=benh@kernel.crashing.org \ --cc=cl@linux.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linuxppc-dev@lists.ozlabs.org \ --cc=mikey@neuling.org \ --cc=mpe@ellerman.id.au \ --cc=paul.gortmaker@windriver.com \ --cc=paulus@samba.org \ --cc=vvijayan@mvista.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.