From: Paul Bolle <pebolle@tiscali.nl> To: Alexandre Belloni <alexandre.belloni@free-electrons.com> Cc: Nicolas Ferre <nicolas.ferre@atmel.com>, Mark Brown <broonie@kernel.org>, Arnd Bergmann <arnd@arndb.de>, alsa-devel@alsa-project.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] ASoC: atmel: compile pcm driver in snd-soc-atmel_ssc_dai Date: Wed, 27 May 2015 09:50:24 +0200 [thread overview] Message-ID: <1432713024.27695.235.camel@x220> (raw) In-Reply-To: <1432591459-22613-2-git-send-email-alexandre.belloni@free-electrons.com> Now that this patch is already applied my remarks can only be addressed in a follow up patch. (Perhaps such a patch is already queued.) On Tue, 2015-05-26 at 00:04 +0200, Alexandre Belloni wrote: > --- a/sound/soc/atmel/Kconfig > +++ b/sound/soc/atmel/Kconfig > config SND_ATMEL_SOC_PDC > - tristate > + bool > > config SND_ATMEL_SOC_DMA > - tristate > + bool > select SND_SOC_GENERIC_DMAENGINE_PCM > --- a/sound/soc/atmel/Makefile > +++ b/sound/soc/atmel/Makefile > -snd-soc-atmel-pcm-pdc-objs := atmel-pcm-pdc.o > -snd-soc-atmel-pcm-dma-objs := atmel-pcm-dma.o > -snd-soc-atmel_ssc_dai-objs := atmel_ssc_dai.o > +snd-soc-atmel-pcm-$(CONFIG_SND_ATMEL_SOC_PDC) := atmel-pcm-pdc.o > +snd-soc-atmel-pcm-$(CONFIG_SND_ATMEL_SOC_DMA) += atmel-pcm-dma.o > +snd-soc-atmel_ssc_dai-objs := atmel_ssc_dai.o $(snd-soc-atmel-pcm-y) > > -obj-$(CONFIG_SND_ATMEL_SOC_PDC) += snd-soc-atmel-pcm-pdc.o > -obj-$(CONFIG_SND_ATMEL_SOC_DMA) += snd-soc-atmel-pcm-dma.o > obj-$(CONFIG_SND_ATMEL_SOC_SSC) += snd-soc-atmel_ssc_dai.o The code in atmel-pcm-pdc.c and atmel-pcm-dma.c will now either be part of the snd-soc-atmel_ssc_dai.ko or be built-in. That means, I think, that: - the (in total) four uses of EXPORT_SYMBOL() in these two files can be dropped; - MODULE_AUTHOR() and friends, and probably also the include of linux/module.h, can be dropped from these two files. Furthermore, the references to CONFIG_SND_ATMEL_SOC_PDC_MODULE and CONFIG_SND_ATMEL_SOC_DMA_MODULE in atmel-pcm.h can be removed now. Thanks, Paul Bolle
WARNING: multiple messages have this Message-ID (diff)
From: pebolle@tiscali.nl (Paul Bolle) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 2/2] ASoC: atmel: compile pcm driver in snd-soc-atmel_ssc_dai Date: Wed, 27 May 2015 09:50:24 +0200 [thread overview] Message-ID: <1432713024.27695.235.camel@x220> (raw) In-Reply-To: <1432591459-22613-2-git-send-email-alexandre.belloni@free-electrons.com> Now that this patch is already applied my remarks can only be addressed in a follow up patch. (Perhaps such a patch is already queued.) On Tue, 2015-05-26 at 00:04 +0200, Alexandre Belloni wrote: > --- a/sound/soc/atmel/Kconfig > +++ b/sound/soc/atmel/Kconfig > config SND_ATMEL_SOC_PDC > - tristate > + bool > > config SND_ATMEL_SOC_DMA > - tristate > + bool > select SND_SOC_GENERIC_DMAENGINE_PCM > --- a/sound/soc/atmel/Makefile > +++ b/sound/soc/atmel/Makefile > -snd-soc-atmel-pcm-pdc-objs := atmel-pcm-pdc.o > -snd-soc-atmel-pcm-dma-objs := atmel-pcm-dma.o > -snd-soc-atmel_ssc_dai-objs := atmel_ssc_dai.o > +snd-soc-atmel-pcm-$(CONFIG_SND_ATMEL_SOC_PDC) := atmel-pcm-pdc.o > +snd-soc-atmel-pcm-$(CONFIG_SND_ATMEL_SOC_DMA) += atmel-pcm-dma.o > +snd-soc-atmel_ssc_dai-objs := atmel_ssc_dai.o $(snd-soc-atmel-pcm-y) > > -obj-$(CONFIG_SND_ATMEL_SOC_PDC) += snd-soc-atmel-pcm-pdc.o > -obj-$(CONFIG_SND_ATMEL_SOC_DMA) += snd-soc-atmel-pcm-dma.o > obj-$(CONFIG_SND_ATMEL_SOC_SSC) += snd-soc-atmel_ssc_dai.o The code in atmel-pcm-pdc.c and atmel-pcm-dma.c will now either be part of the snd-soc-atmel_ssc_dai.ko or be built-in. That means, I think, that: - the (in total) four uses of EXPORT_SYMBOL() in these two files can be dropped; - MODULE_AUTHOR() and friends, and probably also the include of linux/module.h, can be dropped from these two files. Furthermore, the references to CONFIG_SND_ATMEL_SOC_PDC_MODULE and CONFIG_SND_ATMEL_SOC_DMA_MODULE in atmel-pcm.h can be removed now. Thanks, Paul Bolle
next prev parent reply other threads:[~2015-05-27 7:50 UTC|newest] Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-05-25 22:04 [PATCH 1/2] ASoC: atmel: simplify Kconfig Alexandre Belloni 2015-05-25 22:04 ` Alexandre Belloni 2015-05-25 22:04 ` [PATCH 2/2] ASoC: atmel: compile pcm driver in snd-soc-atmel_ssc_dai Alexandre Belloni 2015-05-25 22:04 ` Alexandre Belloni 2015-05-26 9:53 ` Mark Brown 2015-05-26 9:53 ` Mark Brown 2015-05-26 9:53 ` Mark Brown 2015-05-26 10:14 ` Nicolas Ferre 2015-05-26 10:14 ` Nicolas Ferre 2015-05-26 10:14 ` Nicolas Ferre 2015-05-26 10:53 ` Arnd Bergmann 2015-05-26 10:53 ` Arnd Bergmann 2015-05-26 10:53 ` Arnd Bergmann 2015-05-27 7:50 ` Paul Bolle [this message] 2015-05-27 7:50 ` Paul Bolle 2015-05-27 9:19 ` Alexandre Belloni 2015-05-27 9:19 ` Alexandre Belloni 2015-05-27 9:25 ` Paul Bolle 2015-05-27 9:25 ` Paul Bolle 2015-05-28 9:36 ` Alexandre Belloni 2015-05-28 9:36 ` Alexandre Belloni 2015-05-26 9:53 ` [PATCH 1/2] ASoC: atmel: simplify Kconfig Mark Brown 2015-05-26 9:53 ` Mark Brown 2015-05-26 9:53 ` Mark Brown 2015-05-26 10:13 ` Nicolas Ferre 2015-05-26 10:13 ` Nicolas Ferre 2015-05-26 10:13 ` Nicolas Ferre
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1432713024.27695.235.camel@x220 \ --to=pebolle@tiscali.nl \ --cc=alexandre.belloni@free-electrons.com \ --cc=alsa-devel@alsa-project.org \ --cc=arnd@arndb.de \ --cc=broonie@kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=nicolas.ferre@atmel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.