From: Benjamin Herrenschmidt <benh-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org> To: Bjorn Helgaas <bhelgaas-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org> Cc: Gavin Shan <gwshan-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>, linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, aik-sLpHqDYs0B2HXe+LvDLADg@public.gmane.org, panto-wVdstyuyKrO8r51toPun2/C9HSW9iNxf@public.gmane.org, robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org Subject: Re: [PATCH v5 42/42] pci/hotplug: PowerPC PowerNV PCI hotplug driver Date: Sat, 06 Jun 2015 06:18:15 +1000 [thread overview] Message-ID: <1433535495.4526.107.camel@kernel.crashing.org> (raw) In-Reply-To: <20150605201110.GP3631-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org> On Fri, 2015-06-05 at 15:11 -0500, Bjorn Helgaas wrote: > You didn't add this, but "pcibios_add_pci_devices" doesn't seem like the > right name. "pcibios" generally refers to an arch-specific hook that's > called by the generic PCI core. In this case, pcibios_add_pci_devices() > contains powerpc-specific code, and it's only called from powerpc code, so > I think using "pcibios_" in the name is a bit misleading. Maybe but just calling it pci_add_* makes it easy to confuse with a core function and ppc_add_* is gross :-) > > + /* Remove all devices behind the slot */ > > + pci_lock_rescan_remove(); > > + pcibios_remove_pci_devices(slot->bus); > > Same comment for pcibios_remove_pci_devices(). It would be better if the > name didn't suggest that this was part of the pcibios_ interface between > the PCI core and the arch code, because it's not. > > > + /* Slot indentifier */ > > s/indentifier/identifier/ > > > + if (!php_slot_get_id(dn, &id)) > > + return NULL; > > + > > > + /* PCI bus */ > > + bus = pcibios_find_pci_bus(dn); > > And pcibios_find_pci_bus() (it's also powerpc-specific). This one could actually move to of_pci.c and be generic, something like of_pci_node_to_bus() Ben. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Benjamin Herrenschmidt <benh@kernel.crashing.org> To: Bjorn Helgaas <bhelgaas@google.com> Cc: Gavin Shan <gwshan@linux.vnet.ibm.com>, linuxppc-dev@lists.ozlabs.org, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, aik@ozlabs.ru, panto@antoniou-consulting.com, robherring2@gmail.com, grant.likely@linaro.org Subject: Re: [PATCH v5 42/42] pci/hotplug: PowerPC PowerNV PCI hotplug driver Date: Sat, 06 Jun 2015 06:18:15 +1000 [thread overview] Message-ID: <1433535495.4526.107.camel@kernel.crashing.org> (raw) In-Reply-To: <20150605201110.GP3631@google.com> On Fri, 2015-06-05 at 15:11 -0500, Bjorn Helgaas wrote: > You didn't add this, but "pcibios_add_pci_devices" doesn't seem like the > right name. "pcibios" generally refers to an arch-specific hook that's > called by the generic PCI core. In this case, pcibios_add_pci_devices() > contains powerpc-specific code, and it's only called from powerpc code, so > I think using "pcibios_" in the name is a bit misleading. Maybe but just calling it pci_add_* makes it easy to confuse with a core function and ppc_add_* is gross :-) > > + /* Remove all devices behind the slot */ > > + pci_lock_rescan_remove(); > > + pcibios_remove_pci_devices(slot->bus); > > Same comment for pcibios_remove_pci_devices(). It would be better if the > name didn't suggest that this was part of the pcibios_ interface between > the PCI core and the arch code, because it's not. > > > + /* Slot indentifier */ > > s/indentifier/identifier/ > > > + if (!php_slot_get_id(dn, &id)) > > + return NULL; > > + > > > + /* PCI bus */ > > + bus = pcibios_find_pci_bus(dn); > > And pcibios_find_pci_bus() (it's also powerpc-specific). This one could actually move to of_pci.c and be generic, something like of_pci_node_to_bus() Ben.
next prev parent reply other threads:[~2015-06-05 20:18 UTC|newest] Thread overview: 83+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-06-04 6:41 [PATCH v5 00/42] PowerPC/PowerNV: PCI Slot Management Gavin Shan 2015-06-04 6:41 ` [PATCH v5 01/42] PCI: Add pcibios_setup_bridge() Gavin Shan 2015-06-05 19:44 ` Bjorn Helgaas 2015-06-09 5:49 ` Gavin Shan 2015-06-04 6:41 ` [PATCH v5 02/42] powerpc/powernv: Enable M64 on P7IOC Gavin Shan 2015-06-04 6:41 ` [PATCH v5 03/42] powerpc/powernv: M64 support improvement Gavin Shan 2015-06-04 6:41 ` [PATCH v5 07/42] powerpc/powernv: Calculate PHB's DMA weight dynamically Gavin Shan 2015-06-04 6:41 ` [PATCH v5 08/42] powerpc/powernv: DMA32 cleanup Gavin Shan 2015-06-10 4:17 ` Alexey Kardashevskiy 2015-06-10 6:12 ` Gavin Shan 2015-06-04 6:41 ` [PATCH v5 09/42] powerpc/powernv: pnv_ioda_setup_dma() configure one PE only Gavin Shan 2015-06-04 6:41 ` [PATCH v5 11/42] powerpc/powernv: Increase PE# capacity Gavin Shan 2015-06-10 4:41 ` Alexey Kardashevskiy 2015-06-10 6:18 ` Gavin Shan 2015-06-04 6:41 ` [PATCH v5 12/42] powerpc/pci: Cleanup on pci_controller_ops Gavin Shan 2015-06-10 4:43 ` Alexey Kardashevskiy 2015-06-10 6:20 ` Gavin Shan 2015-06-10 6:20 ` Gavin Shan 2015-06-04 6:41 ` [PATCH v5 14/42] powerpc/powernv: Allocate PE# in deasending order Gavin Shan 2015-06-04 6:41 ` [PATCH v5 17/42] powerpc/powernv: PE oriented during configuration Gavin Shan 2015-06-04 6:41 ` [PATCH v5 19/42] powerpc/powernv: Remove DMA32 list of PEs Gavin Shan 2015-06-04 6:41 ` [PATCH v5 20/42] powerpc/powernv: Rename pnv_ioda_get_pe() to pnv_ioda_dev_to_pe() Gavin Shan 2015-06-04 6:41 ` [PATCH v5 21/42] powerpc/powernv: Drop pnv_ioda_setup_dev_PE() Gavin Shan [not found] ` <1433400131-18429-1-git-send-email-gwshan-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org> 2015-06-04 6:41 ` [PATCH v5 04/42] powerpc/powernv: Trace consumed IO and M32 segments by PE Gavin Shan 2015-06-04 6:41 ` Gavin Shan 2015-06-04 6:41 ` [PATCH v5 05/42] powerpc/powernv: Simplify pnv_ioda_setup_pe_seg() Gavin Shan 2015-06-04 6:41 ` Gavin Shan 2015-06-04 6:41 ` [PATCH v5 06/42] powerpc/powernv: Improve IO and M32 mapping Gavin Shan 2015-06-04 6:41 ` Gavin Shan 2015-06-04 6:41 ` [PATCH v5 10/42] powerpc/powernv: Trace DMA32 segments consumed by PE Gavin Shan 2015-06-04 6:41 ` Gavin Shan 2015-06-04 6:41 ` [PATCH v5 13/42] powerpc/pci: Override pcibios_setup_bridge() Gavin Shan 2015-06-04 6:41 ` Gavin Shan 2015-06-04 6:41 ` [PATCH v5 15/42] powerpc/powernv: Reserve PE# for root bus Gavin Shan 2015-06-04 6:41 ` Gavin Shan 2015-06-04 6:41 ` [PATCH v5 16/42] powerpc/powernv: Create PEs dynamically Gavin Shan 2015-06-04 6:41 ` Gavin Shan 2015-06-04 6:41 ` [PATCH v5 18/42] powerpc/powernv: Helper function pnv_ioda_init_pe() Gavin Shan 2015-06-04 6:41 ` Gavin Shan 2015-06-04 6:41 ` [PATCH v5 22/42] powerpc/powernv: Move functions around Gavin Shan 2015-06-04 6:41 ` Gavin Shan 2015-06-04 6:41 ` [PATCH v5 24/42] powerpc/powernv: Release PEs dynamically Gavin Shan 2015-06-04 6:41 ` Gavin Shan 2015-06-04 6:42 ` [PATCH v5 34/42] powerpc/pci: Delay creating pci_dn Gavin Shan 2015-06-04 6:42 ` Gavin Shan 2015-06-04 6:42 ` [PATCH v5 36/42] powerpc/pci: Export traverse_pci_device_nodes() Gavin Shan 2015-06-04 6:42 ` Gavin Shan 2015-06-04 6:42 ` [PATCH v5 39/42] drivers/of: Unflatten nodes equal or deeper than specified level Gavin Shan 2015-06-04 6:42 ` Gavin Shan [not found] ` <1433400131-18429-40-git-send-email-gwshan-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org> 2015-06-30 17:47 ` Grant Likely 2015-06-30 17:47 ` Grant Likely 2015-06-04 6:41 ` [PATCH v5 23/42] powerpc/powernv: Cleanup on pnv_pci_ioda2_release_dma_pe() Gavin Shan 2015-06-04 6:41 ` [PATCH v5 25/42] powerpc/powernv: Supports slot ID Gavin Shan 2015-06-04 6:41 ` [PATCH v5 26/42] powerpc/powernv: Use PCI slot reset infrastructure Gavin Shan 2015-06-04 6:41 ` [PATCH v5 27/42] powerpc/powernv: Simplify pnv_eeh_reset() Gavin Shan 2015-06-04 6:41 ` [PATCH v5 28/42] powerpc/powernv: Don't cover root bus in pnv_pci_reset_secondary_bus() Gavin Shan 2015-06-04 6:41 ` [PATCH v5 29/42] powerpc/powernv: Issue fundamental reset " Gavin Shan 2015-06-04 6:41 ` [PATCH v5 30/42] powerpc/pci: Don't scan empty slot Gavin Shan 2015-06-04 6:42 ` [PATCH v5 31/42] powerpc/pci: Move pcibios_find_pci_bus() around Gavin Shan 2015-06-05 19:47 ` Bjorn Helgaas 2015-06-09 6:10 ` Gavin Shan 2015-06-04 6:42 ` [PATCH v5 32/42] powerpc/powernv: Introduce pnv_pci_poll() Gavin Shan 2015-06-04 6:42 ` [PATCH v5 33/42] powerpc/powernv: Functions to get/reset PCI slot status Gavin Shan 2015-06-04 6:42 ` [PATCH v5 35/42] powerpc/pci: Create eeh_dev while creating pci_dn Gavin Shan 2015-06-04 6:42 ` [PATCH v5 37/42] powerpc/pci: Update bridge windows on PCI plugging Gavin Shan 2015-06-04 6:42 ` [PATCH v5 38/42] powerpc/powernv: Select OF_OVERLAY Gavin Shan 2015-06-04 6:42 ` [PATCH v5 40/42] drivers/of: Allow to specify root node in of_fdt_unflatten_tree() Gavin Shan 2015-06-04 22:10 ` Rob Herring [not found] ` <1433400131-18429-41-git-send-email-gwshan-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org> 2015-06-30 18:06 ` Grant Likely 2015-06-30 18:06 ` Grant Likely [not found] ` <20150630180652.198E2C4063C-WNowdnHR2B42iJbIjFUEsiwD8/FfD2ys@public.gmane.org> 2015-06-30 21:46 ` Benjamin Herrenschmidt 2015-06-30 21:46 ` Benjamin Herrenschmidt 2015-06-04 6:42 ` [PATCH v5 41/42] drivers/of: Return allocated memory chunk from of_fdt_unflatten_tree() Gavin Shan 2015-06-04 6:42 ` [PATCH v5 42/42] pci/hotplug: PowerPC PowerNV PCI hotplug driver Gavin Shan [not found] ` <1433400131-18429-43-git-send-email-gwshan-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org> 2015-06-05 20:11 ` Bjorn Helgaas 2015-06-05 20:11 ` Bjorn Helgaas [not found] ` <20150605201110.GP3631-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org> 2015-06-05 20:18 ` Benjamin Herrenschmidt [this message] 2015-06-05 20:18 ` Benjamin Herrenschmidt 2015-06-09 6:10 ` Gavin Shan 2015-06-09 6:08 ` Gavin Shan 2015-06-30 18:18 ` Grant Likely 2015-06-30 18:18 ` Grant Likely 2015-07-01 0:51 ` Gavin Shan
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1433535495.4526.107.camel@kernel.crashing.org \ --to=benh-xvmvhmargas8u2djnn8i7kb+6bgklq7r@public.gmane.org \ --cc=aik-sLpHqDYs0B2HXe+LvDLADg@public.gmane.org \ --cc=bhelgaas-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \ --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \ --cc=gwshan-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org \ --cc=linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \ --cc=panto-wVdstyuyKrO8r51toPun2/C9HSW9iNxf@public.gmane.org \ --cc=robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.