From: Jaegeuk Kim <jaegeuk@kernel.org> To: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Cc: Jaegeuk Kim <jaegeuk@kernel.org> Subject: [PATCH 01/12] f2fs: avoid freed stat information Date: Mon, 29 Jun 2015 11:39:25 -0700 [thread overview] Message-ID: <1435603176-63219-1-git-send-email-jaegeuk@kernel.org> (raw) The write_checkpoint can update stat information, so we should destroy the stat structure after it. Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org> --- fs/f2fs/super.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c index a06b0b4..da27710 100644 --- a/fs/f2fs/super.c +++ b/fs/f2fs/super.c @@ -498,7 +498,6 @@ static void f2fs_put_super(struct super_block *sb) } kobject_del(&sbi->s_kobj); - f2fs_destroy_stats(sbi); stop_gc_thread(sbi); /* @@ -514,6 +513,9 @@ static void f2fs_put_super(struct super_block *sb) write_checkpoint(sbi, &cpc); } + /* write_checkpoint can update stat informaion */ + f2fs_destroy_stats(sbi); + /* * normally superblock is clean, so we need to release this. * In addition, EIO will skip do checkpoint, we need this as well. -- 2.1.1
WARNING: multiple messages have this Message-ID (diff)
From: Jaegeuk Kim <jaegeuk@kernel.org> To: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Cc: Jaegeuk Kim <jaegeuk@kernel.org> Subject: [PATCH 01/12] f2fs: avoid freed stat information Date: Mon, 29 Jun 2015 11:39:25 -0700 [thread overview] Message-ID: <1435603176-63219-1-git-send-email-jaegeuk@kernel.org> (raw) The write_checkpoint can update stat information, so we should destroy the stat structure after it. Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org> --- fs/f2fs/super.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c index a06b0b4..da27710 100644 --- a/fs/f2fs/super.c +++ b/fs/f2fs/super.c @@ -498,7 +498,6 @@ static void f2fs_put_super(struct super_block *sb) } kobject_del(&sbi->s_kobj); - f2fs_destroy_stats(sbi); stop_gc_thread(sbi); /* @@ -514,6 +513,9 @@ static void f2fs_put_super(struct super_block *sb) write_checkpoint(sbi, &cpc); } + /* write_checkpoint can update stat informaion */ + f2fs_destroy_stats(sbi); + /* * normally superblock is clean, so we need to release this. * In addition, EIO will skip do checkpoint, we need this as well. -- 2.1.1 ------------------------------------------------------------------------------ Don't Limit Your Business. Reach for the Cloud. GigeNET's Cloud Solutions provide you with the tools and support that you need to offload your IT needs and focus on growing your business. Configured For All Businesses. Start Your Cloud Today. https://www.gigenetcloud.com/
next reply other threads:[~2015-06-29 18:39 UTC|newest] Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-06-29 18:39 Jaegeuk Kim [this message] 2015-06-29 18:39 ` [PATCH 01/12] f2fs: avoid freed stat information Jaegeuk Kim 2015-06-29 18:39 ` [PATCH 02/12] f2fs: avoid to use failed inode immediately Jaegeuk Kim 2015-06-29 18:39 ` Jaegeuk Kim 2015-06-30 2:54 ` [f2fs-dev] " Chao Yu 2015-06-29 18:39 ` [PATCH 03/12] f2fs: convert inline_data for various fallocate Jaegeuk Kim 2015-06-29 18:39 ` Jaegeuk Kim 2015-06-30 2:58 ` [f2fs-dev] " Chao Yu 2015-06-29 18:39 ` [PATCH 04/12] f2fs: remove wrong f2fs_bug_on when merging extents Jaegeuk Kim 2015-06-29 18:39 ` Jaegeuk Kim 2015-06-30 3:00 ` [f2fs-dev] " Chao Yu 2015-06-30 3:00 ` Chao Yu 2015-07-01 1:02 ` [f2fs-dev] " Jaegeuk Kim 2015-06-29 18:39 ` [PATCH 05/12] f2fs: fix wrong block address calculation for a split extent Jaegeuk Kim 2015-06-29 18:39 ` Jaegeuk Kim 2015-06-30 3:08 ` [f2fs-dev] " Chao Yu 2015-06-30 3:08 ` Chao Yu 2015-06-29 18:39 ` [PATCH 06/12] f2fs: update on-disk extents even under extent_cache Jaegeuk Kim 2015-06-29 18:39 ` Jaegeuk Kim 2015-06-30 3:10 ` [f2fs-dev] " Chao Yu 2015-06-29 18:39 ` [PATCH 07/12] f2fs: set cached_en after checking finally Jaegeuk Kim 2015-06-30 3:26 ` [f2fs-dev] " Chao Yu 2015-06-30 3:26 ` Chao Yu 2015-06-29 18:39 ` [PATCH 08/12] f2fs: introduce a shrinker for mounted fs Jaegeuk Kim 2015-06-29 18:39 ` Jaegeuk Kim 2015-06-30 3:43 ` [f2fs-dev] " Chao Yu 2015-06-30 3:43 ` Chao Yu 2015-07-01 1:28 ` [f2fs-dev] " Jaegeuk Kim 2015-07-02 12:32 ` Chao Yu 2015-07-02 12:32 ` Chao Yu 2015-07-04 4:51 ` [f2fs-dev] " Jaegeuk Kim 2015-07-04 4:51 ` Jaegeuk Kim 2015-06-29 18:39 ` [PATCH 09/12] f2fs: shrink nat_cache entries Jaegeuk Kim 2015-06-29 18:39 ` Jaegeuk Kim 2015-07-02 12:33 ` [f2fs-dev] " Chao Yu 2015-07-02 12:33 ` Chao Yu 2015-06-29 18:39 ` [PATCH 10/12] f2fs: shrink extent_cache entries Jaegeuk Kim 2015-06-29 18:39 ` Jaegeuk Kim 2015-07-02 12:34 ` [f2fs-dev] " Chao Yu 2015-07-02 12:34 ` Chao Yu 2015-06-29 18:39 ` [PATCH 11/12] f2fs: add noextent_cache mount option Jaegeuk Kim 2015-06-29 18:39 ` Jaegeuk Kim 2015-07-02 12:35 ` [f2fs-dev] " Chao Yu 2015-07-02 12:35 ` Chao Yu 2015-07-02 12:35 ` Chao Yu 2015-07-04 4:57 ` [f2fs-dev] " Jaegeuk Kim 2015-07-04 4:57 ` Jaegeuk Kim 2015-06-29 18:39 ` [PATCH 12/12] f2fs: use extent_cache by default Jaegeuk Kim 2015-06-29 18:39 ` Jaegeuk Kim 2015-07-02 12:36 ` [f2fs-dev] " Chao Yu 2015-07-02 12:36 ` Chao Yu 2015-07-04 5:16 ` [f2fs-dev] " Jaegeuk Kim 2015-07-04 5:16 ` Jaegeuk Kim 2015-07-04 6:30 ` [f2fs-dev] " Chao Yu 2015-07-04 6:30 ` Chao Yu 2015-07-06 12:26 ` [f2fs-dev] " Chao Yu 2015-06-30 2:45 ` [f2fs-dev] [PATCH 01/12] f2fs: avoid freed stat information Chao Yu 2015-06-30 2:45 ` Chao Yu
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1435603176-63219-1-git-send-email-jaegeuk@kernel.org \ --to=jaegeuk@kernel.org \ --cc=linux-f2fs-devel@lists.sourceforge.net \ --cc=linux-fsdevel@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.