From: Chao Yu <yuchaochina@hotmail.com> To: "'Jaegeuk Kim'" <jaegeuk@kernel.org> Cc: <linux-fsdevel@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <linux-f2fs-devel@lists.sourceforge.net> Subject: RE: [f2fs-dev] [PATCH 12/12] f2fs: use extent_cache by default Date: Sat, 4 Jul 2015 14:30:15 +0800 [thread overview] Message-ID: <COL402-EAS29173C752AB35D52DE4243DAB950@phx.gbl> (raw) In-Reply-To: <20150704051610.GC15817@jaegeuk-mac02.hsd1.ca.comcast.net> Hi Jaegeuk, > -----Original Message----- > From: Jaegeuk Kim [mailto:jaegeuk@kernel.org] > Sent: Saturday, July 04, 2015 1:16 PM > To: Chao Yu > Cc: linux-fsdevel@vger.kernel.org; linux-kernel@vger.kernel.org; > linux-f2fs-devel@lists.sourceforge.net > Subject: Re: [f2fs-dev] [PATCH 12/12] f2fs: use extent_cache by default [snip] > > > @@ -237,10 +237,11 @@ void update_inode(struct inode *inode, struct page *node_page) > > > ri->i_size = cpu_to_le64(i_size_read(inode)); > > > ri->i_blocks = cpu_to_le64(inode->i_blocks); > > > > > > - read_lock(&F2FS_I(inode)->ext_lock); > > > - set_raw_extent(&F2FS_I(inode)->ext, &ri->i_ext); > > > - read_unlock(&F2FS_I(inode)->ext_lock); > > > - > > > + if (F2FS_I(inode)->extent_tree) > > > > Could extent cache destroy after above check? > > I don't think so. > > The extent_tree is assigned as one way. > Once it is assigned, it will be deallocated only after evict_inode. Previously, I suspected that ->write_inode and ->evict will be executed concurrently. After checking the code, I find that would not happen, so we are safe. Thanks, > > Thanks, > > > > > Thanks,
WARNING: multiple messages have this Message-ID (diff)
From: Chao Yu <yuchaochina@hotmail.com> To: "'Jaegeuk Kim'" <jaegeuk@kernel.org> Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Subject: Re: [PATCH 12/12] f2fs: use extent_cache by default Date: Sat, 4 Jul 2015 14:30:15 +0800 [thread overview] Message-ID: <COL402-EAS29173C752AB35D52DE4243DAB950@phx.gbl> (raw) In-Reply-To: <20150704051610.GC15817@jaegeuk-mac02.hsd1.ca.comcast.net> Hi Jaegeuk, > -----Original Message----- > From: Jaegeuk Kim [mailto:jaegeuk@kernel.org] > Sent: Saturday, July 04, 2015 1:16 PM > To: Chao Yu > Cc: linux-fsdevel@vger.kernel.org; linux-kernel@vger.kernel.org; > linux-f2fs-devel@lists.sourceforge.net > Subject: Re: [f2fs-dev] [PATCH 12/12] f2fs: use extent_cache by default [snip] > > > @@ -237,10 +237,11 @@ void update_inode(struct inode *inode, struct page *node_page) > > > ri->i_size = cpu_to_le64(i_size_read(inode)); > > > ri->i_blocks = cpu_to_le64(inode->i_blocks); > > > > > > - read_lock(&F2FS_I(inode)->ext_lock); > > > - set_raw_extent(&F2FS_I(inode)->ext, &ri->i_ext); > > > - read_unlock(&F2FS_I(inode)->ext_lock); > > > - > > > + if (F2FS_I(inode)->extent_tree) > > > > Could extent cache destroy after above check? > > I don't think so. > > The extent_tree is assigned as one way. > Once it is assigned, it will be deallocated only after evict_inode. Previously, I suspected that ->write_inode and ->evict will be executed concurrently. After checking the code, I find that would not happen, so we are safe. Thanks, > > Thanks, > > > > > Thanks, ------------------------------------------------------------------------------ Don't Limit Your Business. Reach for the Cloud. GigeNET's Cloud Solutions provide you with the tools and support that you need to offload your IT needs and focus on growing your business. Configured For All Businesses. Start Your Cloud Today. https://www.gigenetcloud.com/
next prev parent reply other threads:[~2015-07-04 6:30 UTC|newest] Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-06-29 18:39 [PATCH 01/12] f2fs: avoid freed stat information Jaegeuk Kim 2015-06-29 18:39 ` Jaegeuk Kim 2015-06-29 18:39 ` [PATCH 02/12] f2fs: avoid to use failed inode immediately Jaegeuk Kim 2015-06-29 18:39 ` Jaegeuk Kim 2015-06-30 2:54 ` [f2fs-dev] " Chao Yu 2015-06-29 18:39 ` [PATCH 03/12] f2fs: convert inline_data for various fallocate Jaegeuk Kim 2015-06-29 18:39 ` Jaegeuk Kim 2015-06-30 2:58 ` [f2fs-dev] " Chao Yu 2015-06-29 18:39 ` [PATCH 04/12] f2fs: remove wrong f2fs_bug_on when merging extents Jaegeuk Kim 2015-06-29 18:39 ` Jaegeuk Kim 2015-06-30 3:00 ` [f2fs-dev] " Chao Yu 2015-06-30 3:00 ` Chao Yu 2015-07-01 1:02 ` [f2fs-dev] " Jaegeuk Kim 2015-06-29 18:39 ` [PATCH 05/12] f2fs: fix wrong block address calculation for a split extent Jaegeuk Kim 2015-06-29 18:39 ` Jaegeuk Kim 2015-06-30 3:08 ` [f2fs-dev] " Chao Yu 2015-06-30 3:08 ` Chao Yu 2015-06-29 18:39 ` [PATCH 06/12] f2fs: update on-disk extents even under extent_cache Jaegeuk Kim 2015-06-29 18:39 ` Jaegeuk Kim 2015-06-30 3:10 ` [f2fs-dev] " Chao Yu 2015-06-29 18:39 ` [PATCH 07/12] f2fs: set cached_en after checking finally Jaegeuk Kim 2015-06-30 3:26 ` [f2fs-dev] " Chao Yu 2015-06-30 3:26 ` Chao Yu 2015-06-29 18:39 ` [PATCH 08/12] f2fs: introduce a shrinker for mounted fs Jaegeuk Kim 2015-06-29 18:39 ` Jaegeuk Kim 2015-06-30 3:43 ` [f2fs-dev] " Chao Yu 2015-06-30 3:43 ` Chao Yu 2015-07-01 1:28 ` [f2fs-dev] " Jaegeuk Kim 2015-07-02 12:32 ` Chao Yu 2015-07-02 12:32 ` Chao Yu 2015-07-04 4:51 ` [f2fs-dev] " Jaegeuk Kim 2015-07-04 4:51 ` Jaegeuk Kim 2015-06-29 18:39 ` [PATCH 09/12] f2fs: shrink nat_cache entries Jaegeuk Kim 2015-06-29 18:39 ` Jaegeuk Kim 2015-07-02 12:33 ` [f2fs-dev] " Chao Yu 2015-07-02 12:33 ` Chao Yu 2015-06-29 18:39 ` [PATCH 10/12] f2fs: shrink extent_cache entries Jaegeuk Kim 2015-06-29 18:39 ` Jaegeuk Kim 2015-07-02 12:34 ` [f2fs-dev] " Chao Yu 2015-07-02 12:34 ` Chao Yu 2015-06-29 18:39 ` [PATCH 11/12] f2fs: add noextent_cache mount option Jaegeuk Kim 2015-06-29 18:39 ` Jaegeuk Kim 2015-07-02 12:35 ` [f2fs-dev] " Chao Yu 2015-07-02 12:35 ` Chao Yu 2015-07-02 12:35 ` Chao Yu 2015-07-04 4:57 ` [f2fs-dev] " Jaegeuk Kim 2015-07-04 4:57 ` Jaegeuk Kim 2015-06-29 18:39 ` [PATCH 12/12] f2fs: use extent_cache by default Jaegeuk Kim 2015-06-29 18:39 ` Jaegeuk Kim 2015-07-02 12:36 ` [f2fs-dev] " Chao Yu 2015-07-02 12:36 ` Chao Yu 2015-07-04 5:16 ` [f2fs-dev] " Jaegeuk Kim 2015-07-04 5:16 ` Jaegeuk Kim 2015-07-04 6:30 ` Chao Yu [this message] 2015-07-04 6:30 ` Chao Yu 2015-07-06 12:26 ` [f2fs-dev] " Chao Yu 2015-06-30 2:45 ` [f2fs-dev] [PATCH 01/12] f2fs: avoid freed stat information Chao Yu 2015-06-30 2:45 ` Chao Yu
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=COL402-EAS29173C752AB35D52DE4243DAB950@phx.gbl \ --to=yuchaochina@hotmail.com \ --cc=jaegeuk@kernel.org \ --cc=linux-f2fs-devel@lists.sourceforge.net \ --cc=linux-fsdevel@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.