From: Shawn Lin <shawn.lin@rock-chips.com> To: Vinod Koul <vinod.koul@intel.com>, Heiko Stuebner <heiko@sntech.de>, Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>, Mark Brown <broonie@kernel.org> Cc: Doug Anderson <dianders@chromium.org>, Olof Johansson <olofj@google.com>, Sonny Rao <sonnyrao@chromium.org>, Addy Ke <addy.ke@rock-chips.com>, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, alsa-devel@alsa-project.org, linux-spi@vger.kernel.org, Boojin Kim <boojin.kim@samsung.com>, Shawn Lin <shawn.lin@rock-chips.com>, Olof Johansson <olof@lixom.net> Subject: [PATCH v4 01/10] DMA: pl330: support burst mode for dev-to-mem and mem-to-dev transmit Date: Sun, 6 Sep 2015 09:11:47 +0800 [thread overview] Message-ID: <1441501907-13743-1-git-send-email-shawn.lin@rock-chips.com> (raw) In-Reply-To: <1441501881-13700-1-git-send-email-shawn.lin@rock-chips.com> From: Boojin Kim <boojin.kim@samsung.com> This patch adds to support burst mode for dev-to-mem and mem-to-dev transmit. Signed-off-by: Boojin Kim <boojin.kim@samsung.com> Signed-off-by: Addy Ke <addy.ke@rock-chips.com> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com> cc: Heiko Stuebner <heiko@sntech.de> cc: Doug Anderson <dianders@chromium.org> cc: Olof Johansson <olof@lixom.net> Reviewed-by: Sonny Rao <sonnyrao@chromium.org> --- Changes in v4: None Changes in v3: None Changes in v2: - amend the author - reorder the patches suggested by Doug - add Reviewed-by: Doug Anderson <dianders@chromium.org> for rk3288.dtsi patch and arm-pl330.txt patch Changes in v1: - rename broken-no-flushp to "arm,pl330-broken-no-flushp" suggested by Krzysztof. - add From original author. - remove Sunny's tag drivers/dma/pl330.c | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c index ecab4ea0..0d544d2 100644 --- a/drivers/dma/pl330.c +++ b/drivers/dma/pl330.c @@ -1141,10 +1141,13 @@ static inline int _ldst_devtomem(unsigned dry_run, u8 buf[], const struct _xfer_spec *pxs, int cyc) { int off = 0; + enum pl330_cond cond; + + cond = (pxs->desc->rqcfg.brst_len == 1) ? SINGLE : BURST; while (cyc--) { - off += _emit_WFP(dry_run, &buf[off], SINGLE, pxs->desc->peri); - off += _emit_LDP(dry_run, &buf[off], SINGLE, pxs->desc->peri); + off += _emit_WFP(dry_run, &buf[off], cond, pxs->desc->peri); + off += _emit_LDP(dry_run, &buf[off], cond, pxs->desc->peri); off += _emit_ST(dry_run, &buf[off], ALWAYS); off += _emit_FLUSHP(dry_run, &buf[off], pxs->desc->peri); } @@ -1156,11 +1159,14 @@ static inline int _ldst_memtodev(unsigned dry_run, u8 buf[], const struct _xfer_spec *pxs, int cyc) { int off = 0; + enum pl330_cond cond; + + cond = (pxs->desc->rqcfg.brst_len == 1) ? SINGLE : BURST; while (cyc--) { - off += _emit_WFP(dry_run, &buf[off], SINGLE, pxs->desc->peri); + off += _emit_WFP(dry_run, &buf[off], cond, pxs->desc->peri); off += _emit_LD(dry_run, &buf[off], ALWAYS); - off += _emit_STP(dry_run, &buf[off], SINGLE, pxs->desc->peri); + off += _emit_STP(dry_run, &buf[off], cond, pxs->desc->peri); off += _emit_FLUSHP(dry_run, &buf[off], pxs->desc->peri); } @@ -2557,7 +2563,7 @@ static struct dma_async_tx_descriptor *pl330_prep_dma_cyclic( desc->rqtype = direction; desc->rqcfg.brst_size = pch->burst_sz; - desc->rqcfg.brst_len = 1; + desc->rqcfg.brst_len = pch->burst_len; desc->bytes_requested = period_len; fill_px(&desc->px, dst, src, period_len); @@ -2702,7 +2708,7 @@ pl330_prep_slave_sg(struct dma_chan *chan, struct scatterlist *sgl, } desc->rqcfg.brst_size = pch->burst_sz; - desc->rqcfg.brst_len = 1; + desc->rqcfg.brst_len = pch->burst_len; desc->rqtype = direction; desc->bytes_requested = sg_dma_len(sg); } -- 2.3.7
WARNING: multiple messages have this Message-ID (diff)
From: shawn.lin@rock-chips.com (Shawn Lin) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v4 01/10] DMA: pl330: support burst mode for dev-to-mem and mem-to-dev transmit Date: Sun, 6 Sep 2015 09:11:47 +0800 [thread overview] Message-ID: <1441501907-13743-1-git-send-email-shawn.lin@rock-chips.com> (raw) In-Reply-To: <1441501881-13700-1-git-send-email-shawn.lin@rock-chips.com> From: Boojin Kim <boojin.kim@samsung.com> This patch adds to support burst mode for dev-to-mem and mem-to-dev transmit. Signed-off-by: Boojin Kim <boojin.kim@samsung.com> Signed-off-by: Addy Ke <addy.ke@rock-chips.com> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com> cc: Heiko Stuebner <heiko@sntech.de> cc: Doug Anderson <dianders@chromium.org> cc: Olof Johansson <olof@lixom.net> Reviewed-by: Sonny Rao <sonnyrao@chromium.org> --- Changes in v4: None Changes in v3: None Changes in v2: - amend the author - reorder the patches suggested by Doug - add Reviewed-by: Doug Anderson <dianders@chromium.org> for rk3288.dtsi patch and arm-pl330.txt patch Changes in v1: - rename broken-no-flushp to "arm,pl330-broken-no-flushp" suggested by Krzysztof. - add From original author. - remove Sunny's tag drivers/dma/pl330.c | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c index ecab4ea0..0d544d2 100644 --- a/drivers/dma/pl330.c +++ b/drivers/dma/pl330.c @@ -1141,10 +1141,13 @@ static inline int _ldst_devtomem(unsigned dry_run, u8 buf[], const struct _xfer_spec *pxs, int cyc) { int off = 0; + enum pl330_cond cond; + + cond = (pxs->desc->rqcfg.brst_len == 1) ? SINGLE : BURST; while (cyc--) { - off += _emit_WFP(dry_run, &buf[off], SINGLE, pxs->desc->peri); - off += _emit_LDP(dry_run, &buf[off], SINGLE, pxs->desc->peri); + off += _emit_WFP(dry_run, &buf[off], cond, pxs->desc->peri); + off += _emit_LDP(dry_run, &buf[off], cond, pxs->desc->peri); off += _emit_ST(dry_run, &buf[off], ALWAYS); off += _emit_FLUSHP(dry_run, &buf[off], pxs->desc->peri); } @@ -1156,11 +1159,14 @@ static inline int _ldst_memtodev(unsigned dry_run, u8 buf[], const struct _xfer_spec *pxs, int cyc) { int off = 0; + enum pl330_cond cond; + + cond = (pxs->desc->rqcfg.brst_len == 1) ? SINGLE : BURST; while (cyc--) { - off += _emit_WFP(dry_run, &buf[off], SINGLE, pxs->desc->peri); + off += _emit_WFP(dry_run, &buf[off], cond, pxs->desc->peri); off += _emit_LD(dry_run, &buf[off], ALWAYS); - off += _emit_STP(dry_run, &buf[off], SINGLE, pxs->desc->peri); + off += _emit_STP(dry_run, &buf[off], cond, pxs->desc->peri); off += _emit_FLUSHP(dry_run, &buf[off], pxs->desc->peri); } @@ -2557,7 +2563,7 @@ static struct dma_async_tx_descriptor *pl330_prep_dma_cyclic( desc->rqtype = direction; desc->rqcfg.brst_size = pch->burst_sz; - desc->rqcfg.brst_len = 1; + desc->rqcfg.brst_len = pch->burst_len; desc->bytes_requested = period_len; fill_px(&desc->px, dst, src, period_len); @@ -2702,7 +2708,7 @@ pl330_prep_slave_sg(struct dma_chan *chan, struct scatterlist *sgl, } desc->rqcfg.brst_size = pch->burst_sz; - desc->rqcfg.brst_len = 1; + desc->rqcfg.brst_len = pch->burst_len; desc->rqtype = direction; desc->bytes_requested = sg_dma_len(sg); } -- 2.3.7
next prev parent reply other threads:[~2015-09-06 1:13 UTC|newest] Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-09-06 1:11 [PATCH v4 0/10] Fix broken DMAFLUSHP on Rockchips platform Shawn Lin 2015-09-06 1:11 ` Shawn Lin 2015-09-06 1:11 ` Shawn Lin 2015-09-06 1:11 ` Shawn Lin [this message] 2015-09-06 1:11 ` [PATCH v4 01/10] DMA: pl330: support burst mode for dev-to-mem and mem-to-dev transmit Shawn Lin 2015-09-06 1:12 ` [PATCH v4 02/10] Documentation: arm-pl330: add description of arm,pl330-broken-no-flushp Shawn Lin 2015-09-06 1:12 ` [PATCH v4 02/10] Documentation: arm-pl330: add description of arm, pl330-broken-no-flushp Shawn Lin 2015-09-06 1:12 ` [PATCH v4 02/10] Documentation: arm-pl330: add description of arm,pl330-broken-no-flushp Shawn Lin 2015-09-06 1:12 ` [PATCH v4 03/10] DMA: pl330: add quirk for broken no flushp Shawn Lin 2015-09-06 1:12 ` Shawn Lin 2015-09-06 1:12 ` [PATCH v4 04/10] ARM: dts: Add arm,pl330-broken-no-flushp quirk for rk3288 platform Shawn Lin 2015-09-06 1:12 ` [PATCH v4 04/10] ARM: dts: Add arm, pl330-broken-no-flushp " Shawn Lin 2015-09-06 1:12 ` [PATCH v4 04/10] ARM: dts: Add arm,pl330-broken-no-flushp " Shawn Lin 2015-09-06 1:12 ` [PATCH v4 05/10] ARM: dts: Add arm,pl330-broken-no-flushp quirk for rk3xxx platform Shawn Lin 2015-09-06 1:12 ` [PATCH v4 05/10] ARM: dts: Add arm, pl330-broken-no-flushp " Shawn Lin 2015-09-06 1:12 ` [PATCH v4 05/10] ARM: dts: Add arm,pl330-broken-no-flushp " Shawn Lin 2015-09-06 1:12 ` [PATCH v4 06/10] dmaengine: add API for getting dma controller's quirk Shawn Lin 2015-09-06 1:12 ` Shawn Lin 2015-09-06 1:12 ` [PATCH v4 07/10] DMA: pl330: implement dmaengine_get_quirks hook Shawn Lin 2015-09-06 1:12 ` Shawn Lin 2015-09-06 1:12 ` Shawn Lin 2015-09-06 1:13 ` [PATCH v4 08/10] spi: rockchip: modify DMA max burst to 1 Shawn Lin 2015-09-06 1:13 ` Shawn Lin 2015-09-11 11:28 ` Mark Brown 2015-09-11 11:28 ` Mark Brown 2015-09-11 11:28 ` Mark Brown 2015-09-06 1:13 ` [PATCH v4 09/10] snd: dmaengine-pcm: add snd_dmaengine_pcm_get_quirks interface Shawn Lin 2015-09-06 1:13 ` Shawn Lin 2015-09-06 1:13 ` [PATCH v4 10/10] ASoC: rockchip_i2s: modify DMA max burst to 1 Shawn Lin 2015-09-06 1:13 ` Shawn Lin 2015-09-06 1:13 ` Shawn Lin 2015-09-11 11:53 ` Mark Brown 2015-09-11 11:53 ` Mark Brown 2015-09-11 11:53 ` Mark Brown 2015-09-11 12:31 ` Shawn Lin 2015-09-11 12:31 ` Shawn Lin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1441501907-13743-1-git-send-email-shawn.lin@rock-chips.com \ --to=shawn.lin@rock-chips.com \ --cc=addy.ke@rock-chips.com \ --cc=alsa-devel@alsa-project.org \ --cc=boojin.kim@samsung.com \ --cc=broonie@kernel.org \ --cc=dianders@chromium.org \ --cc=dmaengine@vger.kernel.org \ --cc=heiko@sntech.de \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-rockchip@lists.infradead.org \ --cc=linux-spi@vger.kernel.org \ --cc=olof@lixom.net \ --cc=olofj@google.com \ --cc=perex@perex.cz \ --cc=sonnyrao@chromium.org \ --cc=tiwai@suse.com \ --cc=vinod.koul@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.