From: Mark Brown <broonie@kernel.org>
To: Shawn Lin <shawn.lin@rock-chips.com>
Cc: Vinod Koul <vinod.koul@intel.com>,
Heiko Stuebner <heiko@sntech.de>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Doug Anderson <dianders@chromium.org>,
Olof Johansson <olofj@google.com>,
Sonny Rao <sonnyrao@chromium.org>,
Addy Ke <addy.ke@rock-chips.com>,
dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, alsa-devel@alsa-project.org,
linux-spi@vger.kernel.org, Olof Johansson <olof@lixom.net>
Subject: Re: [PATCH v4 08/10] spi: rockchip: modify DMA max burst to 1
Date: Fri, 11 Sep 2015 12:28:07 +0100 [thread overview]
Message-ID: <20150911112807.GH12027@sirena.org.uk> (raw)
In-Reply-To: <1441501986-14034-1-git-send-email-shawn.lin@rock-chips.com>
[-- Attachment #1: Type: text/plain, Size: 420 bytes --]
On Sun, Sep 06, 2015 at 09:13:06AM +0800, Shawn Lin wrote:
> From: Addy Ke <addy.ke@rock-chips.com>
>
> Generic dma controller on Rockchips' platform cannot support
> DMAFLUSHP instruction which make dma to flush the req of non-aligned
> or non-multiple of what we need. That will cause an unrecoverable
> dma bus error. The saftest way is to set dma max burst to 1.
Acked-by: Mark Brown <broonie@kernel.org>
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Shawn Lin <shawn.lin-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
Cc: Vinod Koul <vinod.koul-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>,
Jaroslav Kysela <perex-/Fr2/VpizcU@public.gmane.org>,
Takashi Iwai <tiwai-IBi9RG/b67k@public.gmane.org>,
Doug Anderson <dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
Olof Johansson <olofj-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>,
Sonny Rao <sonnyrao-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
Addy Ke <addy.ke-TNX95d0MmH7DzftRWevZcw@public.gmane.org>,
dmaengine-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org,
linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Olof Johansson <olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>
Subject: Re: [PATCH v4 08/10] spi: rockchip: modify DMA max burst to 1
Date: Fri, 11 Sep 2015 12:28:07 +0100 [thread overview]
Message-ID: <20150911112807.GH12027@sirena.org.uk> (raw)
In-Reply-To: <1441501986-14034-1-git-send-email-shawn.lin-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 474 bytes --]
On Sun, Sep 06, 2015 at 09:13:06AM +0800, Shawn Lin wrote:
> From: Addy Ke <addy.ke-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
>
> Generic dma controller on Rockchips' platform cannot support
> DMAFLUSHP instruction which make dma to flush the req of non-aligned
> or non-multiple of what we need. That will cause an unrecoverable
> dma bus error. The saftest way is to set dma max burst to 1.
Acked-by: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: broonie@kernel.org (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 08/10] spi: rockchip: modify DMA max burst to 1
Date: Fri, 11 Sep 2015 12:28:07 +0100 [thread overview]
Message-ID: <20150911112807.GH12027@sirena.org.uk> (raw)
In-Reply-To: <1441501986-14034-1-git-send-email-shawn.lin@rock-chips.com>
On Sun, Sep 06, 2015 at 09:13:06AM +0800, Shawn Lin wrote:
> From: Addy Ke <addy.ke@rock-chips.com>
>
> Generic dma controller on Rockchips' platform cannot support
> DMAFLUSHP instruction which make dma to flush the req of non-aligned
> or non-multiple of what we need. That will cause an unrecoverable
> dma bus error. The saftest way is to set dma max burst to 1.
Acked-by: Mark Brown <broonie@kernel.org>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150911/ceedbc0c/attachment.sig>
next prev parent reply other threads:[~2015-09-11 11:28 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-06 1:11 [PATCH v4 0/10] Fix broken DMAFLUSHP on Rockchips platform Shawn Lin
2015-09-06 1:11 ` Shawn Lin
2015-09-06 1:11 ` Shawn Lin
2015-09-06 1:11 ` [PATCH v4 01/10] DMA: pl330: support burst mode for dev-to-mem and mem-to-dev transmit Shawn Lin
2015-09-06 1:11 ` Shawn Lin
2015-09-06 1:12 ` [PATCH v4 02/10] Documentation: arm-pl330: add description of arm,pl330-broken-no-flushp Shawn Lin
2015-09-06 1:12 ` [PATCH v4 02/10] Documentation: arm-pl330: add description of arm, pl330-broken-no-flushp Shawn Lin
2015-09-06 1:12 ` [PATCH v4 02/10] Documentation: arm-pl330: add description of arm,pl330-broken-no-flushp Shawn Lin
2015-09-06 1:12 ` [PATCH v4 03/10] DMA: pl330: add quirk for broken no flushp Shawn Lin
2015-09-06 1:12 ` Shawn Lin
2015-09-06 1:12 ` [PATCH v4 04/10] ARM: dts: Add arm,pl330-broken-no-flushp quirk for rk3288 platform Shawn Lin
2015-09-06 1:12 ` [PATCH v4 04/10] ARM: dts: Add arm, pl330-broken-no-flushp " Shawn Lin
2015-09-06 1:12 ` [PATCH v4 04/10] ARM: dts: Add arm,pl330-broken-no-flushp " Shawn Lin
2015-09-06 1:12 ` [PATCH v4 05/10] ARM: dts: Add arm,pl330-broken-no-flushp quirk for rk3xxx platform Shawn Lin
2015-09-06 1:12 ` [PATCH v4 05/10] ARM: dts: Add arm, pl330-broken-no-flushp " Shawn Lin
2015-09-06 1:12 ` [PATCH v4 05/10] ARM: dts: Add arm,pl330-broken-no-flushp " Shawn Lin
2015-09-06 1:12 ` [PATCH v4 06/10] dmaengine: add API for getting dma controller's quirk Shawn Lin
2015-09-06 1:12 ` Shawn Lin
2015-09-06 1:12 ` [PATCH v4 07/10] DMA: pl330: implement dmaengine_get_quirks hook Shawn Lin
2015-09-06 1:12 ` Shawn Lin
2015-09-06 1:12 ` Shawn Lin
2015-09-06 1:13 ` [PATCH v4 08/10] spi: rockchip: modify DMA max burst to 1 Shawn Lin
2015-09-06 1:13 ` Shawn Lin
2015-09-11 11:28 ` Mark Brown [this message]
2015-09-11 11:28 ` Mark Brown
2015-09-11 11:28 ` Mark Brown
2015-09-06 1:13 ` [PATCH v4 09/10] snd: dmaengine-pcm: add snd_dmaengine_pcm_get_quirks interface Shawn Lin
2015-09-06 1:13 ` Shawn Lin
2015-09-06 1:13 ` [PATCH v4 10/10] ASoC: rockchip_i2s: modify DMA max burst to 1 Shawn Lin
2015-09-06 1:13 ` Shawn Lin
2015-09-06 1:13 ` Shawn Lin
2015-09-11 11:53 ` Mark Brown
2015-09-11 11:53 ` Mark Brown
2015-09-11 11:53 ` Mark Brown
2015-09-11 12:31 ` Shawn Lin
2015-09-11 12:31 ` Shawn Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150911112807.GH12027@sirena.org.uk \
--to=broonie@kernel.org \
--cc=addy.ke@rock-chips.com \
--cc=alsa-devel@alsa-project.org \
--cc=dianders@chromium.org \
--cc=dmaengine@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=olof@lixom.net \
--cc=olofj@google.com \
--cc=perex@perex.cz \
--cc=shawn.lin@rock-chips.com \
--cc=sonnyrao@chromium.org \
--cc=tiwai@suse.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.