Re: [OSSTEST PATCH 6/9] db_retry: Suppress an "exiting via last" warning

From: Ian Campbell <ian.campbell@citrix.com>
To: Ian Jackson <ian.jackson@eu.citrix.com>, xen-devel@lists.xenproject.org
Subject: Re: [OSSTEST PATCH 6/9] db_retry: Suppress an "exiting via last" warning
Date: Thu, 17 Dec 2015 17:31:13 +0000	[thread overview]
Message-ID: <1450373473.4053.147.camel@citrix.com> (raw)
In-Reply-To: <1450371968-27997-6-git-send-email-ian.jackson@eu.citrix.com>

On Thu, 2015-12-17 at 17:06 +0000, Ian Jackson wrote:
> This warning appears when db_retry_abort is used, since 2b069b6c
> "Database locking: Perl: Retry all deadlocks in PostgreSQL".

Is the reason for not turning this into a return related to the fact this
is within an eval, not a proper sub? But then I'm not really sure why it is
warning (I suppose eval has some sub like properties?).

Related to https://rt.perl.org/Public/Bug/Display.html?id=29238 perhaps.

> Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
> ---
>  Osstest.pm |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Osstest.pm b/Osstest.pm
> index c77d960..a398b1e 100644
> --- a/Osstest.pm
> +++ b/Osstest.pm
> @@ -299,6 +299,7 @@ sub db_retry ($$$;$$) {
>  	    $r= &$body;
>  	    if ($db_retry_stop) {
>  		$dbh->rollback();
> +		no warnings qw(exiting);
>  		last if $db_retry_stop eq 'abort';
>  		next;
>  	    }

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel