Re: [OSSTEST PATCH 8/9] mg-allocate: Better error handling when no candidates

From: Ian Campbell <ian.campbell@citrix.com>
To: Ian Jackson <ian.jackson@eu.citrix.com>, xen-devel@lists.xenproject.org
Subject: Re: [OSSTEST PATCH 8/9] mg-allocate: Better error handling when no candidates
Date: Thu, 17 Dec 2015 17:33:11 +0000	[thread overview]
Message-ID: <1450373591.4053.149.camel@citrix.com> (raw)
In-Reply-To: <1450371968-27997-8-git-send-email-ian.jackson@eu.citrix.com>

On Thu, 2015-12-17 at 17:06 +0000, Ian Jackson wrote:
> Spot when our db search revealed no candidates for the resources to
> allocate, and:
>  - when doing an immediate allocation, call it an error
>  - when doing a planned allocation, cause it to prevent allocation
>    on this iteration, and print a suitably unreassuring message
> 
> Previously it would simply say `nothing available'.
> 
> Implement this as follows:
>  - Report lack of candidates as $ok=-1 from alloc_1rescand
>  - In alloc_1res, return this -1 as with any non-zero $ok
>  - Handle the new $ok at all the call sites, in particular
>  - In plan(), rename `allok' to `worstok' and have it be
>    the worst relevant $ok value.  If $ok gives -1, return
>    undef, rather than a booking list, to the allocator core.
> 
> Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>

Acked-by: Ian Campbell <ian.campbell@citrix.com>


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel